https://pantsbuild.org/ logo
Powered by
#development
  • h

    happy-kitchen-89482

    02/24/2021, 4:39 PM
    Copy code
    The license has changed. Starting with the 4.0.0 release, redistributions bundled with commercial software are not allowed without specific prior written permission.
  • h

    happy-kitchen-89482

    02/24/2021, 4:39 PM
    Pants is not commercial software so we're OK, but the ice may get thinner in the future since he can apparently change the license at will
  • h

    happy-kitchen-89482

    02/24/2021, 4:41 PM
    This claims that thanks to permissions changes on the image, you can use osxfuse on GHA without a reboot: https://github.com/actions/virtual-environments/issues/598#issuecomment-619567092
  • h

    happy-kitchen-89482

    02/24/2021, 5:39 PM
    The osxfuse example in that link works in our setup without a reboot: https://github.com/pantsbuild/pants/runs/1972007162?check_suite_focus=true
    🚀 1
  • h

    happy-kitchen-89482

    02/24/2021, 5:39 PM
    (see osfux job)
  • h

    happy-kitchen-89482

    02/24/2021, 6:02 PM
    So hmmmm
  • a

    average-vr-56795

    02/24/2021, 6:09 PM
    Feel free to delete 
    brfs
    if it's causing problems, I'd be surprised if anyone was actually using it
  • h

    hundreds-breakfast-49010

    02/24/2021, 6:14 PM
    "Deploying a kext requires it be signed using a special Kernel Extension Signing Certificate, which can only be acquired from Apple. Getting one of these certs requires going through a fairly rigorous application process. And of course, at the end of it all, you can be denied with no real recourse. Basically, your project lives and dies at the will of Apple–a markedly different approach from what you’re used to if you’re used to the Linux and Windows approaches to third-party kernel modules." ugh, I hate this sort of thing
  • h

    happy-kitchen-89482

    02/24/2021, 6:52 PM
    I don't know if that would help, @witty-crayon-22786 thoughts?
  • w

    witty-crayon-22786

    02/24/2021, 6:54 PM
    @enough-analyst-54434 has had some ambitions to use it. but i think that BuildGrid/Stream also have a local cas daemon that can do something similar in a read/write fashion. @fast-nail-55400 might have investigated that more.
    f
    • 2
    • 6
  • w

    witty-crayon-22786

    02/24/2021, 6:54 PM
    let’s say: it’s in a niche that we still expect to need to explore in the next ~year. but not urgently.
  • w

    witty-crayon-22786

    02/24/2021, 7:00 PM
    there would be pretty significant complexity to integrating “some other” fuse implementation (brfs uses our backing store, is written in rust, etc). imo, let’s try medium hard to keep it, and expect that if we delete it, we’ll be restoring it.
  • h

    happy-kitchen-89482

    02/24/2021, 7:13 PM
    I'm not sure deleting it would help as I don't know the scope of those failing tests
  • a

    average-vr-56795

    02/24/2021, 7:55 PM
    I suspect re-writing it would be a day or two's work, and I'm pretty sure we'd want to rewrite it to be more async-first...
    đź‘Ť 1
  • a

    average-vr-56795

    02/24/2021, 7:56 PM
    brfs
    is the only thing that uses FUSE, so I suspect deleting it would make the problem go away... An alternative would be to just not run those tests on CI - compiling should be sufficient, and then you'd only need libfuse to link against, not a runtime dependency...
  • h

    hundreds-father-404

    02/24/2021, 7:59 PM
    On the note of unused code, any reason to keep around the Nailgun CommandRunner and 
    --process-execution-local-enable-nailgun
    ? Will we keep it mostly as is when adding back JVM, or it's bit rotted?
  • a

    average-vr-56795

    02/24/2021, 8:02 PM
    50:50... It will probably work fine, but it was also shoe-horned in pretty quickly to solve an urgent need, so I'm not sure it's how we'd design it from scratch if we were, but maybe it is
  • a

    average-vr-56795

    02/24/2021, 8:02 PM
    I guess the question is: Would we rather keep maintaining it, or have to do a big bang catch-up if we decide to delete it and then revert that
    h
    w
    • 3
    • 4
  • h

    hundreds-father-404

    02/24/2021, 9:18 PM
    Hi again! I'm planning to upstream today a little backend toolchain made to aggregate all counters and histograms, then print them to the console at the end of the run. I think this should always be activated, and toggled with a bool option. What do you think for names?
    Copy code
    --stats-collector-enable
--stats-aggregator-enable
--debug-stats-enable
    e
    h
    +2
    • 5
    • 29
  • w

    witty-crayon-22786

    02/24/2021, 10:26 PM
    argh! the 3 lines of unsafe code that i wrote yesterday caused a 4 hour debug session today
    âť— 1
    h
    • 2
    • 4
  • h

    happy-kitchen-89482

    02/24/2021, 11:58 PM
    We now have a useful CI passing on Github Actions!
    🚀 2
    âť— 1
  • h

    happy-kitchen-89482

    02/24/2021, 11:58 PM
  • h

    happy-kitchen-89482

    02/24/2021, 11:58 PM
    Including respecting the 
    [ci skip-rust]
    notation
    🚀 1
  • h

    happy-kitchen-89482

    02/25/2021, 12:21 AM
    It does not build wheels, or do anything related to releases
  • h

    happy-kitchen-89482

    02/25/2021, 12:21 AM
    so this is just for PR runs right now
  • h

    happy-kitchen-89482

    02/25/2021, 12:21 AM
    We can do master branch builds and release builds on travis for now, we have enough free capacity there for that
  • w

    witty-crayon-22786

    02/25/2021, 12:51 AM
    hooray! awesome stuff.
  • w

    witty-crayon-22786

    02/25/2021, 12:51 AM
    could it also run the tests for branches as well, and then only the actually release cutting would be in travis?
  • h

    happy-kitchen-89482

    02/25/2021, 1:11 AM
    Yes but it doesn't build wheels
  • w

    witty-crayon-22786

    02/25/2021, 2:04 AM
    yea, that’s fine.
1...778779780...906Latest