https://pantsbuild.org/ logo
Powered by
#development
  • h

    hundreds-father-404

    11/10/2020, 8:02 PM
    I found an awkward UX bug:
    Copy code
    ▶ ./pants test src/python/pants/util/strutil_test.py src/python/pants/util:tests
...
✓ src/python/pants/util/strutil_test.py:tests succeeded.
✓ src/python/pants/util/strutil_test.py:tests succeeded.
    That is, the result shows up twice for the same file address. That’s because 
    TargetRootsToFieldSets
    stores a mapping of 
    TargetsWithOrigin
    to 
    FieldSet
    , and this is the same target but two distinct origins The fix is simple for this if we can get rid of 
    TargetsWithOrigin
    et al. We no longer use that mechanism anymore, and it has some weight to support. What do we think about shedding the ability to use 
    WithOrigin
    ? In the past, we used it for globbing semantics, to only error if a certain type of spec was used. Since then, we’ve made globbing semantics more uniform to never error and only ever run on things we are able to
    w
    • 2
    • 12
  • w

    wooden-thailand-8386

    11/10/2020, 9:16 PM
    I think I found a bug, it’s a funny one… So I ran my api with:
    Copy code
    FIXTURE_PORT=8080 ./pants run projects/dapi_fixture_api:dapi_fixture_api_pex
    and that worked fine, hit it as expected, no issues there. Then I killed it with 
    Ctrl+C
    and my terminal was back to normal… but when I tried running it again.. it said “Address already in use” and I go check and the API is still running 😐 and yup, it’s there on my 
    ps aux
    output:
    Copy code
    lzfnyy           85055   0.0  0.4  4415100  61256   ??  S     4:09PM   0:25.07 /Users/lzfnyy/.pyenv/versions/3.7.8/bin/python3.7 /Users/lzfnyy/Projects/clueless/.pants.d/tmpw5l_14lu/dapi_fixture_api_pex.pex
    w
    • 2
    • 3
  • h

    hundreds-father-404

    11/11/2020, 6:56 PM
    can I please get a review of https://github.com/pantsbuild/pants/pull/11129/files? It’s the last release blocker for 2.0.1rc1 and 2.1.0rc1
  • f

    fast-nail-55400

    11/13/2020, 11:59 PM
    Copy code
    Multiple copies of pants.pex found at <s3://ci-public.pantsbuild.org/daily/36505/201391758/pants.pex.py36.osx>. This is not allowed as a security precaution. This likely happened from restarting the bootstrap shards in the same Travis build. Instead, initiate a new build by either pulling from master or pushing an empty commit (`git commit --allow-empty`).
    h
    • 2
    • 2
  • c

    chilly-magazine-21545

    11/14/2020, 2:41 AM
  • w

    wooden-thailand-8386

    11/16/2020, 6:22 PM
    Hey folks, do we have a priority list for next languages that'll be supported? A friend asked about JavaScript and I didn't have a good answer.
    h
    • 2
    • 5
  • w

    witty-crayon-22786

    11/16/2020, 9:06 PM
    we’ve discussed having a result or “errored” state on workunits before, but we don’t currently have that
    h
    • 2
    • 30
  • h

    hundreds-father-404

    11/16/2020, 11:23 PM
    For the engine’s memoization, does it really matter that a 
    FrozenDict
    is ordered? Right now, our 
    __eq__
    requires the same ordering, but idk if it matters
    w
    • 2
    • 11
  • h

    happy-kitchen-89482

    11/17/2020, 3:23 AM
    Weird: in my testing of Pants on the django repo, Pants is running without pantsd
  • h

    happy-kitchen-89482

    11/17/2020, 3:23 AM
    Why might that be?
  • h

    happy-kitchen-89482

    11/17/2020, 3:23 AM
    the option is on
  • h

    happy-kitchen-89482

    11/17/2020, 3:24 AM
    (by default, and I've turned it on explicitly just to be sure)
    e
    • 2
    • 5
  • h

    hundreds-father-404

    11/18/2020, 10:49 PM
    Hello, regex + unicode help appreciated if y’all have ideas. Simplified problem: I want to extract out 
    dir/foo.proto
    and 
    ábč.proto
    from this string:
    Copy code
    import "dir/foo.proto"; import "ábč.proto";
    NB the unicode, it’s important that the file name can be any unicode character iiuc. This regex does not work if >1 target:
    Copy code
    import "(.+\.proto)";
    The 
    .+
    is too permissive and results in the first group being 
    dir/foo.proto"; import "ábč.proto
    . But I don’t want to enumerate all valid chars - that’s not feasible with unicode. In Python, 
    \w
    works with unicode chars, so maybe I use something like 
    \w+
    and some of the other valid symbols like 
    -
    and 
    /
    ?
  • h

    hundreds-father-404

    11/18/2020, 10:49 PM
    cc @fast-nail-55400, what I mentioned on our call
  • f

    fast-nail-55400

    11/18/2020, 10:50 PM
    are the valid characters just “not whitespace”? Or is it everything between the quotes?
  • f

    fast-nail-55400

    11/18/2020, 10:51 PM
    also what language are you doing this in? you can configure multi-match mode or something in Python
  • h

    hundreds-father-404

    11/18/2020, 10:51 PM
    it’s everything between the quotes afaict. you can technically have spaces in a file name
  • h

    hundreds-father-404

    11/18/2020, 10:52 PM
    also what language are you doing this in?
    In Python, for import analysis of 
    .proto
    files
    you can configure multi-match mode
    Yeah, but I’m not sure that’s relevant because you can have multiple import statements on the same line in Protobufs. It’s 
    ;
    delimited, rather than newline
  • f

    fast-nail-55400

    11/18/2020, 10:52 PM
  • h

    hundreds-father-404

    11/18/2020, 10:52 PM
    I’m using 
    re.findall()
  • f

    fast-nail-55400

    11/18/2020, 10:54 PM
    you also want to use lazy matching. perl had 
    .*?
    which would consume lazily
    ❗ 1
  • f

    flat-zoo-31952

    11/18/2020, 10:54 PM
    you just need to use 
    .+?
    in the quantifier
    🙏 1
    ❗ 1
  • f

    flat-zoo-31952

    11/18/2020, 10:54 PM
    yeah what tdyas said; python has lazy matching too
  • f

    flat-zoo-31952

    11/18/2020, 10:54 PM
    Copy code
    In [4]: re.findall(r'import "(.+?\.proto)"', s)                                                                                                                                              
Out[4]: ['dir/foo.proto', 'ábč.proto']
  • h

    hundreds-father-404

    11/18/2020, 10:55 PM
    Yay that got the tests passing! Thank you both!
    🙇🏻‍♂️ 1
    👍 1
  • w

    witty-crayon-22786

    11/19/2020, 12:28 AM
    re: the discussion of improving 
    --changed
    : have been thinking about it for a while, and finally spent the time to put it on paper: https://github.com/pantsbuild/pants/issues/11206
    💯 1
    f
    • 2
    • 16
  • f

    fast-nail-55400

    11/19/2020, 4:30 PM
  • h

    hundreds-father-404

    11/19/2020, 7:00 PM
    FYI it’s now safe to use 
    from __future__ import annotations
    in Pants code, as the master branch now requires 3.7 or 3.8 to run
    👍 1
    f
    • 2
    • 2
  • h

    happy-kitchen-89482

    11/21/2020, 5:36 AM
    I wonder if periodically snapshotting the memoized state to disk is feasible? So that less work needs to re-run on pantd restart. Just a thought.
  • h

    hundreds-father-404

    11/21/2020, 5:37 AM
    I’m excited about https://github.com/pantsbuild/pants/pull/11223 that ctrl-c will no longer kill pantsd - lots of great work in there
1...771772773...906Latest