pantsbuild #development

Channels

welcome

github-notifications

development

polite-garden-50641

09/30/2020, 4:51 PM

seeing resource errors when pants is bootstrapping.

fast-nail-55400

10/01/2020, 1:47 AM

I wrote a design doc for adding counter metrics to Pants. I would love comments! https://docs.google.com/document/d/1WGUL9YHwlMFeAG4rwTq7H0G2YNXoFW0pe2K8hNZvK-w/edit#

aloof-angle-91616

10/01/2020, 8:47 PM

cool paper about a build tool that traces syscalls, https://twitter.com/samth/status/1311757095423926277?s=21

👍 1

aloof-angle-91616

10/01/2020, 8:48 PM

https://twitter.com/samth/status/1311765857744416768?s=21 and this library is ridiculously cool

aloof-angle-91616

10/01/2020, 8:48 PM

the paper like didn’t cite any prior art besides build systems a la carte which i got over because i wanted to ask them about tracing

witty-crayon-22786

10/01/2020, 9:13 PM

mm, neat: thanks.

🔥 1

witty-crayon-22786

10/01/2020, 9:13 PM

some other prior art is Build XL by microsoft, but i don’t know if they got it working reliably on other platforms

hundreds-breakfast-49010

10/02/2020, 1:26 AM

I've just set https://github.com/pantsbuild/pants/pull/10865 (porting the nailgun client to Rust) to ready for review

🦀 1

hundreds-breakfast-49010

10/02/2020, 7:12 PM

is it just me or is (what's currently)

nailgun::ServerState

not being used by anything? @witty-crayon-22786

hundreds-father-404

10/02/2020, 10:08 PM

See https://github.com/pantsbuild/pants/issues/10888#issuecomment-702979433 for a Target API limiation I’d love feedback on. (Feel free to discuss in the thread or on GH)

aloof-angle-91616

10/03/2020, 9:33 PM

this is a proposal that folds the functionality of the new

relocatable_files()

target, as well as the established

resources()

target, into the

files()

target (https://github.com/pantsbuild/pants/issues/10902). it's not just because the metadata can technically be squashed together, i also try to make an argument that the proposed replacement is significantly less prone to error and can be parsed by the pants user much more readily. i would mostly love feedback on whether this is a desired and good change to BUILD files, because i don't expect to implement this now, or until automated BUILD file suggested fixes upon pants updates is implemented (https://github.com/pantsbuild/pants/pull/9434).

aloof-angle-91616

10/04/2020, 10:33 PM

it feels a little strange that

@rule

is in

src/python/pants/engine/rules.py

, whereas

Get

is in

.../engine/internal/rules.py

. is

Get

not part of the public API? it seems necessary to import in order to write a plugin, and i would feel weird writing

from pants.engine.internal import Get

if i was intending to use a stable API.

aloof-angle-91616

10/05/2020, 3:34 AM

tried to remove some boilerplate in dependency resolution and accidentally may have fixed the "multiple types of sources and/or dependency fields" issue: https://github.com/pantsbuild/pants/pull/10904

wooden-thailand-8386

10/05/2020, 1:36 PM

hey @happy-kitchen-89482 if you care to take a look at this https://github.com/pantsbuild/pants/pull/10909 I think that’s the easiest way to fix the SSL Cert that’s happening now.

aloof-angle-91616

10/05/2020, 9:57 PM

i spoke with kaushik who works on a git VFS at twitter about the performance we might expect from using a VFS for process execution, and he said that the FUSE driver on osx and linux doesn't do any buffering in itself, so we are not likely to need to edit anything that goes in the kernel, which is nice because that means we can expect to continue work on the

brfs

crate

aloof-angle-91616

10/05/2020, 9:58 PM

also because we know the files that will be written to in advance in most cases (

output_directories

notwithstanding) i personally believe we should be able to get ridiculously faster-than-native speed on writes for processes executed within the VFS

fast-nail-55400

10/10/2020, 10:03 PM

error while rebuilding native engine (via

./pants --version

) on

master

with the Rust 1.47.0 commit

Untitled

chilly-magazine-21545

10/12/2020, 5:18 AM

this is a small change that removes some boilerplate when filtering down target fields for dependencies and sources: https://github.com/pantsbuild/pants/pull/10924. i would love some review on it whenever anyone has the chance

hundreds-breakfast-49010

10/12/2020, 11:26 PM

does anyone know what it means for a semver specification to have an initial

hundreds-breakfast-49010

10/12/2020, 11:27 PM

e.g.

tokio = { version = "=0.2.22", features = ["rt-threaded"] }

from one of the pants repo's Cargo.toml files

hundreds-breakfast-49010

10/12/2020, 11:27 PM

I would assume that means "version equal to 0.2.22", but I'm not sure if that's any different from the semver spec without the

fast-nail-55400

10/12/2020, 11:29 PM

https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html

fast-nail-55400

10/12/2020, 11:29 PM

it is a pin to a specific version versus allowing minor and patchlevel upgrades

fast-nail-55400

10/12/2020, 11:29 PM

Copy code

The string "0.1.12" is a semver version requirement. Since this string does not have any operators in it, it is interpreted the same way as if we had specified "^0.1.12", which is called a caret requirement.

fast-nail-55400

10/12/2020, 11:30 PM

0.2.22

(without the equals) actually means

>=0.2.22,~<1~0.3

👍 1

chilly-magazine-21545

10/13/2020, 3:37 AM

https://github.com/pantsbuild/pants/pull/10954 this allows try/except across an

await Get(...)

, which allows `@rule`s to raise exceptions without necessarily making pants exit immediately. i think this will be very useful for plugin authors, but it is easy to wait if we'd prefer to get 2.0 out the door first

hundreds-father-404

10/13/2020, 8:23 PM

Thoughts on adding a Debug log message dumping all of the options at the start of a run? I think it might help us when we’re looking at logs from users, that we don’t need to ask them what their pants.toml and env vars etc are

happy-kitchen-89482

10/13/2020, 11:04 PM

That's a lot of data

fast-nail-55400

10/15/2020, 12:02 AM

pants.reporting.json_reporting.JsonReporter

still relevant?

hundreds-breakfast-49010

10/15/2020, 10:56 PM

https://github.com/pantsbuild/pants/issues/10971 @hundreds-father-404 fyi

👍 1