pantsbuild #development

Channels

welcome

github-notifications

development

aloof-angle-91616

07/09/2020, 9:54 PM

usually when i have consulted @witty-crayon-22786 we have followed the protocol of making sure everything always has a deprecation period, especially because it's so easy to mark something deprecated

aloof-angle-91616

07/09/2020, 9:54 PM

yes! a reasonable question

fast-nail-55400

07/09/2020, 9:54 PM

cool, will deprecate it then

👖 1

aloof-angle-91616

07/09/2020, 9:54 PM

thanks!!

aloof-angle-91616

07/09/2020, 9:57 PM

it wouldn't be unreasonable to add something like a specific marker for an unstable option to avoid this ambiguity. pip did this recently with the

--unstable-feature

list enum option (for e.g.

--unstable-feature=resolver

, or

--unstable-feature=shallow_wheels

as in this PR i have open: https://github.com/pypa/pip/pull/8448).

hundreds-father-404

07/09/2020, 9:57 PM

We’re kind of breaking the deprecation policy with 2.0 in some places, but it’s preferred to deprecate so that people get a nice deprecation warning

👍 1

hundreds-father-404

07/09/2020, 9:57 PM

target removal for 2.1.0.dev0

☝️ 1

witty-crayon-22786

07/09/2020, 10:00 PM

@fast-nail-55400: so, a very fair middle ground here imo would be to deprecate the option and simultaneously make it a noop.

👍 2

witty-crayon-22786

07/09/2020, 10:00 PM

in general that’s frowned upon, but 1) this is 2.0, 2) you just added this feature and so it’s unlikely that anyone is actually using it

👍 2

aloof-angle-91616

07/09/2020, 10:00 PM

^yes, sorry not to elaborate. the point is just not to break existing users without a warning period.

fast-nail-55400

07/09/2020, 10:01 PM

that is what I’m doing, the

removal_hint

is is that it’s not applicable any more

👌 2

witty-crayon-22786

07/09/2020, 10:01 PM

great. thanks.

witty-crayon-22786

07/10/2020, 4:15 PM

The fact that it is tree centric is pretty nice. Not sure how well it would work for wide trees (or how wide our trees are in practice!) https://www.reddit.com/r/rust/comments/hojo5x/prodash_v70_now_sports_a_new_renderer_to/

happy-kitchen-89482

07/10/2020, 8:49 PM

Getting CI errors like this:

TypeError: Required argument ('execution_enable_streaming') (pos 15) not found

in code that creates a

PyRemotingOptions

. Looks like execution_enable_streaming was removed in #10306 just now, but CI still expects it for some reason. Is that some known race condition in CI? Or do I need to invalidate native code manually somehow?

witty-crayon-22786

07/10/2020, 8:50 PM

you raced Tom’s change

witty-crayon-22786

07/10/2020, 8:50 PM

will need to rebase.

hundreds-breakfast-49010

07/10/2020, 10:04 PM

Looks like

src/python/pants/backend/python/lint/bandit/rules_integration_test.py

is broken on master

aloof-angle-91616

07/12/2020, 5:46 AM

spreading hype about the v2 ui: https://twitter.com/mycoliza/status/1282188089566224384?s=21

aloof-angle-91616

07/12/2020, 5:47 AM

was an interesting point earlier: https://twitter.com/mycoliza/status/1282186999269474304?s=21

hundreds-father-404

07/13/2020, 5:47 PM

I fleshed out the design for how to integrate generated subtargets with file arguments, dependency ignore syntax, and explicit file-level deps. Please take a look: https://docs.google.com/document/d/14MAst0Q0HpoLqysiN7KoKDkA6-Ga_KhjICTl0EC16uI/edit#heading=h.y495n7exlx1x

hundreds-breakfast-49010

07/13/2020, 7:48 PM

hm, did we break

src/python/pants/engine/fs_test.py

with the changes to pantsbuild.org?

hundreds-father-404

07/13/2020, 8:55 PM

Hm. I have no idea how with explicit deps in BUILD files we plan to distinguish between what is a target address vs. a generated subtarget. If there’s a

, then we know it’s a target address. Otherwise, we don’t know how to distinguish between the address shorthand of leaving off

:foo

when the parent directory is

foo/

. It’s not reliable to look for a file extension, because not all files have it and dirs can have them. We can’t call

Path.is_file()

because that’s not engine safe, afacit.

hundreds-father-404

07/14/2020, 1:31 AM

segfault in CI: https://travis-ci.com/github/pantsbuild/pants/jobs/360711817#L87

Copy code

thread '<unnamed>' panicked at 'overflow when subtracting durations', src/libcore/time.rs:753:9

hundreds-breakfast-49010

07/14/2020, 11:07 PM

just set https://github.com/pantsbuild/pants/pull/10278 to ready for review

hundreds-breakfast-49010

07/14/2020, 11:07 PM

I have an asciinema file showing whatthis looks like on my system, but I can't upload it to asciinema for some reason, so I'll attach it here

hundreds-breakfast-49010

07/14/2020, 11:07 PM

tmpi9lz57s3-ascii.cast

hundreds-breakfast-49010

07/14/2020, 11:08 PM

(play with

asciinema play <filename>

)

witty-crayon-22786

07/15/2020, 12:00 AM

nice 😃

witty-crayon-22786

07/15/2020, 12:04 AM

boat with a nit!

hundreds-breakfast-49010

07/15/2020, 1:08 AM

thanks for the shipit but let's do just a little bit of color bikeshedding first 🙂 https://github.com/pantsbuild/pants/pull/10278