pantsbuild #development

Channels

welcome

github-notifications

development

hundreds-father-404

05/15/2020, 12:30 AM

Raúl, what Stu is talking about is that this doesn’t impact the verbosity of the output, only the format. Normally, we show a dynamic UI that shows the current status of your build, but goes away once the build is complete. Meanwhile, the log level output stays around always and will control things like “do we render successful test output?” They’re two separate, but related, things.

witty-crayon-22786

05/15/2020, 12:30 AM

right, sortof…?

jolly-midnight-72759

05/15/2020, 12:30 AM

So there are two major audience, human and machine. Within human mode we want to be able to do have the V2 console or not. Are there more modes for humans?

witty-crayon-22786

05/15/2020, 12:31 AM

the UI is only visible during a run… it disappears after the run. logging sticks around.

jolly-midnight-72759

05/15/2020, 12:31 AM

It is HOW we are displaying the info.

hundreds-breakfast-49010

05/15/2020, 12:31 AM

no, it's just a question of whether we turn the dynamic UI on or off, and this is only relevant while pants is running

jolly-midnight-72759

05/15/2020, 12:31 AM

By dynamic do you mean a ncurses type UI?

hundreds-breakfast-49010

05/15/2020, 12:31 AM

yes, the thing that updates live only while pants is running, i.e. the swim lanes

jolly-midnight-72759

05/15/2020, 12:31 AM

cool!

jolly-midnight-72759

05/15/2020, 12:32 AM

When I hear "--console" I would think that.

hundreds-breakfast-49010

05/15/2020, 12:33 AM

@jolly-midnight-72759 check out the links in this PR if you haven't seen it yet: https://github.com/pantsbuild/pants/pull/9672

👀 1

hundreds-father-404

05/15/2020, 12:33 AM

Another demo is from the slides last night, we included a gif of this dynamic UI: https://docs.google.com/presentation/d/1gxsdCcrA96TghoEz_50hMW1p-_6VUnCEE69vjImRhaw/edit#slide=id.g77f26f2f8f_0_12

hundreds-breakfast-49010

05/15/2020, 12:33 AM

e.g. https://asciinema.org/a/329317

👍 1

jolly-midnight-72759

05/15/2020, 12:34 AM

I remember that from last night. 🙂

hundreds-breakfast-49010

05/15/2020, 12:34 AM

so, we want to give a name to that specific dynamically-updating curses UI in the terminal, distinct from other output that pants might produce, and we want to be able to toggle it on/off

hundreds-breakfast-49010

05/15/2020, 12:34 AM

for human users

hundreds-breakfast-49010

05/15/2020, 12:34 AM

for machine users we pretty much never want it

👍 1

witty-crayon-22786

05/15/2020, 12:34 AM

and logs of workunits will render “above” the UI, and stay on the screen after the run has completed

witty-crayon-22786

05/15/2020, 12:36 AM

so if you disable the whirly bits, you still see logs at whatever level.

witty-crayon-22786

05/15/2020, 12:37 AM

(more logs than we currently render, but not a lot more, ideally.)

jolly-midnight-72759

05/15/2020, 12:37 AM

"fancy", "console", "curses-ui", "cool", "hip"

hundreds-breakfast-49010

05/15/2020, 12:38 AM

I'm leaning towards

--(no)-dynamic-ui

personally

hundreds-breakfast-49010

05/15/2020, 12:38 AM

I think "dynamic" captures what's distinct about the thing we toggle on/off

jolly-midnight-72759

05/15/2020, 12:39 AM

dynamic works, now that I know. You all have spoiled my newbie POV with all this learning.

❤️ 1

jolly-midnight-72759

05/15/2020, 12:39 AM

dynamite mode!

👖 1

hundreds-breakfast-49010

05/15/2020, 12:39 AM

we can add back some gaudy dynamite emoji 🙂

jolly-midnight-72759

05/15/2020, 12:39 AM

I think dynamic captures the feel and is memorable.

jolly-midnight-72759

05/15/2020, 12:40 AM

But would you do

--ui=dynamic

--(no-)dynamic-ui

witty-crayon-22786

05/15/2020, 12:40 AM

fine with that

witty-crayon-22786

05/15/2020, 12:41 AM