https://pantsbuild.org/ logo
Powered by
#development
  • a

    aloof-angle-91616

    05/11/2020, 11:52 PM
    and like
  • a

    aloof-angle-91616

    05/11/2020, 11:52 PM
    materializing this to disk
  • a

    aloof-angle-91616

    05/11/2020, 11:52 PM
    without doing a subset
  • a

    aloof-angle-91616

    05/11/2020, 11:52 PM
    takes like 30 seconds
  • a

    aloof-angle-91616

    05/11/2020, 11:53 PM
    like into the 
    dist/
    dir which is what i have a 
    @goal_rule
    doing now
  • h

    hundreds-breakfast-49010

    05/13/2020, 11:14 PM
    I've taken to calling the v2 UI the "console UI", since I think that we don't really want to connect it with the concept of "v2" going forward
  • h

    hundreds-breakfast-49010

    05/13/2020, 11:14 PM
    like, once v2 is stable, we want to just call it the "console UI" or "live-updating UI"
  • h

    hundreds-breakfast-49010

    05/13/2020, 11:14 PM
    and not mention "v2"
  • h

    hundreds-father-404

    05/13/2020, 11:14 PM
    What about “interactive UI”. Strong +1 to not calling it V2 UI
  • h

    hundreds-breakfast-49010

    05/13/2020, 11:14 PM
    that works too, really just not calling it "v2"
  • h

    hundreds-father-404

    05/13/2020, 11:15 PM
    In fact, we should change the global option imo (with a deprecation cycle)
    👍 1
  • h

    hundreds-breakfast-49010

    05/13/2020, 11:15 PM
    anyway I kinda want to rename the option
  • h

    hundreds-breakfast-49010

    05/13/2020, 11:15 PM
    and now is as good a time to bring that up as any
  • h

    hundreds-father-404

    05/13/2020, 11:15 PM
    Agreed. Now is a great time to do it. While writing docs, “interactive UI” is what has sounded the most natural
  • h

    hundreds-breakfast-49010

    05/13/2020, 11:15 PM
    works for me
  • w

    witty-crayon-22786

    05/13/2020, 11:15 PM
    should also consider making another push to enable it by default.
  • h

    hundreds-breakfast-49010

    05/13/2020, 11:16 PM
    although, I guess it's not currently too interactive, in the sense of responding to user input
  • a

    aloof-angle-91616

    05/13/2020, 11:16 PM
    we always have pants.base.deprecated so i wouldn’t consider renaming an option to ever have a “bad time”
    h
    • 2
    • 6
  • h

    hundreds-father-404

    05/13/2020, 11:17 PM
    should also consider making another push to enable it by default.
    what is the story with using the interactive UI at the same time as V1? That’s the biggest issue afaict. We default to 
    --v1 --v2
    h
    w
    • 3
    • 3
  • a

    aloof-angle-91616

    05/14/2020, 5:42 PM
  • a

    aloof-angle-91616

    05/14/2020, 5:43 PM
    from the PR that adds an output mode with target fingerprints to v2 list:
    Noting that the buck build tool supports a “show target hash” option for a while, which has allowed hooking it up to a system containing bazel (https://eng.uber.com/go-monorepo-bazel/). It would have been really great to have had less pushback on this PR initially when there was a clearly present user need.
  • w

    witty-crayon-22786

    05/14/2020, 5:46 PM
    worth reading the github issue they link to to understand some of the complexities: https://github.com/bazelbuild/bazel/issues/7962
  • w

    witty-crayon-22786

    05/14/2020, 5:47 PM
    of note, it’s not file fingerprints: it’s “action graph fingerprints”, which is goal dependent.
  • w

    witty-crayon-22786

    05/14/2020, 5:47 PM
    we should take this back to the existing thread if you’re interested in discussing it
  • a

    aloof-angle-91616

    05/14/2020, 5:48 PM
    which is why i think we should have an existing prototype to surface the issues that arise in pants instead of as usual blocking on some very specific idea
  • w

    witty-crayon-22786

    05/14/2020, 6:57 PM
    not going into raw mode for the UI is sooo much better: woot.
    ❤️ 1
  • w

    witty-crayon-22786

    05/14/2020, 6:58 PM
    running away infinitely when you tried to scroll up the terminal was one of a few annoyances eliminated there.
    ❤️ 1
  • h

    hundreds-breakfast-49010

    05/15/2020, 12:10 AM
    I hate to bikeshed over something small like this but I also feel like 
    --interactive-ui
    isn't quite the right thing to rename --v2-ui to because interactivity involves a relationship with the user wherein it responds to user input and that's not what this UI does @witty-crayon-22786 @hundreds-father-404
  • h

    hundreds-breakfast-49010

    05/15/2020, 12:10 AM
    --dyanmic-ui
    ?
  • h

    hundreds-father-404

    05/15/2020, 12:10 AM
    Oh, that is a good point!
1...733734735...906Latest