pantsbuild #development

Probably for my first pass with these bindings, aim for 100% parity because the plan is to replace TargetAdaptor with the Target API, meaning everything will be validated by the Target API bindings. Then, in followup PRs, deprecate any fields that are unused or shouldn’t exist?

average-vr-56795

03/24/2020, 1:31 PM

This issue may sound familiar to folks! https://github.com/pypa/packaging/issues/104 I guess we pulled in the fix at some point…

witty-crayon-22786

03/24/2020, 4:20 PM

pantsd and performance!: re https://github.com/pantsbuild/pants/pull/9318

witty-crayon-22786

03/24/2020, 4:41 PM

Copy code

Computing MultiPlatformExecuteProcess(MultiPlatformExecuteProcessRequest({(None, None): ExecuteProcessRequest { argv: ["python", "./test_runner.pex", "pants_test/backend/jvm/tasks/test_scala_repl_integration.py"], <snip> }})
    Throw(Failed to execute process: Unavailable: "Transient error, please retry with backoff")
      Traceback (no traceback):
        <pants native internals>
      Exception: Failed to execute process: Unavailable: "Transient error, please retry with backoff"

hundreds-father-404

03/25/2020, 4:00 AM

Do we want to elevate a mechanism for required fields? Concrete example:

alias()

must have the field

target

defined. We could achieve this ad hoc, but do we anticipate this being a useful mechanism? For example, if we elevate it, then we can do nice things like say

required

in the output of

./v2 target-types

aloof-angle-91616

03/25/2020, 4:01 AM

would we want to then express

name

as a special case of that?

hundreds-father-404

03/25/2020, 4:16 AM

Cool, it was really easy to add this mechanism. 10 lines of code 😄

🔥 1

aloof-angle-91616

03/25/2020, 4:16 AM

by 3pm today i'd accomplished all my non-reach goals for hackweek so i'm shooting for gold at this point

💯 2

🎉 1

👖 1

aloof-angle-91616

03/26/2020, 6:02 AM

hackweek update https://pantsbuild.slack.com/archives/C0D7TNJHL/p1585196778028400?thread_ts=1585109803.010200&cid=C0D7TNJHL

aloof-angle-91616

03/26/2020, 6:02 AM

gonna put up a PR with them all together, this builds on 4 separate orthogonal PRs lol

hundreds-breakfast-49010

03/26/2020, 11:52 PM

does anyone know what the

Fingerprint

-related functionality in pantsd code is meant to do at a high level?

hundreds-breakfast-49010

03/27/2020, 1:47 AM

does anyone routinely run pantsd on a non-local host?

enough-analyst-54434

03/27/2020, 1:58 AM

This is likely a horrible forum for discussing a nitty gritty thing, but at broad brush, I've found out via bazel-buildfarm that our client (Pants) will send duplicate blob upload requests concurrently. Which is perfectly fine, but bazel dedups and so we found out about a bug in bazel-buildfarm handling concurrent requests that bazel as a client did not expose: https://github.com/bazelbuild/bazel-buildfarm/issues/339 The bazel-buildfarm people have already offered a patch that fixes things, but I was wondering if this is interesting or known. Posted in #remoting

hundreds-breakfast-49010

03/27/2020, 7:40 PM

does anyone know if there's a single rust method that does the equivalent of python

time.time()

hundreds-breakfast-49010

03/27/2020, 7:41 PM

it seems like the std lib rust APIs for this involve getting hte currrent

SystemTime

and then comparing it to the unix epoch to get a

Duration

, which works but seems a bit verbose

witty-crayon-22786

03/27/2020, 7:49 PM

Duration is the right API to get a duration

witty-crayon-22786

03/27/2020, 7:49 PM

@hundreds-breakfast-49010: but it's "Instant - Instant = Duration", not SystemTime, afaik.

fast-nail-55400

03/27/2020, 8:04 PM

you can use

Instant::now()

and then call

.elapsed()

on it: https://doc.rust-lang.org/std/time/struct.Instant.html

hundreds-father-404

03/28/2020, 5:14 AM

I’m frequently but not always getting a

scheduler.ExecutionError

when calling

./v2 --changed-since=master fmt

that only includes the very long

Computing Select

clause and then

<None>

Has anyone else seen this? I started noticing it yesterday.

aloof-angle-91616

03/28/2020, 5:53 AM

https://chapel-lang.org/papers/BriefOverviewChapel.pdf

aloof-angle-91616

03/28/2020, 5:53 AM

an overview of the chapel parallel programming language from cray

aloof-angle-91616

03/28/2020, 5:59 AM

Note that because of Chapel’s global namespace and global-view arrays, a change to a domain declaration like thisis the only thing required to convert a shared-memory parallel program into one that supports distributed-memoryexecution. Forall-loops over distributed domains/arrays are typically implemented such that each locale iterates overthe indices/elements that it owns locally, providing a natural model for locality.

hundreds-father-404

03/28/2020, 6:02 AM

ohh I think we now end up running

./v2 fmt

multiple times when files are changed?

hundreds-breakfast-49010

03/30/2020, 7:40 PM

would anything bad happen if I completely removed this

clean_global_runtime_state

function? https://github.com/pantsbuild/pants/blob/master/src/python/pants/bin/daemon_pants_runner.py#L251

hundreds-breakfast-49010

03/30/2020, 7:41 PM

the comment on it says it pertains to pantsd forking, so maybe its obsolete?

aloof-angle-91616

03/30/2020, 7:42 PM

i would try it and see, i have no clue from just looking at that code

aloof-angle-91616

03/30/2020, 7:42 PM

i don't know where that state is recreated, if this method is currently getting called now

hundreds-breakfast-49010

03/30/2020, 7:53 PM

it looks like it's doing three things -

Goal.clean()

BuildConfigInitializer.reset

and

Subsystem.reset()