https://pantsbuild.org/ logo
Powered by
#development
  • h

    hundreds-breakfast-49010

    03/18/2020, 11:56 PM
    and then we call 
    client.execute
    with whatever pants command the user entered at the command line
  • h

    hundreds-breakfast-49010

    03/18/2020, 11:57 PM
    and that 
    execute
    is part of the nailgun protocol defined in a bunch of python files in 
    pants/java
  • h

    hundreds-breakfast-49010

    03/18/2020, 11:57 PM
    I assume 
    NailgunExecutor
    is the other, server side of this?
  • a

    aloof-angle-91616

    03/18/2020, 11:58 PM
    NailgunExecutor is relevant for v1 jvm tasks
  • a

    aloof-angle-91616

    03/18/2020, 11:58 PM
    the server side stuff is all in 
    pantsd/
  • a

    aloof-angle-91616

    03/18/2020, 11:59 PM
    NailgunExecutor uses a nailgun to satisfy the jvm tool executor interface along with SubprocessExecutor
  • a

    aloof-angle-91616

    03/18/2020, 11:59 PM
    that’s used by NailgunTasks when they run 
    <http://self.ru|self.ru>ntool()
  • h

    hundreds-breakfast-49010

    03/19/2020, 12:00 AM
    so what code in 
    pantsd/
    gets executed when the pantsd process gets a message sent to it by 
    client.execute
    ?
  • a

    aloof-angle-91616

    03/19/2020, 12:00 AM
    i think it’s in pailgun_service.py. let me check
  • a

    aloof-angle-91616

    03/19/2020, 12:02 AM
    oops. it’s pants_daemon.py
  • h

    hundreds-breakfast-49010

    03/19/2020, 12:02 AM
    what method?
  • a

    aloof-angle-91616

    03/19/2020, 12:03 AM
    looking that up atm still
  • a

    aloof-angle-91616

    03/19/2020, 12:06 AM
    PailgunHandler
    in 
    pailgun_server.py
    looks promising
  • h

    hundreds-breakfast-49010

    03/19/2020, 12:07 AM
    handle_request
    ?
  • a

    aloof-angle-91616

    03/19/2020, 12:08 AM
    i'm referring to 
    class PailgunHandler(PailgunHandlerBase):
  • h

    hundreds-breakfast-49010

    03/19/2020, 12:08 AM
    ah ok
  • h

    hundreds-breakfast-49010

    03/19/2020, 12:08 AM
    hm is there a reason there's a base class here? it looks awful short and is only used in this one place
  • h

    hundreds-breakfast-49010

    03/19/2020, 12:09 AM
    ah and this has a 
    _run_pants
    method
  • a

    aloof-angle-91616

    03/19/2020, 12:09 AM
    there are like 50 classes involved in this entire exchange. it might just have been an attempt to organize things
  • h

    hundreds-breakfast-49010

    03/19/2020, 12:10 AM
    so 
    DaemonPantsRunner
    looks like it's probably the code that actually runs pants commands in a pantsd context
  • a

    aloof-angle-91616

    03/19/2020, 12:10 AM
    yes!
  • h

    hundreds-breakfast-49010

    03/19/2020, 12:11 AM
    and this is doing some tty manipulation
  • h

    hundreds-breakfast-49010

    03/19/2020, 12:11 AM
    so maybe this is where the stuff that conflicts with the rust console code is happening
  • a

    aloof-angle-91616

    03/19/2020, 12:11 AM
    i think it would have to be
  • h

    hundreds-breakfast-49010

    03/19/2020, 12:12 AM
    so as for a high level architectural perspective, I think it makes sense that the client should control the tty, and the server should not try to do anything with the tty
    👍 2
  • h

    hundreds-breakfast-49010

    03/19/2020, 12:13 AM
    but it seems like that's not how pantsd was written, and I don't know how hard it would be to rewrite a bunch of code around the client-server relationship to make that possible
  • a

    aloof-angle-91616

    03/19/2020, 12:14 AM
    there's a lot of code surrounding the client-server relationship
  • h

    hundreds-breakfast-49010

    03/19/2020, 12:14 AM
    ah okay so 
    DaemonPantsRunner
    has a 
    run
    method and this is creating a 
    LocalPantsRunner
    👍 1
  • a

    aloof-angle-91616

    03/19/2020, 12:14 AM
    i think as long as we preserve the basic idea of "call 
    LocalPantsRunner
    , but over a nailgun" we should feel free to cut out a lot
  • a

    aloof-angle-91616

    03/19/2020, 12:16 AM
    if you write the rust console program that seems to make sense in terms of the client/server relationship, but it requires changes to the way pantsd currently works, i would make an issue or PR saying "i would prefer that pantsd work this way and here's what the rust client would do" and i think people would be open to it
1...704705706...906Latest