Ergonomic, hermetic, user-friendly software build system for Python, Go, Java, Kotlin, Protobuf, Scala, Shell. Pants lets you fearlessly scale up your codebase!

Pants

but yes, the exceptions of the SCM would need to be

scm only has three inner exceptions. so i think it's a much easier problem

ah, this is the one that's not pickable
```E       SerializationError: Failed to pickle Throw(exc=GitDiedException(u"Git cat-file died while trying to read 'HEAD:\n'.",)): Can't pickle &lt;class 'pants.scm.git.GitDiedException'&gt;: attribute lookup pants.scm.git.GitDiedException failed
```

ah. yea, i don't think that's worth changing at the moment.

before that was the Git._log that causes some error again only in fast mode, but that was easy to fix

<@U098ZNTCN>: doesn't need to be an inner reference... can just be in the module

so good moving git exceptions to the top level?

and scm exceptions? not seeing them now, forgot when i started to see them, will keep a log from now

<@U098ZNTCN>: er... git doesn't have its own exceptions.

right, pants.scm.git.GitDiedException actually belongs to the reader

`GitRepositoryReader` exceptions need to be at the top level...

"yea, i don't think that's worth changing at the moment."

we don't need to pickle exceptions except in error cases, and it's unclear whether we'll cache exceptions in the future

or you mean if i skip the test? these exceptions won't happen?

or whether we'll turn exceptions into strings before passing them (since they don't contain stack information anyway)

<@U098ZNTCN>: i mean it is failing for some other reason (a legit bug probably), and _then_ it is failing to pickle the excepiton

turns out the only thing makes reader unpicklable is its logger, so after the logger moving out to module, we don't even need the memo

that doesn't sound right, but i'll believe it when i see it