https://pantsbuild.org/ logo
Powered by
#development
  • h

    hundreds-father-404

    01/30/2020, 12:03 AM
    It looks like we don’t support adding and subtracting globs anymore?
    Copy code
    python_library(
  name = 'strutil',
  sources = rglobs('strutil.py') + rglobs('strutil.py'),
  tags = {'type_checked'},
)
    Copy code
    ▶ ./pants --no-print-exception-stacktrace filedeps --no-transitive src/python/pants/util:strutil

ERROR: Build graph construction failed: ExecutionError 1 Exception encountered:
  MappingError: Failed to parse src/python/pants/util/BUILD:
TypeError("unsupported operand type(s) for +: 'RGlobs' and 'RGlobs'",)
  • w

    witty-crayon-22786

    01/30/2020, 12:11 AM
    yea, not for a long time
  • h

    hundreds-father-404

    01/30/2020, 12:12 AM
    Fantastic. That saves a lot of work for the 
    fix_deprecated_glob_usages.py
    script
  • w

    witty-crayon-22786

    01/30/2020, 12:16 AM
    ... that reminds me though. there is a now fairly rare (looks like 6 occurences in our repo?) pattern of having a variable representing a manually included list of sources, which you use to 1) add to one target, 2) remove from another
    h
    • 2
    • 2
  • w

    witty-crayon-22786

    01/30/2020, 12:17 AM
    (if this grep isn't broken: 
    b -A3 'glob' | grep -B3 'exclude = [A-Za-z]'
    )
    f
    • 2
    • 2
  • w

    witty-crayon-22786

    01/30/2020, 12:17 AM
    Copy code
    ./BUILD:    sources = globs(
./BUILD-        ALL_FILES,
./BUILD-        exclude = SCHEMA_EXCLUDES,
  • w

    witty-crayon-22786

    01/30/2020, 12:18 AM
    where each of those are constant file lists
  • w

    witty-crayon-22786

    01/30/2020, 12:18 AM
    but... i think that we can internally add a tiny helper function for that case.
  • h

    hundreds-father-404

    01/30/2020, 12:20 AM
    Hm, for that, I think we rely on manual fixes by the Pants admin, which they’ll know to do through the deprecation warning. It would be pretty complex to tweak the script to handle that edge case. I think it’s okay for the script to automatically fix 80%, warn on 15% with a generated suggested fix, and do nothing on 5%
  • w

    witty-crayon-22786

    01/30/2020, 12:20 AM
    yep.
  • w

    witty-crayon-22786

    01/30/2020, 12:20 AM
    oh totally: sorry: was not suggesting tackling it in the script. just having an answer
    👍 1
  • w

    witty-crayon-22786

    01/30/2020, 12:20 AM
    the tiny helper might look like:
    Copy code
    python_library(
  sources = MY_SOURCES,
)

python_library(
  sources = ['*.py'] + exclude_globs(MY_SOURCES),
)
    👍 1
  • w

    witty-crayon-22786

    01/30/2020, 12:21 AM
    where exclude globs would prefix with 
    !
    =P
    👍 1
  • w

    witty-crayon-22786

    01/30/2020, 12:21 AM
    or 
    invert(..)
    or something.
  • w

    witty-crayon-22786

    01/30/2020, 12:21 AM
    invert_globs
    , maybe.
  • w

    witty-crayon-22786

    01/30/2020, 12:21 AM
    anyway.
  • a

    aloof-angle-91616

    01/30/2020, 3:27 PM
    UI inspiration from an extremely interesting scala build tool https://twitter.com/propensive/status/1222855903692697601?s=21
    w
    h
    • 3
    • 15
  • h

    hundreds-father-404

    01/30/2020, 5:43 PM
    https://blog.rust-lang.org/2020/01/30/Rust-1.41.0.html. Run 
    cargo lock translate
    to use the new lockfile format optimized for smaller diffs upon changes
    🎉 3
  • h

    hundreds-breakfast-49010

    01/31/2020, 2:00 AM
    I have a draft PR for detecting if the user hit Ctrl-C in --v2-ui mode: https://github.com/pantsbuild/pants/pull/9043 . I'm not sure what the best way to actually exit pants is once we've detected that the keystroke happened
    a
    r
    • 3
    • 31
  • h

    hundreds-father-404

    01/31/2020, 2:15 AM
    Any ideas if it’s possible to synchronously request a subsystem registered with 
    subsystem_rule
    ? These both failed
    Copy code
    changed_subsystem, = session.product_request(Changed, [Options, options])  # Options is not a RootRule
    Copy code
    changed_subsystem, = session.product_request(Changed, [])  # Must give a subject
    a
    w
    • 3
    • 45
  • h

    happy-kitchen-89482

    02/03/2020, 7:58 PM
    Would it be correct to not rebuild the engine in CI if no rust code has changed?
    a
    a
    • 3
    • 5
  • h

    happy-kitchen-89482

    02/03/2020, 7:58 PM
    Seems like a lot of wasted CI cycles on non-rust changes (which are still the vast majority)
  • h

    happy-kitchen-89482

    02/03/2020, 7:59 PM
    Ideally this would just be pants caching at work, but until pants supports rust builds there are other ways
    a
    • 2
    • 1
  • h

    hundreds-father-404

    02/03/2020, 7:59 PM
    The artifact we care about is 
    native_engine.so
    . That file only needs to be cached somehow
  • h

    happy-kitchen-89482

    02/03/2020, 7:59 PM
    I mean maybe we bite the bullet and add rust-building rules in Pants? 🙂
    🎉 1
  • h

    hundreds-father-404

    02/03/2020, 8:00 PM
    That would be a chicken-and-the-egg problem, though, I think
    h
    a
    • 3
    • 4
  • a

    aloof-angle-91616

    02/03/2020, 8:00 PM
    https://github.com/cosmicexplorer/learning-progress-bar/tree/master/pants-plugins/upstreamable the above (along with a few changes to pants itself) has v2 cargo rules that allow cargo projects to be used with or without pants
  • a

    aloof-angle-91616

    02/03/2020, 8:01 PM
    i haven't described the changes to others a lot but i would love to hash out a timeline
  • a

    aloof-angle-91616

    02/03/2020, 8:01 PM
    i specifically really want to build pants with itself and am willing to spend extra time to make that happen
    👍 3
  • a

    aloof-angle-91616

    02/03/2020, 10:09 PM
    brian martin (maintainer of rezolus, at twitter, cares a lot about tooling) who is defining twitter's relationship to rust right now was super pumped about seeing this discussion^
    🙂 1
1...689690691...906Latest