pantsbuild #development

just noticed that right now, the --v2-ui flag breaks run (and probably any other goal that uses interactive process request): https://github.com/pantsbuild/pants/issues/8814

👍 1

hundreds-breakfast-49010

12/13/2019, 11:39 PM

wrote up what ended being a kinda-lengthy comment on https://github.com/pantsbuild/pants/issues/7509#issuecomment-565650068 , curious for your input @witty-crayon-22786 @aloof-angle-91616 @happy-kitchen-89482

gentle-wolf-58752

12/16/2019, 7:42 PM

👋 hey all - working on adding to an existing console rule (

test

- adding an option to run within an interactive session) and am running into couple hiccups. Notably: • How to best mock out options being passed to a rule (using the

run_rule

test util, I didn’t catch anything in / after Erics change in https://github.com/pantsbuild/pants/pull/8742 that served as an example) • How to best constrain the rule to a single BFA when the option is provided (following https://github.com/pantsbuild/pants/pull/8586 it seems I could do this via specs, wasn’t sure if there was something more elegant)

dry-analyst-73584

12/16/2019, 10:06 PM

How do I declare a dependency and make pants happy again?

dry-analyst-73584

12/16/2019, 10:07 PM

This one is particularly confusing as this works:

Copy code

source_root_stripped_sources = await MultiGet(
    Get(SourceRootStrippedSources, HydratedTarget, target_adaptor)
    for target_adaptor in all_targets
  )

But this:

Copy code

source_root_stripped_source = await Get(SourceRootStrippedSources, HydratedTarget, test_target)

results in the above error when added to the same file.

witty-crayon-22786

12/16/2019, 10:28 PM

@dry-analyst-73584: that error generally indicates that the declared type of the 3rd argument (from the 2nd argument) doesn't match its type

witty-crayon-22786

12/16/2019, 10:29 PM

ie,

test_target

is not a

HydratedTarget

dry-analyst-73584

12/16/2019, 10:30 PM

Ah. Thank you 🙂 That is... not a very clear exception message.

happy-kitchen-89482

12/17/2019, 11:03 PM

I'm writing a test for a rule that eventually depends on TransitiveHydratedTargets, and it provides BuildFileAddresses for that purpose. It looks like those BuildFileAddresses have to correspond to actual underlying BUILD files on the filesystem? Otherwise during the transitive hydration I get: ``````

happy-kitchen-89482

12/17/2019, 11:03 PM

Copy code

E           Computing Task(create_pex_from_target_closure(), (<pants.backend.python.subsystems.python_native_code.PythonNativeCode object at 0x1063a2e10>+<pants.backend.python.subsystems.python_setup.PythonSetup object at 0x1063a2da0>+<pants.backend.python.subsystems.subprocess_environment.SubprocessEnvironment object at 0x1063a2eb8>+<pants.source.source_root.SourceRootConfig object at 0x1083254a8>+CreatePexFromTargetClosure(addresses=<pants.engine.addressable.Addresses object at 0x108325588>, output_filename='hello_world.pex', entry_point=None)), Pex, true)
                     E             Computing Task(transitive_hydrated_targets(), <pants.engine.addressable.Addresses object at 0x108325588>, TransitiveHydratedTargets, true)
                     E               Computing Task(transitive_hydrated_target(), foo/bar/hello_world:hello_world, TransitiveHydratedTarget, true)
                     E                 Computing Task(hydrate_target(), foo/bar/hello_world:hello_world, HydratedTarget, true)
                     E                   Computing Task(hydrate_struct(), foo/bar/hello_world:hello_world, HydratedStruct, true)
                     E                     Computing Task(parse_address_family(), Dir(path='foo/bar/hello_world'), AddressFamily, true)
                     E                       Throw(Directory "foo/bar/hello_world" does not contain any BUILD files.)
                     E                         Traceback (most recent call last):
                     E                           File "/Users/benjyw/src/pants/.pants.d/pyprep/sources/332bd781b5094207bbfda46605ed39fed8d66b78/pants/engine/native.py", line 485, in extern_generator_send
                     E                             res = c.from_value(func[0]).send(c.from_value(arg[0]))
                     E                           File "/Users/benjyw/src/pants/.pants.d/pyprep/sources/332bd781b5094207bbfda46605ed39fed8d66b78/pants/engine/build_files.py", line 53, in parse_address_family
                     E                             'Directory "{}" does not contain any BUILD files.'.format(directory.path)
                     E                         pants.engine.mapper.ResolveError: Directory "foo/bar/hello_world" does not contain any BUILD files.

hundreds-breakfast-49010

12/18/2019, 1:09 AM

I have a draft PR of a commit set that adds about the most basic possible notion of a HTTP intrinsic to the engine: https://github.com/pantsbuild/pants/pull/8834 , curious for people's thoughts on this

happy-kitchen-89482

12/18/2019, 5:49 AM

A "v2 backend" for creating AWS Lambdas: https://github.com/pantsbuild/pants/pull/8835

happy-kitchen-89482

12/18/2019, 5:49 AM

Notable mostly for being the first v2-only backend under the new location of

src/python/pants/backend2

. Feel free to bikeshed that location; See https://docs.google.com/document/d/1E6a7nKq5Lf1G-VRS987ZT77KYkR5DT8JNxb9x4I4xEA/edit?usp=sharing for context.

happy-kitchen-89482

12/18/2019, 5:12 PM

Went with a different approach for v1/v2 plugin registration in https://github.com/pantsbuild/pants/pull/8817 (cc @witty-crayon-22786) which allows a more incremental transition.

witty-crayon-22786

12/19/2019, 8:32 AM

https://tokio.rs/blog/2019-12-compat/

🎉 3

🦀 3

hundreds-breakfast-49010

12/19/2019, 11:16 PM

do we have any good way to push a dict or dict-like object across the FFI boundary, other than encoding it as a tuple of pairs?

happy-kitchen-89482

12/20/2019, 6:08 AM

Is there a particular reason that

python_library

is mapped to

PythonTargetAdaptor

, which is the base class of

PythonBinaryAdaptor

and

PythonTestsAdaptor

, instead of to a

PythonLibraryAdaptor

subclass of it?

happy-kitchen-89482

12/20/2019, 6:08 AM

Would it break anything if I added such a subclass?

happy-kitchen-89482

12/20/2019, 6:09 AM

I suspect that due to how the engine matches types it doesn't super matter in practice, but it would be clearer to the reader.

witty-crayon-22786

12/20/2019, 6:27 AM

likely useful for our process intrinsic https://crates.io/crates/gaol

average-vr-56795

12/20/2019, 10:43 AM

@happy-kitchen-89482 I think that would be fine, we just didn’t have a need for any customisations for the library-specific target when we made that inheritance hierarchy

hundreds-breakfast-49010

12/20/2019, 7:21 PM

does anyone know what would happen if a

@rule

rather than a

@console_rule

returned a

Goal

subclass? would that be detected as a top-level goal?

hundreds-breakfast-49010

12/20/2019, 10:33 PM

https://github.com/pantsbuild/pants/pull/8855 @gentle-wolf-58752 this will be helpful I think for the work you're doing with interactively-debuggable tests

👀 1

happy-kitchen-89482

12/23/2019, 9:20 PM

Hi all, the

no space left on device

issue is becoming acute. Has anyone made any headway into diagnosing it? E.g., do we think it's related to lmdb?