https://pantsbuild.org/ logo
Powered by
#development
  • h

    hundreds-breakfast-49010

    12/09/2019, 7:50 PM
    am I imagining things, or did it used to be the case that 
    LineOriented
    provided both a 
    print_stdout
    and 
    print_stderr
    function, but now the stderr variant is gone?
  • h

    hundreds-father-404

    12/09/2019, 8:32 PM
    Yes, that changed a month ago I think. Not sure why but you can git blame for the PR
  • h

    hundreds-breakfast-49010

    12/09/2019, 9:25 PM
    looks like d40f13fadbfa7ddb10b421b0da5dbcd576d441f3 is the commit
  • h

    hundreds-breakfast-49010

    12/10/2019, 1:51 AM
    hm, once the 
    Console
    type is fully compatible with --v2-ui, we're going to have to consider it an abstraction violation to use 
    print
    in any 
    @rule
    👍 1
    ➕ 1
    w
    • 2
    • 1
  • h

    hundreds-breakfast-49010

    12/10/2019, 1:51 AM
    and possibly other places in the code as well that I'm not thinking of
  • h

    hundreds-breakfast-49010

    12/10/2019, 1:54 AM
    although some quick grepping suggests that there might not be a huge amount of places we're calling 
    print
    in v2-related python code
  • h

    hundreds-father-404

    12/10/2019, 2:46 AM
    Only console rules can request the Console, right?
  • h

    hundreds-breakfast-49010

    12/10/2019, 3:16 AM
    right, which would imply that any other printing we want ot do from a rule is a log and should go through the log abstraction
    h
    • 2
    • 5
  • h

    hundreds-breakfast-49010

    12/10/2019, 3:19 AM
    I'm also wondering how exactly messages printed from a console rule should interleave with the current streaming messages that are being printed with the lightning bolts - I think this are intended to all come from logs, right? @red-balloon-89377 @average-vr-56795?
    r
    w
    • 3
    • 16
  • h

    hundreds-breakfast-49010

    12/10/2019, 10:05 PM
    another console-related question - is there any principled reason why the number of swim lanes displayed should be the number of CPUs on the system?
  • w

    witty-crayon-22786

    12/10/2019, 10:38 PM
    @hundreds-breakfast-49010: most likely the more relevant value is some combination of: https://github.com/pantsbuild/pants/blob/16332c48ef92bd5cd3e0aaf7d93ff27a39bc022c/src/rust/engine/src/context.rs#L77-L78
  • w

    witty-crayon-22786

    12/10/2019, 10:39 PM
    the idea is roughly to display what processes are running, while acknowledging that a bunch of 
    @rules
    might occupy time between processes, and to render them when processes aren't executing
  • w

    witty-crayon-22786

    12/10/2019, 10:42 PM
    but exactly how many slots to render (and whether it should be dynamic) is an open question
  • h

    hundreds-breakfast-49010

    12/11/2019, 12:40 AM
    how are we currently using 
    MultiPlatformExecuteProcessRequest
    and the `Platform`/`PlatformConstraint` types?
    h
    e
    w
    • 4
    • 23
  • r

    red-balloon-89377

    12/11/2019, 4:48 PM
    Hello! I’m constantly running into this issue for the last couple of days, if anyone has any insight: When I run 
    ./pants test tests/python/pants_test/backend/project_info/tasks:test_export_dep_as_jar
    which has 10-15 unit tests, at some point I start getting 
    Exception: Could not initialize store for process cache: "Error making env for store at \"/private/var/folders/rm/zwytnntn5013gslf3xlv31rc0000gp/T/tmp6y9cz45d/processes/7\": No space left on device
    in all the tests, which can only be solve by restarting. Until now, when I just restarted but the problem persisted. Things that I’ve checked: • I have plenty of memory left, and I’m not swapping. • The volume has enough space and inodes left. • There are no deleted files held by processes. Any ideas?
    😢 1
    h
    w
    +3
    • 6
    • 61
  • w

    witty-crayon-22786

    12/11/2019, 8:18 PM
    @hundreds-father-404: there is no "nesting" of unions (unless i missed something big)... but a type might be a member of multiple unions
  • w

    witty-crayon-22786

    12/11/2019, 8:20 PM
    was planning on syncing on 4535 with Benjy in a few minutes. have added you to the invite, but will record otherwise.
    👍 1
    h
    • 2
    • 1
  • w

    witty-crayon-22786

    12/11/2019, 8:20 PM
    ..oh, i see.
  • h

    hundreds-breakfast-49010

    12/11/2019, 10:48 PM
    does anyone know where the specific log format 
    22:28:54 [INFO] computed 1 nodes in 3.122364 seconds. there are 20961 total nodes.
    is configured?
  • h

    hundreds-breakfast-49010

    12/11/2019, 10:48 PM
    (for python logs - rust logs are doing something different and I'm trying to make them work the same way python logs work)
  • a

    aloof-angle-91616

    12/11/2019, 10:49 PM
    src/python/pants/engine/scheduler.py
    , line 427
    h
    • 2
    • 8
  • w

    witty-crayon-22786

    12/11/2019, 10:51 PM
    the logging module, on the rust side, iirc
  • h

    hundreds-breakfast-49010

    12/12/2019, 1:58 AM
    https://github.com/pantsbuild/pants/pull/8799 <- curious what people think of this solution to https://github.com/pantsbuild/pants/issues/8062 , particularly @red-balloon-89377 @witty-crayon-22786 @happy-kitchen-89482
    w
    r
    • 3
    • 42
  • w

    witty-crayon-22786

    12/12/2019, 2:30 AM
    Copy code
    @union
class FormattablePythonType:
	pass


@dataclass
class BlackTarget:
	target: HydratedTarget


@dataclass
class IsortTarget:
	target: HydratedTarget


def rules():
	return [
	  UnionRule(FormattablePythonType, BlackTarget),
	  UnionRule(FormattablePythonType, IsortTarget),
	]


def my_python_formatting_rule(...) -> FormatResult:
	"""This is an aggregator that allows multiple python formatters to coexist.

	TODO: It's not common to need to do this for sideeffects, but it will be common for linting.

	"linters for type" feels like a thing that can be accomplished with (possibly nested) unions?
	  # ... need to filter by relevant to this target type
	await MultiGet[LintResult](LintableType, linter.cls(target) for target in targets for linters in union_membership.members(LintableType))
	"""

	sources = my_python_target...sources
	for member in union_membership.members(FormattablePythonTypes):
	  result = await Get[FormatResult](FormattablePythonTypes, member.cls(sources))
	  sources = result.directory_digest
	  stdout_so_far = result.stdout

	return FormatResult(sources)
  • a

    aloof-angle-91616

    12/12/2019, 7:27 PM
    one optimization just mentioned at bazelcon just now: when a goma client provides file inputs to an action, the file contents aren’t actually transferred to the remote cluster until they’re actually used
  • a

    aloof-angle-91616

    12/12/2019, 7:28 PM
    goma is a distributed build system used by the chromium project which someone at bazelconf is comparing to the remote execution API
  • w

    witty-crayon-22786

    12/12/2019, 7:43 PM
    afaict, it's closer to 
    recc
    , which is the tool that the Bloomberg folks made?
  • w

    witty-crayon-22786

    12/12/2019, 7:44 PM
    (...but i guess since the 
    goma
    client has a daemon, the line is blurry)
  • a

    aloof-angle-91616

    12/12/2019, 7:51 PM
    i’m going to find that guy and talk to him about gcc and clang in the same build
  • w

    witty-crayon-22786

    12/12/2019, 8:01 PM
    this buildstream talk basically has me wondering whether we could give a pants talk at bazelcon =P
1...680681682...906Latest