there is destructuring here

@billowy-beach-68498: is there an updated travis run for https://rbcommons.com/s/twitter/r/3698/ ?

also, can you resolve/drop any remaining issues?

one thing you can do that is helpful, is to include both the pull request and the ticket in the rbcommons

Bugs

field

yes, there is a new run

and I am working with Nick now for issues he raised

But for issues opened by Timur, I guess I have to wait for his reply?

at this point, it's seen enough review, heh

.@tabishev is likely to be checked out for a while, and he'd understand. he just moved to india

so I will close his issues first? or just leave them there

and he moved to India?

yes, temporarily

@billowy-beach-68498: he seems to have marked a few things Issues somewhat arbitrarily.

just to be clear: this has been a very long review: sorry.

let's try to wrap it up and get it in.

ok

@billowy-beach-68498: can you include more information from the ticket in the description as well? that's what gets committed

yes

ok I have updated 1.description 2.testing done 3.bugs fields

ok, great. will wait a little while for any other feedback in General, and then merge.

ok

@billowy-beach-68498: merged! thanks.

feel free to close the pull request.

great! Thank you!

@witty-crayon-22786: I made a final commit about an hour ago, to address the comments I got this afternoon. It seems they didn’t go in. The changes are small though, only some doc changes

@billowy-beach-68498: they would need to have been on the rbcommons review

oh I see. my bad

may be I can integrate into my next review?

@witty-crayon-22786: re https://github.com/pantsbuild/pants/issues/3169, am i on the right track?

class Collection(object):
  @classmethod
  @memoized
  def of(cls, ext):
    type_name = b'Collection({!r})'.format(ext)

    class_dict = {'ext': ext,
                  # # We need custom serialization for the dynamic class type.
                  # '__reduce__': lambda self: (_create_sources, ext)
                  }

    ext_type = type(type_name, (cls, datatype("{}s".format(ext.__name__), ['dependencies'])), class_dict)

    # Expose the custom class type at the module level to be pickle compatible.
    setattr(sys.modules[cls.__module__], type_name, ext_type)

    return ext_type
    
    
Files = Collection.of(File)
Dirs = Collection.of(Dir)

def create_fs_tasks():
  """Creates tasks that consume the native filesystem Node type."""
  return [
    # Glob execution.
    (Stats,
     [SelectProjection(Stats, Dir, ('directory',), PathWildcard),
      Select(PathWildcard)],
     apply_path_wildcard),…

it essentially wraps the

# class Files(datatype('Files', ['dependencies'])):
#   """A set of File objects.""”

into the Collection