https://pantsbuild.org/ logo
Powered by
#development
  • h

    happy-kitchen-89482

    09/30/2019, 8:09 PM
    RuleIndex
    is already a datatype, so why not use that directly?
  • w

    witty-crayon-22786

    09/30/2019, 8:10 PM
    it exposes a lot... i think that we'll want to be very careful about what we give access to there.
  • h

    happy-kitchen-89482

    09/30/2019, 8:10 PM
    Fair
  • h

    happy-kitchen-89482

    09/30/2019, 8:27 PM
    Hmm, looks like we can get the union_rules from 
    BuildConfiguration
  • h

    happy-kitchen-89482

    09/30/2019, 8:27 PM
    Which is already injected
  • w

    witty-crayon-22786

    09/30/2019, 8:31 PM
    mm. yes, i forgot that we were pushing that in.
  • h

    happy-kitchen-89482

    09/30/2019, 8:34 PM
    OK, this seems to work!
  • a

    aloof-angle-91616

    09/30/2019, 8:41 PM
    @hundreds-breakfast-49010 should i close the initial python run console rule PR since you're taking that over?
  • h

    hundreds-breakfast-49010

    09/30/2019, 8:41 PM
    yeah go ahead
    đź‘Ť 1
  • h

    happy-kitchen-89482

    09/30/2019, 9:23 PM
    I must be missing something, but it looks like 
    BuildFileAddress
    and 
    Address
    aren't `datatype`s (or `dataclass`es). How is it we can use them in rules?
  • w

    witty-crayon-22786

    09/30/2019, 9:32 PM
    @happy-kitchen-89482: they have useful hashcode and equals
  • w

    witty-crayon-22786

    09/30/2019, 9:32 PM
    and are immutable
  • h

    happy-kitchen-89482

    09/30/2019, 9:33 PM
    We don't enforce that they're datatypes? That's just convention?
  • w

    witty-crayon-22786

    09/30/2019, 9:33 PM
    just convention, yea.
  • w

    witty-crayon-22786

    09/30/2019, 9:34 PM
    it's possible that if we wanted to harden our sandboxing we'd need to increase the requirements there
  • h

    happy-kitchen-89482

    09/30/2019, 9:38 PM
    Context is this: it would be good if a BuildFileAddress could know its provenance (e.g., did it come from a command-line 
    path/to/dir::
    glob)
  • h

    happy-kitchen-89482

    09/30/2019, 9:39 PM
    The purpose being that we probably want to fail (rather than noop) if the user asked to run tests on a specific target, which isn't a test target.
  • h

    happy-kitchen-89482

    09/30/2019, 9:39 PM
    Whereas if we glob over targets that aren't test targets, we do want to noop on those.
  • h

    happy-kitchen-89482

    09/30/2019, 9:40 PM
    But right now I don't see how to do that.
    w
    • 2
    • 7
  • h

    happy-kitchen-89482

    09/30/2019, 9:40 PM
    I guess we might have to look it up in the build file parser or something.
  • h

    hundreds-breakfast-49010

    09/30/2019, 9:53 PM
    if I have a 
    PythonBinaryAdaptor
    , how can I get access to the 
    SourceFields
    associated with it?
  • h

    hundreds-breakfast-49010

    09/30/2019, 9:53 PM
    calling 
    python_binary_adaptor.sources
    gets me a value of type 
    EagerFilesetWithSpec
    , which is not what I want
    a
    a
    • 3
    • 19
  • a

    aloof-angle-91616

    09/30/2019, 11:25 PM
    a great thread, i especially thought this was a helpful note from @average-vr-56795 on how to hack through the current adaptors API https://pantsbuild.slack.com/archives/C0D7TNJHL/p1569882271318700?thread_ts=1569880416.317600&cid=C0D7TNJHL
  • h

    hundreds-breakfast-49010

    09/30/2019, 11:27 PM
    I found a different way to work around the current adaptors API, but yeah that's probably a helpful snippet to keep in mind
  • a

    aloof-angle-91616

    09/30/2019, 11:27 PM
    ok perf i'll be pumped to see your PR
  • h

    hundreds-breakfast-49010

    09/30/2019, 11:28 PM
    I'm in the process of getting it cleaned up, I'll ping you when that's done
  • a

    aloof-angle-91616

    09/30/2019, 11:28 PM
    oh yeah no rush! trying not to let my general excitement make anyone feel pressured whatsoever
  • h

    hundreds-breakfast-49010

    10/01/2019, 12:58 AM
    do we have any examples of 
    @rules
    where we use a native python collection type, like a list or a tuple, as one of the inputs?
  • h

    hundreds-breakfast-49010

    10/01/2019, 12:59 AM
    maybe something like 
    @rule(SomeOutputType, [List[HydratedTarget], SomeOtherType])
    , or something along those lines
  • a

    aloof-angle-91616

    10/01/2019, 12:59 AM
    well, engine params have to be hashable, so i don't think a list would work
1...656657658...906Latest