pantsbuild #development

Channels

welcome

github-notifications

development

aloof-angle-91616

09/24/2019, 11:35 PM

@enough-analyst-54434 mypy-annotated `@rule`s are INCREDIBLY cool!!! i'll review it posthaste! https://github.com/pantsbuild/pants/pull/8330 for the peanut gallery

❤️ 3

👍 3

red-balloon-89377

09/26/2019, 2:20 PM

Hello! Would folks be against splitting rust unit tests into their own separate files? The structure I have in mind (to invisibly keep all the imports and stuff working) is to transform a source file into a module:

Copy code

❯ tree src
src
└── <http://source.rs|source.rs>

Would turn into:

Copy code

❯ tree src
src
└── source
    ├── <http://lib.rs|lib.rs>
    └── <http://tests.rs|tests.rs>

average-vr-56795

09/26/2019, 2:41 PM

I’m currently watching @fancy-motherboard-24956 writing a v2

@console_rule

using

@union

- we’re keeping track of some areas that we got stuck or gave really bad errors, and will file a series of bugs - will link to them in this thread as we go:

❤️ 2

average-vr-56795

09/26/2019, 3:45 PM

@hundreds-breakfast-49010 Running into some issues using https://github.com/pantsbuild/pants/pull/8329 - are you around? 🙂

aloof-angle-91616

09/26/2019, 3:59 PM

fwiw, i've been continuing to look at https://github.com/pantsbuild/pants/pull/8181 (the

@dataclass

for engine params PR), and just rebased it after the mypy-type

@rule

parameters change john merged yesterday, and there's consistently this one very confusing what-looks-like-a-flake-but-is-happening-reliably in CI -- will try to nail that down today but no promises until i get more time this weekend

👍 1

average-vr-56795

09/26/2019, 4:05 PM

We’re running into an issue where our

console_rule

named

fmt

conflicts with the scope of the v1 goal named

fmt

- we can’t work out how we fixed this for

test

, which doesn’t appear to do any magic to avoid this… Anyone know/remember?

average-vr-56795

09/26/2019, 5:28 PM

Left a comment on the PR instead

hundreds-breakfast-49010

09/26/2019, 5:48 PM

saw it, will take a look

hundreds-breakfast-49010

09/26/2019, 9:07 PM

did you have in mind something like this? https://github.com/gshuflin/pants/commit/dc1044e0c2774e5d809c124d171097ec8a1ea53b

hundreds-breakfast-49010

09/26/2019, 9:08 PM

this is actually failing for me when I try running

./pants test src/python/pants/fs:

hundreds-breakfast-49010

09/26/2019, 9:08 PM

with

hundreds-breakfast-49010

09/26/2019, 9:08 PM

Untitled

hundreds-breakfast-49010

09/26/2019, 9:08 PM

and I can't figure out why this might be happening

hundreds-breakfast-49010

09/26/2019, 10:50 PM

general design question: we'd like to be able to make arbitrary HTTP requests from an

@rule

, and this implies that we'd need an intrinsic and a pair of new types

HttpRequest

and

HttpResponse

, that would work sort of like the existing

UrlToFetch

intrinsic, but more general

aloof-angle-91616

09/26/2019, 10:50 PM

arbitrary http requests sounds great! do you all have a specific use case in mind?

hundreds-breakfast-49010

09/26/2019, 10:51 PM

the way that

UrlToFetch

is implemented is by creating a rust type

DownloadedFile

, and having it implement

WrappedNode

and then the

get

method on

WrappedNode

acutally makes the HTTP request and packages up the response into a

Snapshot

aloof-angle-91616

09/26/2019, 10:52 PM

yes

hundreds-breakfast-49010

09/26/2019, 10:53 PM

but since what we had in mind is basically inherently non-cacheable - certainly HTTP POST requests are not cacheable, and even GET requests we might not want to cache

aloof-angle-91616

09/26/2019, 10:53 PM

i think that's a really nice v2 API for consumers of that

@rule

right now, in which you don't worry about what type of request is being made (it's just injected as the

Snapshot

param, hiding arbitrary logic) and i think the rule graph allows you to avoid having to create massive abstractions upfront like http requests

hundreds-breakfast-49010

09/26/2019, 10:53 PM

I'm not sure if it makes sense to implement this that way

aloof-angle-91616

09/26/2019, 10:53 PM

what type of requests do you have in mind?

hundreds-breakfast-49010

09/26/2019, 10:53 PM

i.e. as a

WrappedNode

aloof-angle-91616

09/26/2019, 10:54 PM

aloof-angle-91616

09/26/2019, 10:54 PM

i'm sorry

aloof-angle-91616

09/26/2019, 10:54 PM

you were talking about the rust engine

aloof-angle-91616

09/26/2019, 10:54 PM

ok, awesome

aloof-angle-91616

09/26/2019, 10:54 PM

thanks, sorry

hundreds-breakfast-49010

09/26/2019, 10:54 PM

I don't htink we should get rid of the the existing

UrlToFetch

abstraction, just add an additional, more complex one

aloof-angle-91616

09/26/2019, 10:54 PM

i thought you were saying this http request intrinsic needed to exist so python rules could use it

aloof-angle-91616

09/26/2019, 10:54 PM

yes, absolutely