Getting this error calling

get_sources()

on an adaptor from a HydratedTarget:

File "/Users/benjyw/.cache/pants/setup/bootstrap-Darwin-x86_64/1.20.0.dev1_py37/lib/python3.7/site-packages/pants/engine/legacy/structs.py", line 69, in get_sources
          globs = BaseGlobs.from_sources_field(sources, self.address.spec_path)
        File "/Users/benjyw/.cache/pants/setup/bootstrap-Darwin-x86_64/1.20.0.dev1_py37/lib/python3.7/site-packages/pants/engine/legacy/structs.py", line 315, in from_sources_field
          raise ValueError('Expected either a glob or list of literal sources: got: {}'.format(sources))
      ValueError: Expected either a glob or list of literal sources: got: EagerFilesetWithSpec(...)

Does this ring any bells?

rust bay area at facebook rn talking about pyoxidizer

check out the bullet with the hyperlink

someone’s opinion about introducing rust at fb

Image from iOS.jpg

Image from iOS.jpg

do we expect `yield`s to selectors to work in functions that are not annotated with

@rule

?

or should those fail or otherwise do something unpredicatable?

yield Get()

should provide an instance of a

Get

to the consumer of the coroutine

i don't think that's useful by itself

@rule

does some parsing in order to get internal

yield Get()

expressions to know what products the rule is going to request

but you can

yield

that

Get

within a rule, it just won't be checked at compile time and may fail if the Get can't be satisfied, i think

i'm looking at https://github.com/pantsbuild/pants/issues/7074 right now / today and i think dataclasses actually might solve some of the things we've been wanting from

datatype

, specifically things like factory methods to coerce individual arguments: https://docs.python.org/3/library/dataclasses.html#dataclasses.field.

Has anyone looked into adding passthrough argument support to V2 goals? It’ll be even more useful now that integration tests are running with V2. I tried to add it today and didn’t get far

reading https://twitter.com/tmandry/status/1163481057619873792?s=21, making me think of the legendary @rules as coroutines pr https://github.com/pantsbuild/pants/pull/5580

abstracting execution with the engine allows us to experiment with APIs for async execution and loads of other things that are usually reserved for programming languages to implement — but the engine is a much smaller piece of code than a language, because we can also lean on python’s dynamism to do some of the heavy lifting (e.g. parsing Gets out of a rule body: https://github.com/pantsbuild/pants/blob/b4e316f4badc2703cea566267886d8b094d0f569/src/python/pants/engine/rules.py#L29)

and i personally pretty frequently think of the rule graph as a type system — not because i think we need to do much more to make it a type system, but as a way to describe its benefits and how to most effectively extend it

and having the ability to experiment with that to make it easy to write typed rulesets to implement real things is so INCREDIBLY cool to me

what are some examples in python tests of how to execute a single

@rule

?

this seems like the sort of thing that must be possible to do and I see lots of code called something like

execute

should I be able to request

ClocBinary

(or any other class representing a binary tool) as a subject of an

@rule

? or is it okay to use

ClocBinary.global_instance().hackily_snapshot(self.context)

in an @rule?

also what is hackily?

should I be able to request

ClocBinary

(or any other class representing a binary tool) as a subject of an

@rule

?

yes, with an

optionable_rule

, because it is a

Subsystem

is it okay to use

ClocBinary.global_instance().hackily_snapshot(self.context)

in an @rule?

no, that's the v1 way.

we have a ticket about this, but i'm having a heck of a time finding it (maybe it was just #6672? but i thought i'd put more info in there..).

right now, you might do something like: https://github.com/pantsbuild/pants/blob/c7dee6621a786d36740b277013bfb6a6ccd945ab/src/python/pants/backend/python/rules/download_pex_bin.py#L17-L19

marrying "i have a `Subsystem`" with the

UrlToFetch

intrinsic would be an excellent project though.

what's the best way in v2 engine to create a file at a specific location, so an external tool can make use of it?