https://pantsbuild.org/ logo
Powered by
#development
  • h

    happy-kitchen-89482

    08/02/2019, 8:53 PM
    Basically I am feeling the promise of the new engine being fulfilled now, and it's so great.
  • w

    witty-crayon-22786

    08/02/2019, 9:15 PM
    i should just log off now, because that made my week 😃
    ❤️ 1
  • w

    witty-crayon-22786

    08/02/2019, 9:16 PM
    lots still to do though! thanks for working on/with it.
  • h

    happy-kitchen-89482

    08/02/2019, 9:32 PM
    I used to dread writing tasks, and I now look forward to writing @rules
  • h

    happy-kitchen-89482

    08/02/2019, 9:33 PM
    Massive kudos to everyone who made this possible!
    ❤️ 1
  • h

    hundreds-father-404

    08/03/2019, 12:38 AM
    Agreed! And it’s only becoming easier the more infrastructure and paradigms we introduce, like Stu’s documentation change!
  • a

    aloof-angle-91616

    08/05/2019, 12:26 AM
  • a

    aloof-angle-91616

    08/07/2019, 12:02 AM
  • w

    witty-crayon-22786

    08/07/2019, 4:06 PM
  • w

    witty-crayon-22786

    08/07/2019, 5:47 PM
  • e

    early-needle-54791

    08/08/2019, 4:15 AM
    Question I’m trying to figure out how a ProcessExecutionRequest pointer gets materialized on the rust side of the FFI, and then run. As far as I can tell here is how it works: * the python engine via a product_request ends up calling 
    Scheduler.execute
    with an execution request that was returned from an ffi call. * That in turn ends up calling the rust ffi 
    scheduler_execute
    method which materializes the scheduler and then calls its internal 
    execute
    method. * rust scheduler.execute materializes the roots into the type of request it contains. * This is where it gets a bit fuzzy for me. The node is added to the graph and somewhere along the line the it is cast into a NodeKey. That NodeKey has run called on it at some point by the graph and the rest is history. Rubber ducking this has helped but I still have some questions about how the rust side 
    Scheduler.execute
    knows how to materialize a given root in the roots list to the correct NodeKey enum variant. I see the NodeKey using the From trait to describe the casting, but I still don’t understand how the root contains the information that it is a specific type of request, i.e which into is called. Any help would be appreciated!
    w
    • 2
    • 9
  • a

    average-vr-56795

    08/08/2019, 9:58 AM
    @fancy-motherboard-24956 Do you have any open edits to the 
    store
    crate? I want to make some invasive changes to it, but don’t want to make merge conflicts…
    f
    • 2
    • 2
  • w

    witty-crayon-22786

    08/09/2019, 1:18 AM
  • w

    witty-crayon-22786

    08/09/2019, 5:21 AM
  • h

    happy-kitchen-89482

    08/09/2019, 5:34 PM
    Random question: has there been any thought given to using standard Python3.7 dataclasses and type annotations instead of our custom 
    datatype
    ? Would that be hard to do?
    a
    w
    h
    • 4
    • 18
  • h

    happy-kitchen-89482

    08/09/2019, 5:36 PM
    It would be really nice to write code that's pants-agnostic, but whose datatypes can be used as Pants products. So rules can be relatively thin wrappers around functionality that knows nothing of pants.
    👌 2
    a
    w
    • 3
    • 44
  • a

    aloof-angle-91616

    08/11/2019, 6:46 PM
  • a

    aloof-angle-91616

    08/11/2019, 6:46 PM
    good replies
  • h

    hundreds-father-404

    08/11/2019, 6:51 PM
    Looks like remoting likely failed due to changes in the Firewall. Google throws a 403 if your IP address isn’t authenticated
    w
    • 2
    • 5
  • h

    happy-kitchen-89482

    08/12/2019, 11:45 PM
    How do I 
    yield Get
    for a singleton?
    a
    a
    w
    • 4
    • 47
  • h

    happy-kitchen-89482

    08/12/2019, 11:46 PM
    Specifically, 
    symbol_table = yield Get(SymbolTable, <what goes here>)
    ?
  • h

    happy-kitchen-89482

    08/14/2019, 12:56 AM
    Getting some impenetrable error messages from my rule:
  • h

    happy-kitchen-89482

    08/14/2019, 12:57 AM
    Copy code
    Computing Select((<pants.engine.console.Console object at 0x1b921575f28>+OptionsBootstrapper(env_tuples<Exactly(tuple)>=(('PANTS_TEST_PYTEST_EXTRA_PYTHONPATH', '/Users/benjyw/Dropbox/pycharm-debug/pydevd-pycharm.egg'),), bootstrap_args<Exactly(tuple)>=(), args<Exactly(tuple)>=('./pants', '--v2', '--no-v1', 'buildgen2', '--buildgen2-source-roots=src/python/'), config<SubclassesOf(Config)>=_ChainedConfig(chained_configs=(<pants.option.config._SingleFileConfig object at 0x1b92137ac88>,)))), BuildGen)
  Computing Task(buildgen(), (<pants.engine.console.Console object at 0x1b921575f28>+OptionsBootstrapper(env_tuples<Exactly(tuple)>=(('PANTS_TEST_PYTEST_EXTRA_PYTHONPATH', '/Users/benjyw/Dropbox/pycharm-debug/pydevd-pycharm.egg'),), bootstrap_args<Exactly(tuple)>=(), args<Exactly(tuple)>=('./pants', '--v2', '--no-v1', 'buildgen2', '--buildgen2-source-roots=src/python/'), config<SubclassesOf(Config)>=_ChainedConfig(chained_configs=(<pants.option.config._SingleFileConfig object at 0x1b92137ac88>,)))), BuildGen, false)
    Computing Task(analyze_source_file(), SourceFileAndRoot(file_content<Exactly(FileContent)>=FileContent(path=src/python/toolchain/buildstats/jinja2/buildstats/base.html, content=(len:1103)), source_root<Exactly(str)>=src/python/), SourceFileAnalysis, true)
      Throw()
        Traceback (most recent call last):
          File "/Users/benjyw/.cache/pants/setup/bootstrap-Darwin-x86_64/1.20.0.dev1_py37/lib/python3.7/site-packages/pants/engine/native.py", line 440, in extern_generator_send
            res = c.from_value(func[0]).send(c.from_value(arg[0]))
        StopIteration
  • h

    happy-kitchen-89482

    08/14/2019, 12:57 AM
    Getting lots of these in a single run
  • h

    happy-kitchen-89482

    08/14/2019, 12:57 AM
    There's no backtrace into my rule's code, so it's hard to know what this is about
  • h

    happy-kitchen-89482

    08/14/2019, 12:57 AM
    What does this usually mean?
  • h

    happy-kitchen-89482

    08/14/2019, 12:59 AM
    Oh, I think a subrule is returning None instead of yielding
  • h

    happy-kitchen-89482

    08/14/2019, 12:59 AM
    Yeah that was it
  • h

    happy-kitchen-89482

    08/14/2019, 12:59 AM
    Still, not the greatest error message
    w
    a
    • 3
    • 6
  • a

    aloof-angle-91616

    08/14/2019, 4:54 PM
1...636637638...906Latest