https://pantsbuild.org/ logo
Powered by
#development
  • w

    witty-crayon-22786

    04/14/2016, 1:31 AM
    i'm going to do a bit more testing tomorrow
  • w

    witty-crayon-22786

    04/14/2016, 1:31 AM
    but you can see that we use ProjectTree pretty heavily there.
  • w

    witty-crayon-22786

    04/14/2016, 4:00 AM
    @red-cpu-25099: ^ you too
  • b

    billowy-beach-68498

    04/14/2016, 2:22 PM
    ok, thanks for the link!
  • w

    witty-crayon-22786

    04/19/2016, 5:10 PM
    @red-cpu-25099, @billowy-beach-68498 : fyi: https://rbcommons.com/s/twitter/r/3691/ is in
  • w

    witty-crayon-22786

    04/19/2016, 7:36 PM
    @full-kilobyte-93429: quickie: https://rbcommons.com/s/twitter/r/3724/
  • f

    full-kilobyte-93429

    04/19/2016, 8:05 PM
    wow big difference!
  • f

    full-kilobyte-93429

    04/19/2016, 8:05 PM
    🚢
  • b

    billowy-beach-68498

    04/19/2016, 8:25 PM
    OK. I will apply pants ignore to those new methods in project tree as well
  • w

    witty-crayon-22786

    04/19/2016, 8:26 PM
    thanks
  • w

    witty-crayon-22786

    04/19/2016, 8:28 PM
    @billowy-beach-68498: hey, one/two other things that would be good to fix in that review
  • w

    witty-crayon-22786

    04/19/2016, 8:28 PM
  • w

    witty-crayon-22786

    04/19/2016, 8:28 PM
    it drops 
    .*
    (ie, anything that starts with 
    .
    dot)
  • w

    witty-crayon-22786

    04/19/2016, 8:29 PM
    rather than doing that, i think the 
    legacy
    package should set up ignore patterns to do that.
  • b

    billowy-beach-68498

    04/19/2016, 8:36 PM
    where is that “dropping .” logic currently implemented?
  • w

    witty-crayon-22786

    04/19/2016, 8:36 PM
    right there
  • w

    witty-crayon-22786

    04/19/2016, 8:36 PM
    ...er
  • w

    witty-crayon-22786

    04/19/2016, 8:36 PM
    guess i moved it. sorry
  • w

    witty-crayon-22786

    04/19/2016, 8:37 PM
    huh! i guess i dropped that filtering entirely. @billowy-beach-68498 : you should just be able to remove that comment.
  • w

    witty-crayon-22786

    04/19/2016, 8:38 PM
    it would still be good to attempt to actually set some ignore patterns at https://github.com/pantsbuild/pants/blob/master/src/python/pants/engine/exp/legacy/commands.py#L52
  • b

    billowy-beach-68498

    04/19/2016, 8:40 PM
    ok
  • b

    billowy-beach-68498

    04/19/2016, 8:40 PM
    so remove the comment in fs.py and add .* as ignored in commands.py
  • b

    billowy-beach-68498

    04/19/2016, 8:40 PM
    right?
  • w

    witty-crayon-22786

    04/19/2016, 8:40 PM
    yep!
  • b

    billowy-beach-68498

    04/19/2016, 8:41 PM
    I have a general question. I though project tree is set up in goal_runner when start up pants. What are we doing here?
  • w

    witty-crayon-22786

    04/19/2016, 8:41 PM
    @billowy-beach-68498: yes, it is.
  • w

    witty-crayon-22786

    04/19/2016, 8:42 PM
    the 
    legacy
    package is for integrating the new engine with the existing buildgraph
  • w

    witty-crayon-22786

    04/19/2016, 8:42 PM
    when Kris gets back from vacation, a lot of what is in 
    legacy
    will move out into the goal_runner behind a flag
  • b

    billowy-beach-68498

    04/19/2016, 8:43 PM
    oh i see
  • w

    witty-crayon-22786

    04/19/2016, 9:36 PM
    @billowy-beach-68498: what's your github user name?
1...626364...906Latest