aloof-angle-91616
12/08/2018, 2:35 AMaloof-angle-91616
12/08/2018, 2:35 AMaloof-angle-91616
12/08/2018, 2:39 AMaloof-angle-91616
12/08/2018, 5:42 PMaloof-angle-91616
12/08/2018, 5:45 PMclass ListAndDieForTesting(Subsystem):
"""A fast and deadly variant of `./pants list`."""
options_scope = 'list-and-die-for-testing'
@console_rule(ListAndDieForTesting, [Select(Console), Select(BuildFileAddresses)])
the correspondence between goals and `options_scope`s is perfectaloof-angle-91616
12/08/2018, 6:02 PM@console_rule
returning a subsystem is i think about as key as the Select(Console)
-- the Select(Console)
part says "we need exclusive access to the global singleton tty", while the @console_rule(ListAndDieForTesting, ...)
says "this rule is intended to list some things and perform some side effects (terminal i/o)"aloof-angle-91616
12/08/2018, 6:03 PMaloof-angle-91616
12/08/2018, 6:48 PMSelect(...)
at this point (as opposed to tuples)? i'm 1000% fine with the current API, i'm just wondering since we've had the coroutines brainblast and were able to make that logic more granular (compared to e.g. SelectDependencies
), whether we want to move to e.g. @rule(MyProduct, [MySubject, MySubsystem])
. i really don't like it when projects move too fast from primitives to higher-level abstractions, and i don't want to remove the ability to extend the selection later (although i guess we could do the normal thing we do with like subsystem dependencies and interpret a class MySubject
as Select(MySubject)
in the @rule
declaration)aloof-angle-91616
12/08/2018, 6:49 PM@rule(MyProduct, [MySubject, Select(SomethingElse)])
def whatever(...):
# ...
could maybe just expand to:
@rule(MyProduct, [Select(MySubject), Select(SomethingElse)])
def whatever(...):
# ...
aloof-angle-91616
12/08/2018, 7:27 PMaloof-angle-91616
12/09/2018, 8:24 PM3fbb0e377212558cca7b4d4aca586e2770249431
or earlier which i remember i was going to make a pull request comment on, but didn't. going to verify and then fixaloof-angle-91616
12/09/2018, 9:04 PMaloof-angle-91616
12/09/2018, 10:22 PMPathGlobsAndRoot
doesn't have an intrinsic, which i'm going to add nowaloof-angle-91616
12/09/2018, 10:39 PMaloof-angle-91616
12/09/2018, 10:40 PMyield Get(Snapshot, PathGlobsAndRoot, my_globs_with_root)
and this is because the files i'm trying to get are for cargo and rustup etcaloof-angle-91616
12/09/2018, 10:40 PMaloof-angle-91616
12/09/2018, 10:41 PMaloof-angle-91616
12/09/2018, 11:00 PMaloof-angle-91616
12/09/2018, 11:23 PMaloof-angle-91616
12/09/2018, 11:23 PMaloof-angle-91616
12/09/2018, 11:36 PMaloof-angle-91616
12/10/2018, 1:28 AMaloof-angle-91616
12/10/2018, 2:46 AMaloof-angle-91616
12/10/2018, 2:48 AMyield Get(Snapshot, PathGlobsAndRoot, ...)
) made me waste several hours today because it just said "no installed rules could satisfy the selection" or something and i'm not sure where to change to make that betteraverage-vr-56795
12/10/2018, 2:22 PMSelect
from @rule
signatures… What’s needed to do that?average-vr-56795
12/10/2018, 3:29 PMhappy-kitchen-89482
12/10/2018, 7:01 PM./pants <anything>
and get this error:
WARN] caught OSError([Errno 1] Operation not permitted) during attempt to kill -15 60!
WARN] caught OSError([Errno 1] Operation not permitted) during attempt to kill -9 60!
happy-kitchen-89482
12/10/2018, 7:01 PMhappy-kitchen-89482
12/10/2018, 7:01 PMconfigd
, a macos system processhappy-kitchen-89482
12/10/2018, 7:02 PM