https://pantsbuild.org/ logo
Powered by
#development
  • w

    witty-crayon-22786

    10/18/2018, 4:23 PM
    wait, sorry: what are you trying to do here?
  • a

    average-vr-56795

    10/18/2018, 4:23 PM
    So I can explicitly have a 
    HydratedTargets
    as my selected thing, but I can’t ask for a 
    BuildFileAddresses
    and have it implicitly make my a 
    HydratedTargets
    in the middle
  • w

    witty-crayon-22786

    10/18/2018, 4:23 PM
    the 
    Select(BuildFileAddress)
    should definitely work, as that's what 
    fast_list
    does
  • a

    average-vr-56795

    10/18/2018, 4:23 PM
    Change from: 
    @console_rule('test', [Select(Console), Select(HydratedTargets)])
    to 
    @console_rule('test', [Select(Console), Select(BuildFileAddresses)])
  • w

    witty-crayon-22786

    10/18/2018, 4:23 PM
    the call in question here is 
    Get(TestResult, Address)
  • w

    witty-crayon-22786

    10/18/2018, 4:23 PM
    if you are passing it a BuildFileAddress, you probably need to pass it an Address
  • w

    witty-crayon-22786

    10/18/2018, 4:24 PM
    (and if that's what's happening, we should be exploding here)
  • a

    average-vr-56795

    10/18/2018, 4:24 PM
    Can I up-cast a 
    BuildFileAddress
    to an 
    Address
    somehow?
  • w

    witty-crayon-22786

    10/18/2018, 4:24 PM
  • a

    average-vr-56795

    10/18/2018, 4:25 PM
    I’m really disliking the whole sub/super-types not working thing…
  • w

    witty-crayon-22786

    10/18/2018, 4:25 PM
    it's for a good reason... but yea, needs more work
    • 1
    • 2
  • a

    average-vr-56795

    10/18/2018, 4:25 PM
    Ok, address-ifying my `BuildFileAddress`es works 🙂 Thanks!
  • w

    witty-crayon-22786

    10/18/2018, 4:26 PM
    k... i'll open a ticket about adding validation on 
    Get
  • w

    witty-crayon-22786

    10/18/2018, 4:26 PM
    sorry
  • a

    average-vr-56795

    10/18/2018, 4:26 PM
    No worries!
  • a

    average-vr-56795

    10/18/2018, 4:27 PM
    I think when we get around to handing this to people not on our team, we’re going to need a better documentation/lookup/how-do-I-get-what-I-need story than “visualize to a graph”…
  • w

    witty-crayon-22786

    10/18/2018, 4:27 PM
    well, it should fail fast right there
  • w

    witty-crayon-22786

    10/18/2018, 4:27 PM
    at the callsite where you pass the wrong type to a Get
  • a

    average-vr-56795

    10/18/2018, 4:28 PM
    But for me as a random open source developer, I’m not going to know that 
    HydratedTarget
    or 
    BuildFileAddress
    is the right thing for me to be using as input to my rule
  • w

    witty-crayon-22786

    10/18/2018, 4:28 PM
    the graph is valid and satisfiable, but we don't fail fast when we get the wrong type
  • w

    witty-crayon-22786

    10/18/2018, 4:28 PM
    mm, yea.
  • w

    witty-crayon-22786

    10/18/2018, 4:28 PM
    typed targets will help there maybe?
  • a

    average-vr-56795

    10/18/2018, 4:28 PM
    Addressable with documentation, but something we should start thinking about planning 🙂
  • a

    average-vr-56795

    10/18/2018, 4:29 PM
    Yeah, I imagine so
  • w

    witty-crayon-22786

    10/18/2018, 4:29 PM
    but we should also nuke 
    BuildFileAddress
    ... not sure it's even used anymore
  • w

    witty-crayon-22786

    10/18/2018, 4:34 PM
  • a

    average-vr-56795

    10/18/2018, 4:37 PM
    One last question… On https://github.com/pantsbuild/pants/issues/6652#issuecomment-431071902 - do I fix that by passing a flag to pants to install a new backend?
  • w

    witty-crayon-22786

    10/18/2018, 4:39 PM
    there is an "internal" backend already
  • w

    witty-crayon-22786

    10/18/2018, 4:39 PM
    sec
  • w

    witty-crayon-22786

    10/18/2018, 4:39 PM
    pants-plugins/README.md
    in pantsbuild/pants
1...588589590...906Latest