https://pantsbuild.org/ logo
Powered by
#development
  • w

    wide-energy-11069

    10/17/2018, 5:38 PM
    awesome thanks!
  • w

    witty-crayon-22786

    10/17/2018, 5:38 PM
    i nearly opened a ticket against rust for that one... probably should
  • w

    witty-crayon-22786

    10/17/2018, 5:39 PM
    it's sortof an "underflowing an unsigned integer panics" type situation, and is understandable in that context. but when you have an actual method involved, it should reaaaally return an 
    Option
    to indicate that it is not always defined
  • w

    wide-energy-11069

    10/17/2018, 5:41 PM
    interesting. more things to be careful about when doing async things 🙂
  • w

    witty-crayon-22786

    10/17/2018, 5:49 PM
    yea, it's a weird situation. sortof a microoptimization to avoid syscalls
  • a

    average-vr-56795

    10/17/2018, 5:55 PM
    We may want to switch to https://docs.rs/time/0.1.40/time/ for that
  • a

    average-vr-56795

    10/17/2018, 5:55 PM
    The std stuff panics because it’s designed for monotonic real time
  • a

    average-vr-56795

    10/17/2018, 5:55 PM
    The time crate is built to support arbitrary time notions, and allows negative durations and such
  • a

    average-vr-56795

    10/17/2018, 5:57 PM
    (But tbh I think the current solution is reasonable)
  • w

    witty-crayon-22786

    10/17/2018, 5:57 PM
    yea.
  • a

    average-vr-56795

    10/17/2018, 6:07 PM
    So @console_rule doesn’t work with run_rule because we hit https://github.com/pantsbuild/pants/blob/master/src/python/pants/engine/rules.py#L97-L99 where 
    res
    is a generator
  • a

    average-vr-56795

    10/17/2018, 6:08 PM
    If I consume the generator until it exhausts, everything works
  • a

    average-vr-56795

    10/17/2018, 6:08 PM
    But… Yeah…
  • w

    witty-crayon-22786

    10/17/2018, 6:08 PM
    run_rule might just need a tiny tweak...?
  • w

    witty-crayon-22786

    10/17/2018, 6:08 PM
    but yea, sorry.
  • a

    average-vr-56795

    10/17/2018, 6:08 PM
    Will play 🙂
  • w

    witty-crayon-22786

    10/17/2018, 6:09 PM
    er... wait. that feels more fundamental
  • w

    witty-crayon-22786

    10/17/2018, 6:10 PM
    ...is there maybe not currently support for `@console_rule`s that are generators...?
  • a

    average-vr-56795

    10/17/2018, 6:10 PM
    I can believe that…
  • a

    average-vr-56795

    10/17/2018, 6:10 PM
    fast_list
    doesn’t have a generator
  • w

    witty-crayon-22786

    10/17/2018, 6:10 PM
    doh.
  • w

    witty-crayon-22786

    10/17/2018, 6:10 PM
    i can jump on that today.
  • a

    average-vr-56795

    10/17/2018, 6:10 PM
    What is it with you and giving me small tickets that turn out to be hiding more work? 😄
  • a

    average-vr-56795

    10/17/2018, 6:11 PM
    If you wouldn’t mind, that would be fabulous 🙂
  • a

    average-vr-56795

    10/17/2018, 6:11 PM
    Alternatively I can give it a go if you can sketch out what I’d be doing
  • w

    witty-crayon-22786

    10/17/2018, 6:11 PM
    i feel like i might have partially implemented this.
  • a

    average-vr-56795

    10/17/2018, 6:12 PM
    ok 🙂 If you want to hand off at some point, feel free, though
  • w

    witty-crayon-22786

    10/17/2018, 6:12 PM
    yea, damn. it's in the fast_dependees branch
  • w

    witty-crayon-22786

    10/17/2018, 6:13 PM
    @average-vr-56795: i'll have it out shortly. just need to add a quick test
  • a

    average-vr-56795

    10/17/2018, 6:13 PM
    Thanks!
1...583584585...906Latest