https://pantsbuild.org/ logo
Powered by
#development
  • a

    average-vr-56795

    10/17/2018, 2:46 PM
    @witty-crayon-22786 How are you imagining https://github.com/pantsbuild/pants/issues/6003 looking signature-wise, given untyped targets?
  • a

    average-vr-56795

    10/17/2018, 2:48 PM
    Will there be one 
    HydratedTarget -> TestResult
    rule which knows everything and dispatches? Or typed `TestResult`s per target type? Or many rules which are invoked, which inspect the 
    HydratedTarget
    type and no-op if nothing to do? Or something else?
  • w

    witty-crayon-22786

    10/17/2018, 4:01 PM
    pre-4535, i'm thinking that there will be a rule with a switch statement, approximately
  • w

    witty-crayon-22786

    10/17/2018, 4:02 PM
    to do the downcast
  • w

    witty-crayon-22786

    10/17/2018, 4:02 PM
    (upcast...?)
  • w

    witty-crayon-22786

    10/17/2018, 4:03 PM
    so the signature of the actual rule will look as described there... but then glueing it together with #6006 will involve the switch statement
  • a

    average-vr-56795

    10/17/2018, 4:04 PM
    So are you expecting https://github.com/pantsbuild/pants/issues/6006 to be the switch statement, or to consume the output of the switch statement?
  • w

    witty-crayon-22786

    10/17/2018, 4:04 PM
    6006 and 6003 can be landed independently
  • w

    witty-crayon-22786

    10/17/2018, 4:05 PM
    so it might be a third ticket that links them
  • a

    average-vr-56795

    10/17/2018, 4:05 PM
    Yeah, Iā€™m just trying to work out whether 6006 will consume HydatedTargets or TestResults šŸ™‚
  • w

    witty-crayon-22786

    10/17/2018, 4:06 PM
    @average-vr-56795: the signature i was thinking there is:
    Copy code
    @console_rule('test', [Select(Console), Select(HydratedTargets)])
def fast_test(console, hydrated_targets):
  test_results = yield [Get(TestResult, HydratedTarget, ht) for ht in hydrated_targets]

  ... # use extracted static function to render the `TestResult` instances.
  • a

    average-vr-56795

    10/17/2018, 4:06 PM
    Which implies the switch statement exists in another rule
  • w

    witty-crayon-22786

    10/17/2018, 4:06 PM
    yes
  • a

    average-vr-56795

    10/17/2018, 4:06 PM
    Sounds good šŸ™‚ Thanks
  • w

    witty-crayon-22786

    10/17/2018, 4:06 PM
    third ticket post 6006 and 6003
  • a

    average-vr-56795

    10/17/2018, 4:07 PM
    Sounds good šŸ™‚ Thanks again!
  • w

    witty-crayon-22786

    10/17/2018, 4:07 PM
    unless one of them has fully landed such that the next one can consume it
  • a

    average-vr-56795

    10/17/2018, 5:09 PM
    It feels like there are three levels of tests for v2 rules: 1. Unit tests - I call the function with some populated arguments, and see what it does. This is tricky if there are any `Get`s 2. Integration tests with a scheduler - I construct a graph, possibly faking out some values, request a product, and see what I get 3. End to end tests - I invoke pants and see what happens Do those all sound reasonable?
  • w

    witty-crayon-22786

    10/17/2018, 5:12 PM
  • w

    witty-crayon-22786

    10/17/2018, 5:13 PM
    (i didn't suggest it for those tickets though, because i'm not 100% confident that it would work for a 
    @console_rule
    ... maybe it would?)
  • w

    witty-crayon-22786

    10/17/2018, 5:13 PM
    and yea, 2 and 3 sound reasonable
  • w

    witty-crayon-22786

    10/17/2018, 5:14 PM
    @average-vr-56795: ^
  • a

    average-vr-56795

    10/17/2018, 5:15 PM
    Cool, thanks!
  • w

    witty-crayon-22786

    10/17/2018, 5:16 PM
    i think that 
    run_rule
    with a 
    @console_rule
    would work with some minor tweaks
  • w

    witty-crayon-22786

    10/17/2018, 5:16 PM
    (essentially: making the final yield optional)
  • w

    witty-crayon-22786

    10/17/2018, 5:17 PM
    ...oh, scratch that. the 
    @console_rule
    machinery already does that. so yea, should work
  • w

    witty-crayon-22786

    10/17/2018, 5:25 PM
    it's also possible with 1. to inject mocked data in response to Get requests... i think all of the build file parsing examples of 
    run_rule
    use actual types because they're relatively easy to construct, but should be possible to use python mocking as well
  • w

    witty-crayon-22786

    10/17/2018, 5:26 PM
    (in most situations)
  • w

    witty-crayon-22786

    10/17/2018, 5:26 PM
    ... it occurs to me that 1 and 2 would get... interesting... with starlark
  • w

    witty-crayon-22786

    10/17/2018, 5:37 PM
    @wide-energy-11069: landed the fix for the heavy_hitters panic
1...582583584...906Latest