https://pantsbuild.org/ logo
Powered by
#development
  • a

    average-vr-56795

    07/17/2018, 5:23 PM
    I feel like “attempt to hardlink, if can’t, copy” is probably reasonable
  • w

    witty-crayon-22786

    07/17/2018, 5:23 PM
    will that work for a directory...?
  • a

    average-vr-56795

    07/17/2018, 5:24 PM
    No, but we symlink the files directly
  • w

    witty-crayon-22786

    07/17/2018, 5:24 PM
    ivy is per-file... i think coursier is a directory. cc @wide-energy-11069
  • a

    average-vr-56795

    07/17/2018, 5:24 PM
    Aha
  • w

    wide-energy-11069

    07/17/2018, 5:26 PM
    .pants.d/resolve/coursier/…
    are all symlinks to into 
    ~/.cache/pants/coursier/cache…
  • w

    witty-crayon-22786

    07/17/2018, 5:27 PM
    oh, individual symlinks? nice.
  • w

    witty-crayon-22786

    07/17/2018, 5:27 PM
    er
  • w

    witty-crayon-22786

    07/17/2018, 5:28 PM
    that sounds challenging to implement, but maybe since it's append only it just works...?
    w
    • 2
    • 2
  • a

    average-vr-56795

    07/17/2018, 5:34 PM
    The hardlink thing sounds challenging, you mean?
  • w

    witty-crayon-22786

    07/17/2018, 5:35 PM
    no, that should be easy if we're currently symlinking individual files (so, good!)
  • w

    witty-crayon-22786

    07/17/2018, 5:35 PM
    the challenging thing (i think) is maintaining a tree of real directories containing symlinks. i guess we have utility code to do that, but also, since it's append only and no directories are ever replaced with symlinks, etc, it's a bit easier
  • w

    witty-crayon-22786

    07/17/2018, 5:36 PM
    (sorry, i could settle that by looking at the code, but instead i'm spreadin fud)
  • w

    witty-crayon-22786

    07/17/2018, 5:36 PM
    yea, so hardlinking should be straightforward. pheew.
  • a

    average-vr-56795

    07/17/2018, 5:39 PM
    Sweet 🙂
  • w

    wide-energy-11069

    07/17/2018, 5:40 PM
    is this for the remoting context?
  • w

    witty-crayon-22786

    07/17/2018, 5:41 PM
    yea
  • w

    witty-crayon-22786

    07/17/2018, 5:41 PM
    "what path should be contained in the Snapshot of a jar"
  • w

    witty-crayon-22786

    07/17/2018, 5:41 PM
    there was some discussion yesterday as well
  • w

    witty-crayon-22786

    07/17/2018, 5:42 PM
    ... not in this room though. hm. where was that.
  • w

    wide-energy-11069

    07/17/2018, 5:42 PM
    is it fair to say in short, the snapshot will contain the 3rdparty jars, but their paths do not matter?
  • w

    witty-crayon-22786

    07/17/2018, 5:42 PM
    they do matter, because they can collide
    👌 1
  • w

    witty-crayon-22786

    07/17/2018, 5:43 PM
    ...ah, the discussion was in internal slack. whoops.
  • w

    witty-crayon-22786

    07/17/2018, 5:43 PM
    we need to be better about that.
  • w

    witty-crayon-22786

    07/17/2018, 5:57 PM
    typed up some thoughts/questions about the next steps for the subsingliant patch: https://github.com/pantsbuild/pants/issues/5788#issuecomment-405671047
  • w

    witty-crayon-22786

    07/17/2018, 5:57 PM
    interested in everyone's feedback, but pinging @average-vr-56795 in particular to try and get him before he leaves for the day
  • w

    witty-crayon-22786

    07/17/2018, 7:00 PM
    @salmon-summer-38098, @rough-minister-58256: ^ fyi as well
  • a

    average-vr-56795

    07/17/2018, 7:19 PM
    @witty-crayon-22786 So the two alternatives are effectively “treat env as a RunToken bump” or “treat env as part of the NodeKey”, right?
  • w

    witty-crayon-22786

    07/17/2018, 7:20 PM
    ~yes, i think so?
  • w

    witty-crayon-22786

    07/17/2018, 7:20 PM
    "treat env like a file" vs "treat env as part of the NodeKey"
1...562563564...906Latest