https://pantsbuild.org/ logo
Powered by
#development
  • w

    witty-crayon-22786

    06/28/2018, 9:40 PM
    @average-vr-56795: for reference, this is the working dep inference demo: https://github.com/pantsbuild/pants/compare/master...twitter:stuhood/dep-inference-demo ... the primary hacky thing there is that the 
    extractimports
    binary is committed
  • w

    witty-crayon-22786

    06/28/2018, 11:48 PM
  • w

    witty-crayon-22786

    06/28/2018, 11:49 PM
    voila, no need to declare those.
  • e

    enough-analyst-54434

    06/29/2018, 6:27 PM
    Does anyone have context on this intermittent CI failure in rust tests?:
    Copy code
    thread panicked while panicking. aborting.
error: process didn't exit successfully: `/home/travis/build/pantsbuild/pants/src/rust/engine/target/debug/deps/process_execution-3457b23e8126720e ` (signal: 4, SIGILL: illegal instruction)
Pants rust test failure
    a
    • 2
    • 1
  • e

    enough-analyst-54434

    06/29/2018, 6:28 PM
    I think this has been present for O(few months)
  • w

    witty-crayon-22786

    07/02/2018, 7:31 PM
    @rough-minister-58256: is there a 
    __??__
    method that runs once during the initialization of a class (ie, once at load time) that could be used to validate the definition?
  • w

    witty-crayon-22786

    07/02/2018, 7:31 PM
    i could put this validation logic in the constructor or something, but it only needs to run once.
  • r

    rough-minister-58256

    07/02/2018, 7:33 PM
    not a magic method that I’m aware of that fits that bill
  • r

    rough-minister-58256

    07/02/2018, 7:33 PM
    but you could make a class factory?
  • w

    witty-crayon-22786

    07/02/2018, 7:40 PM
    well, concretely, this is 
    datatype
  • w

    witty-crayon-22786

    07/02/2018, 7:41 PM
    so... i guess so. but i think that that would mean turning it inside out
  • w

    witty-crayon-22786

    07/02/2018, 7:42 PM
    from 
    class Concrete(datatype([..]))
    to 
    datatype('Concrete', [..])
    ... which looks familiar.
  • w

    witty-crayon-22786

    07/02/2018, 7:42 PM
    but would need to ban subtyping
  • w

    witty-crayon-22786

    07/02/2018, 7:42 PM
    ...and that isn't what i'm trying to do, because there are still plenty of reasons to subtype.
  • w

    witty-crayon-22786

    07/02/2018, 7:43 PM
    i'm trying to just ban overriding a method.
  • w

    witty-crayon-22786

    07/02/2018, 7:47 PM
    ...it's a pretty cheap check though. will just do it in the constructor.
  • r

    rough-minister-58256

    07/02/2018, 8:11 PM
    ah hm, well there might actually be one magic method that could help there: 
    __metaclass__
    - but cheap check in the constructor is likely way clearer/cleaner.
  • w

    witty-crayon-22786

    07/02/2018, 8:12 PM
  • r

    rough-minister-58256

    07/02/2018, 10:51 PM
    ic. yeah, can’t really think of a cleaner way to do that that
  • r

    rough-minister-58256

    07/02/2018, 10:54 PM
    tho maybe: 
    if cls.__eq__ == datatype.__eq__
    could elide the canary attr?
  • w

    witty-crayon-22786

    07/02/2018, 11:11 PM
    oh, interesting.
  • r

    rough-minister-58256

    07/02/2018, 11:17 PM
    btw, what was the patch you were mentioning in standup re: engine driving 
    @console_rule
    execution?
  • w

    witty-crayon-22786

    07/02/2018, 11:21 PM
    @rough-minister-58256: the node dirtying stuff
  • w

    witty-crayon-22786

    07/02/2018, 11:22 PM
    ...but... now that i think about it more, it's not too closely related.
  • r

    rough-minister-58256

    07/02/2018, 11:24 PM
    ah, k
  • w

    witty-crayon-22786

    07/02/2018, 11:24 PM
    @rough-minister-58256: basically, there is a method 
    Entry::clear()
    in the graph
  • r

    rough-minister-58256

    07/02/2018, 11:24 PM
    aha
  • w

    witty-crayon-22786

    07/02/2018, 11:24 PM
    ...oh! actually, this is straightforward.
  • w

    witty-crayon-22786

    07/02/2018, 11:24 PM
    forget what i said about 
    clear()
    , heh
  • w

    witty-crayon-22786

    07/02/2018, 11:24 PM
    instead, 
    Graph::create
    is probably the area to focus on.
1...550551552...906Latest