https://pantsbuild.org/ logo
Powered by
#development
  • w

    witty-crayon-22786

    06/21/2018, 7:01 PM
    @rough-minister-58256: ^
  • r

    rough-minister-58256

    06/21/2018, 7:02 PM
    I had sort of imagined a {BL}SP impl as a 
    PantsService
    w/ direct 
    SchedulerService.scheduler
    access?
  • w

    witty-crayon-22786

    06/21/2018, 7:03 PM
    yea, it could be. it would be pretty incredible if the API "easily" allowed for that the same way it allows for console access though.
  • w

    witty-crayon-22786

    06/21/2018, 7:04 PM
    anyway, at this point it's just a naming thing... nothing to implement yet
  • w

    witty-crayon-22786

    06/21/2018, 7:04 PM
    (just the idea that you could inject other otherwise-illegal resources to a 
    @foreground_rule
    )
  • r

    rough-minister-58256

    06/21/2018, 7:05 PM
    yeah, could see it
  • a

    aloof-angle-91616

    06/21/2018, 7:12 PM
    i feel like yeah the console task would take care of reading/writing from the terminal meanwhile a bloop wrapper would take care of spinning up bloop(s) and/or tearing them down, as well as doing all communication with them, and phrasing the communication with pants as a 
    PantsService
    as above feels reasonable.
    w
    • 2
    • 4
  • a

    aloof-angle-91616

    06/21/2018, 7:13 PM
    which would just make async calls for products
  • r

    rough-minister-58256

    06/21/2018, 7:13 PM
    yep
  • a

    aloof-angle-91616

    06/21/2018, 7:14 PM
    doesn't even need to be tied to any particular async model in python probably should be (i guess 
    yield
    is pretty much there anyway)
  • a

    aloof-angle-91616

    06/21/2018, 7:15 PM
    also, do console tasks now cover "anything that prints to the terminal that's not a workunit" or "specifically interactive repls"
  • a

    aloof-angle-91616

    06/21/2018, 7:16 PM
    like iirc cloc is a ConsoleTask? but that feels like a useful distinction -- again not thinking it needs to make any impl different
  • a

    aloof-angle-91616

    06/21/2018, 7:17 PM
    would you ever need to worry about the letters "tty" if you're not doing a repl task?
  • r

    rough-minister-58256

    06/21/2018, 7:18 PM
    you might have a @console_rule that is fully tty interactive w/ a curses display or something; run also would need to support that
    a
    • 2
    • 1
  • w

    witty-crayon-22786

    06/21/2018, 7:35 PM
    a cloc goal would be made up of two pieces
  • w

    witty-crayon-22786

    06/21/2018, 7:35 PM
    (ideally) a cloc @rule that runs per-target
  • w

    witty-crayon-22786

    06/21/2018, 7:36 PM
    and a cloc @console_rule that aggregates/sums
  • a

    aloof-angle-91616

    06/21/2018, 7:36 PM
    great that was my thought as well
  • w

    witty-crayon-22786

    06/21/2018, 7:37 PM
    the current formulation is "get all of the sources and then invoke once"... but would be good to move away from that if possible.
  • a

    aloof-angle-91616

    06/21/2018, 7:39 PM
    as mentioned once previously i have elisp code that does that so it's highly feasible previously i was waiting on the ability to obtain stdout from process execution but that's been done for a while
  • w

    witty-crayon-22786

    06/21/2018, 7:40 PM
    @rough-minister-58256: one more thought that would be good to spell out
  • w

    witty-crayon-22786

    06/21/2018, 7:40 PM
    the locking scope of 
    @console_rule
    would be for that "session"
  • w

    witty-crayon-22786

    06/21/2018, 7:40 PM
    rather than global across all pantsd sessions
  • w

    witty-crayon-22786

    06/21/2018, 7:41 PM
    well, i guess that's obvious. but it changes the factoring a bit.
  • w

    witty-crayon-22786

    06/21/2018, 7:42 PM
    there is a literal 
    Session
    object now. so you might have multiple 
    Sessions
    interacting with one `Scheduler`: https://github.com/pantsbuild/pants/blob/master/src/rust/engine/src/scheduler.rs#L21-L33
  • w

    witty-crayon-22786

    06/21/2018, 8:08 PM
    @rough-minister-58256: tasks look good! ... rather than separating the first 3/4, i think they should be mashed up, and simplified by just having basic support for each. made some comments/suggestions
  • w

    witty-crayon-22786

    06/21/2018, 8:09 PM
    also, would be good to think about which go in our current M1. maybe we can meet about that next week.
  • r

    rough-minister-58256

    06/21/2018, 8:43 PM
    sweet, thanks - and yeah, sounds good.
  • r

    rough-minister-58256

    06/22/2018, 12:37 AM
    gonna cut those now unless anyone has further suggestions/objections
  • r

    rough-minister-58256

    06/22/2018, 1:09 AM
    created a new label to more easily track the workstream: https://github.com/pantsbuild/pants/labels/v2%20python%20pipeline
1...546547548...906Latest