https://pantsbuild.org/ logo
Powered by
#development
  • w

    witty-crayon-22786

    06/19/2018, 4:01 PM
    @average-vr-56795: this would be the synchronous snapshot creation codepath, no?
  • w

    witty-crayon-22786

    06/19/2018, 4:01 PM
    that one doesn't use any of the ignores
  • w

    witty-crayon-22786

    06/19/2018, 4:01 PM
    or shouldn't
  • a

    average-vr-56795

    06/19/2018, 4:06 PM
    Yeah, synchronous without ignores
  • a

    average-vr-56795

    06/19/2018, 4:06 PM
    (We currently manually synchronously walk the filesystem, so doesn’t feel like a particular regression there)
  • w

    witty-crayon-22786

    06/19/2018, 4:06 PM
    ah. right. yea, sorry. yes: the answer to your question is "that sounds reasonable".
  • a

    average-vr-56795

    06/19/2018, 4:06 PM
    Fabulous, I’ll run in that direction, thanks!
  • a

    average-vr-56795

    06/19/2018, 4:08 PM
    In the mean time, I’ve updated https://github.com/pantsbuild/pants/pull/5908 and now I disappear for ~the evening 🙂
  • w

    witty-crayon-22786

    06/19/2018, 4:08 PM
    enjoy your evening!
  • w

    witty-crayon-22786

    06/19/2018, 4:22 PM
    @rough-minister-58256: i think i had one big realization with regard to your doc: commented there
  • w

    witty-crayon-22786

    06/19/2018, 4:23 PM
    we should allow forked processes to get exclusive access to the console, which would naturally interleave with suspension points in 
    @console_rules
    .
  • w

    witty-crayon-22786

    06/19/2018, 4:23 PM
    and also force them to run locally, naturally
  • h

    happy-kitchen-89482

    06/19/2018, 4:29 PM
    @witty-crayon-22786 is there a link to that design doc?
  • w

    witty-crayon-22786

    06/19/2018, 4:54 PM
    @happy-kitchen-89482: kris should be able to send it to you tomorrow... there was a bit of a mixup, and it was created as an internal doc. but i'll let him share it, because i'm not sure he intended it as more than a draft
  • a

    average-vr-56795

    06/19/2018, 5:01 PM
    @average-vr-56795 pinned a message to this channel.
  • h

    happy-kitchen-89482

    06/19/2018, 5:20 PM
    no rush
  • h

    happy-kitchen-89482

    06/19/2018, 5:20 PM
    I’m just curious about what tasks will look like in the new world
  • w

    witty-crayon-22786

    06/19/2018, 6:59 PM
    i'll paste the part that i think we have 100% agreement on so far, and let him (and encourage him to) open it up asap:
  • w

    witty-crayon-22786

    06/19/2018, 7:00 PM
    Copy code
    New @rule type: @console_rule
  Console rules:
    Do not produce a Product - and cannot be cached.
    Are invoked as coroutine generators.
    Can request and receive products during execution via `yield`.
    Can interact with (the real) console via a Select()’able `Console` object.
    Execute sequentially (no two @console_rules can execute concurrently) for unfettered console access.
  • w

    witty-crayon-22786

    06/19/2018, 7:00 PM
    the rest of the discussion is about how to do logging/output from 
    @rules
    , and how to gain streaming access to processes. he's out on vacation today, but i'm sure he'll be able to open it up tomorrow
  • a

    average-vr-56795

    06/19/2018, 10:16 PM
  • w

    witty-crayon-22786

    06/19/2018, 10:17 PM
    i believe so!
  • a

    average-vr-56795

    06/19/2018, 10:17 PM
    Hurrah! I will cut a PR and see what CI has to say
  • w

    witty-crayon-22786

    06/19/2018, 10:17 PM
    thanks!
  • a

    average-vr-56795

    06/19/2018, 10:33 PM
    Ok, API choice question… EagerFilesetWithSpec will soon have three properties: * 
    rel_root
    - the path, relative to the 
    build_root
    , to the containing directory. Typically the 
    spec_path
    . * 
    files
    - a list of file paths, relative to 
    rel_root
    . * 
    snapshot
    - a 
    Snapshot
    , which includes in it a list of file paths. Should the list of file paths in the 
    snapshot
    be the same as the 
    files
    , or the same as 
    [os.path.join(rel_root, file) for file in files]
    ?
  • w

    witty-crayon-22786

    06/19/2018, 10:34 PM
    the latter
  • a

    average-vr-56795

    06/19/2018, 10:34 PM
    ok, so 
    Snapshots
    should always be rooted at the 
    build_root
    ?
  • w

    witty-crayon-22786

    06/19/2018, 10:35 PM
    the `rel_path`/`spec_path` are almost never useful
  • w

    witty-crayon-22786

    06/19/2018, 10:35 PM
    Snapshots created from non-synthetic sources, yea
  • w

    witty-crayon-22786

    06/19/2018, 10:35 PM
    the only other potentially interesting candidate (and i don't think it's relevant here) is the "source root"
1...543544545...906Latest