rough-minister-58256
06/12/2018, 5:10 AMaloof-angle-91616
06/12/2018, 5:28 AMaloof-angle-91616
06/12/2018, 7:45 AM-X123
not being a real command, which it didn't do before my PR, and i've been trying to track down why for a while. the output is in this comment here: https://github.com/pantsbuild/pants/pull/5815#issuecomment-396424884rough-minister-58256
06/13/2018, 2:26 AMerror[E0477]: the type `futures::AndThen<futures::Join<futures::MapErr<std::boxed::Box<futures::Future<Error=std::io::Error, Item=std::vec::Vec<std::option::Option<fs::PathStat>>> + std::marker::Send>, [closure@process_execution/src/local.rs:57:42: 57:90]>, futures::MapErr<std::boxed::Box<futures::Future<Error=std::io::Error, Item=std::vec::Vec<fs::PathStat>> + std::marker::Send>, [closure@process_execution/src/local.rs:53:41: 53:88]>>, std::boxed::Box<futures::Future<Error=std::string::String, Item=fs::Snapshot> + std::marker::Send>, [closure@process_execution/src/local.rs:60:17: 75:8 self:&&local::CommandRunner, posix_fs:std::sync::Arc<fs::PosixFS>]>` does not fulfill the required lifetime
--> process_execution/src/local.rs:75:10
|
75 | }).to_boxed()
| ^^^^^^^^
|
= note: type must satisfy the static lifetime`
rough-minister-58256
06/13/2018, 2:28 AMCommandRunner
in this diff: https://gist.github.com/kwlzn/fe28eeb4779c1e865f519fcde0d0f44arough-minister-58256
06/13/2018, 2:29 AMrough-minister-58256
06/13/2018, 2:57 AM&self
to self
fixed one instance of thatrough-minister-58256
06/13/2018, 2:59 AMCompiling process_execution v0.0.1 (file:///Users/kwilson/dev/pants/src/rust/engine/process_execution)
error[E0477]: the type `futures::Map<futures::Map<futures::AndThen<futures::Map<futures::MapErr<futures::FutureResult<fs::PosixFS, std::string::String>, [closure@process_execution/src/local.rs:124:20: 129:12]>, [closure@process_execution/src/local.rs:130:16: 130:45]>, std::boxed::Box<futures::Future<Error=std::string::String, Item=fs::Snapshot> + std::marker::Send>, [closure@process_execution/src/local.rs:131:21: 133:12 self:&&local::CommandRunner, output_file_paths:std::collections::BTreeSet<std::path::PathBuf>, output_dir_paths:std::collections::BTreeSet<std::path::PathBuf>]>, [closure@process_execution/src/local.rs:135:16: 135:42 workdir:local::tempfile::TempDir]>, [closure@process_execution/src/local.rs:136:16: 136:43]>` does not fulfill the required lifetime
--> process_execution/src/local.rs:137:12
|
137 | .to_boxed()
| ^^^^^^^^
|
= note: type must satisfy the static lifetime
rough-minister-58256
06/13/2018, 2:59 AMrough-minister-58256
06/13/2018, 3:00 AMrough-minister-58256
06/13/2018, 3:54 AMfn run(
s/&self/self/
)
but I feel like there’s probably a better way that involves.. explicit lifetimes?aloof-angle-91616
06/13/2018, 3:59 AM'static
for every borrowed thing you have in themaloof-angle-91616
06/13/2018, 4:00 AMrough-minister-58256
06/13/2018, 4:00 AMaloof-angle-91616
06/13/2018, 4:00 AMaloof-angle-91616
06/13/2018, 4:01 AMaloof-angle-91616
06/13/2018, 4:02 AMaloof-angle-91616
06/13/2018, 4:03 AM&self
aloof-angle-91616
06/13/2018, 4:03 AM'static
bound needs to exist to me but i'm sure there's a good one)rough-minister-58256
06/13/2018, 4:26 AMrough-minister-58256
06/13/2018, 4:27 AMaloof-angle-91616
06/13/2018, 4:30 AMaloof-angle-91616
06/13/2018, 4:31 AMrough-minister-58256
06/13/2018, 4:32 AMrough-minister-58256
06/13/2018, 4:32 AMrough-minister-58256
06/13/2018, 4:33 AMenough-analyst-54434
06/13/2018, 4:43 AMaloof-angle-91616
06/13/2018, 4:43 AMenough-analyst-54434
06/13/2018, 4:49 AMenough-analyst-54434
06/13/2018, 4:49 AMsrc/rust/engine
as a source root.