that part I understand

but what wasnt clear to me, was the behavior that I asked in the pr (i.e. list with that option).

so thanks to you and john - its pretty clear now!

< list never shows inner nodes anyway Exactly, thats

dependencies

@salmon-summer-38098: afaict, at least two of the remaining failures relate to using the option with pantsd

so can try it out with

--enable-pantsd

locally to repro

(...and remember to kill it after code edits)

ok, signing off to go through security

have a good flight and thank you 🙂

@average-vr-56795 can you try checking out the branch

fix-xz-paths

from my remote (cosmicexplorer) and running

./pants test tests/python/pants_test/backend/python/tasks -- -k test_build_local_python_distributions

? i was going to just fix that, and i think i have -- i don't see the dyld errors repro (and the test passes now) on my osx laptop. thinking about it now, i want to expand that (otherwise very short) pr with a response to #5920, so aiming for that now. i don't think you'll need to

rm -r

anything in the pants cache to test that branch.

did the above which is now up at https://github.com/pantsbuild/pants/pull/5936

@aloof-angle-91616: From travis

[=== 19:45 Running site doc generation test ===]
+/home/travis/build/pantsbuild/pants/pants sitegen src:: examples:: contrib:: testprojects/src/java/org/pantsbuild/testproject/page:readme
WARN] Globs did not match. Excludes were: []. Unmatched globs were: ["examples/tests/scala/org/pantsbuild/example/hello/welcome/*Test.java", "examples/tests/scala/org/pantsbuild/example/hello/welcome/*Test.scala"].
WARN] Globs did not match. Excludes were: []. Unmatched globs were: ["examples/tests/python/example_test/hello/greet/*_test.py"].
WARN] Globs did not match. Excludes were: []. Unmatched globs were: ["examples/tests/scala/org/pantsbuild/example/specs2/*Test.java", "examples/tests/scala/org/pantsbuild/example/specs2/*Test.scala"].
WARN] Globs did not match. Excludes were: []. Unmatched globs were: ["examples/tests/java/org/pantsbuild/example/hello/greet/*Test.scala", "examples/tests/java/org/pantsbuild/example/hello/greet/*Spec.scala"].
WARN] Globs did not match. Excludes were: []. Unmatched globs were: ["contrib/node/examples/src/node/javascriptstyle-empty/**/*.js"].
WARN] Globs did not match. Excludes were: []. Unmatched globs were: ["contrib/avro/tests/java/org/pantsbuild/contrib/avro/*Test.scala", "contrib/avro/tests/java/org/pantsbuild/contrib/avro/*Spec.scala"].
WARN] Globs did not match. Excludes were: []. Unmatched globs were: ["contrib/thrifty/tests/java/org/pantsbuild/contrib/thrifty/*Test.scala", "contrib/thrifty/tests/java/org/pantsbuild/contrib/thrifty/*Spec.scala"].
WARN] Globs did not match. Excludes were: []. Unmatched globs were: ["contrib/python/tests/python/pants_test/contrib/python/checks/tasks/checkstyle/*_test.py"].
WARN] Globs did not match. Excludes were: []. Unmatched globs were: ["contrib/scalajs/tests/scala/org/pantsbuild/scalajs/example/factfinder/*Test.java", "contrib/scalajs/tests/scala/org/pantsbuild/scalajs/example/factfinder/*Test.scala"].
WARN] Globs did not match. Excludes were: []. Unmatched globs were: ["contrib/googlejavaformat/tests/python/pants_test/contrib/googlejavaformat/*_test.py"].
WARN] Globs did not match. Excludes were: []. Unmatched globs were: ["contrib/go/tests/python/pants_test/contrib/go/targets/*_test.py"].

Looks like you’ve revealed some issues in our repo 😄

imagine that for source :: 😱

yeah, that's actually why i think i wanted the ability to set it on a per-target basis, to accomodate switching over e.g. source. i think there should be some way to make the gradual switchover to

'warn'

easier, but i'm not sure what the interface should be

and until that exists another pr switching the default to

ignore

before the next release might be in order?

most users aren’t using

::

, so its less of a concern there - but in e.g. CI it might be nice to have a way to disable the warning globally w/ a flag?

otherwise jenkins output may get flooded

--glob-expansion-failure=ignore

, or the env var, if that's what you mean

the warnings are probably good for users to see at the scale of their target roots

ok cool

yeah, probably dropping that as config into the jenkins pants.ini is sufficient

the warnings somehow started working, i don't know when or how

and yeah that's great

and also, those warning messages need to have location info, i made a ticket -- if the warning messages work now i could look into that

@average-vr-56795 two questions: (1) would a pr fixing the warning messages for missing source globs be a useful contribution at some point? (2) i've tried

PATH='/usr/bin:/bin' ./pants clean-all test tests/python/pants_test/backend/python/tasks:python_native_code_testing

(which includes

test_build_local_python_distributions.py

), but i'm not seeing the dyld error you describe in your comments on #5936. i see why it would happen now (because we're bringing in the native toolchain unconditionally when we invoke a

python_dist()

, which is fixed in #5815), but i'm not sure how to reconcile whatever is different in our osx environments (and I assume mine is the wrong one, because i was building the

xz

binary earlier -- i have cleared

~/.cache/pants/bin/xz

but it still works)

i was able to figure out hopefully how to fix one of the FIXMEs remaining in #5815 by adding a BinaryTool for

glibc

with https://github.com/pantsbuild/pants/pull/5943 (corresponding binaries pr at https://github.com/pantsbuild/binaries/pull/70) to unskip some all the currently-skipped native backend tests (which just try to run a hello world)

@witty-crayon-22786 can you point me to where the native engine stack trace is generated, e.g. when a

@rule

results in a Throw? i'm trying to figure out how to add more context to the warning message when sources globs fail to expand and

--glob-expansion-failure=warn

moved glob matching into its own file in https://github.com/pantsbuild/pants/pull/5945 -- based off an offhand comment by @witty-crayon-22786 in the pr that added

--glob-expansion-failure

. i think it's a really neat separation of concerns

@dazzling-florist-39383 has left the channel

was thinking of merging this if that sounds like a good idea: https://github.com/pantsbuild/pants/pull/5945