https://pantsbuild.org/ logo
Powered by
#development
  • w

    witty-crayon-22786

    06/07/2018, 10:55 PM
    if something else that is not filtered out depends on it (ie some other root), it must still be included
  • w

    witty-crayon-22786

    06/07/2018, 10:56 PM
    i think the confusion might be because "roots" here don't necessarily mean "roots of the graph", they simply mean roots of the graph walk
  • e

    enough-analyst-54434

    06/07/2018, 10:57 PM
    In the example there is no graph, just the fs tree
  • e

    enough-analyst-54434

    06/07/2018, 10:57 PM
    its a list prefix::
  • w

    witty-crayon-22786

    06/07/2018, 10:57 PM
    @enough-analyst-54434: i mean, sortof. why call them roots though?
  • w

    witty-crayon-22786

    06/07/2018, 10:57 PM
    they're the roots of the graph walk representing the final context
  • e

    enough-analyst-54434

    06/07/2018, 10:57 PM
    There is no graph walk
  • e

    enough-analyst-54434

    06/07/2018, 10:57 PM
    list just lists roots
  • e

    enough-analyst-54434

    06/07/2018, 10:58 PM
    unlike most other tsaks
  • w

    witty-crayon-22786

    06/07/2018, 10:58 PM
    this is not list specific
  • w

    witty-crayon-22786

    06/07/2018, 10:58 PM
    neither the option, nor the topic
  • e

    enough-analyst-54434

    06/07/2018, 10:58 PM
    The example and the question on the PR was
  • e

    enough-analyst-54434

    06/07/2018, 10:58 PM
    That is what is confusing
  • e

    enough-analyst-54434

    06/07/2018, 10:58 PM
    that example, Ity's question and your response
  • w

    witty-crayon-22786

    06/07/2018, 10:58 PM
    yea, probably
  • w

    witty-crayon-22786

    06/07/2018, 10:59 PM
    @salmon-summer-38098: ok, so.
  • s

    salmon-summer-38098

    06/07/2018, 11:00 PM
    yeah thats whats causing the disparity in understanding. for something like 
    list src/java/org/pantsbuild/tools::
    any target would be applied for that option (since they are all roots in this case)
  • s

    salmon-summer-38098

    06/07/2018, 11:00 PM
    ^ does that sound right @witty-crayon-22786
  • w

    witty-crayon-22786

    06/07/2018, 11:00 PM
    yes
  • s

    salmon-summer-38098

    06/07/2018, 11:00 PM
    if I changed the example to:
  • e

    enough-analyst-54434

    06/07/2018, 11:00 PM
    Cool
  • w

    witty-crayon-22786

    06/07/2018, 11:00 PM
    for list, yes.
  • e

    enough-analyst-54434

    06/07/2018, 11:00 PM
    convergence
  • s

    salmon-summer-38098

    06/07/2018, 11:00 PM
    list src/java/org/pantsbuild/tools:junit
  • s

    salmon-summer-38098

    06/07/2018, 11:01 PM
    ^ then the root is obvious
  • s

    salmon-summer-38098

    06/07/2018, 11:01 PM
    its from cli directly
  • w

    witty-crayon-22786

    06/07/2018, 11:01 PM
    sure
  • w

    witty-crayon-22786

    06/07/2018, 11:02 PM
    so yea... the thing it took me too long to understand about john's point is that list never shows inner nodes anyway
  • s

    salmon-summer-38098

    06/07/2018, 11:02 PM
    yes
  • w

    witty-crayon-22786

    06/07/2018, 11:03 PM
    regardless: applying the filtering in that method is the correct place
1...514515516...906Latest