Ergonomic, hermetic, user-friendly software build system for Python, Go, Java, Kotlin, Protobuf, Scala, Shell. Pants lets you fearlessly scale up your codebase!

Pants

The `From` stuff is coolest for error types with the `?` operator:

```
fn do_something() -&gt; Result&lt;String, String&gt; {
  Err("foo".to_owned())
}

fn foo() -&gt; Result&lt;String, MyError&gt; {
  do_something()?
}
```

will Just Work with no `.into()` call because the `?` operator will automatically call `.into()` if needed

In basically every place that I manually write `.into()`, I’m slightly torn about whether I like its implicit magic, or whether I want to be more explicit.

There are also times where I need to explicitly define a variable with an ascribed type (`let foo: hashing::Digest = bar.into()`) because the inference can’t work out what type should be `into`’d to without that, which makes me sad

can someone merge <https://github.com/pantsbuild/pants/pull/5769>? i had to rebase it and it works now but since there's rust changes it might be neat to merge it now. i can totally make followup tickets on any further comments anyone has!

Ooh yeah, I’ve had that on my list to look at, I’ll take a look too :slightly_smiling_face:

(if there's more work needed i actually don't care if i need to rebase again)

(ooh, the diff to `fs/src/lib.rs` is small enough now that it doesn't autocollapse!)

everything turned out better than expected dot jay peg

(Left a handful of pretty simple comments to follow up on :slightly_smiling_face:)

i wonder if moving execution of rules into eval with a symbol blacklist would be a good incremental step toward using a rust skylark implementation.

...that wouldn't do anything for transitively used modules though.

Who’s interested in a Python multi-process mystery? :smile:

<https://github.com/pantsbuild/pants/pull/5893> holds my mystery (<@U054MQUPL>)

(<@U04S45AHA> I see you’re online… Any ideas? ^^)

<@U6YPB4SJX> think you're hitting this test base class code: <https://github.com/pantsbuild/pants/blob/master/tests/python/pants_test/pants_run_integration_test.py#L224>

Lower down another self.hermetic check guards env

This isn’t a test issue; this happens not in tests too

Specifically it’s src/python/pants/java/executor.py’s _spawn function which is causing the problem

It happens for zinc compiles, for ivy resolves, for the `run` goal for a jvm target

So nailgun protocol supports passing environment, it does not set the environment though for java