https://pantsbuild.org/ logo
Powered by
#development
  • a

    aloof-angle-91616

    05/24/2018, 5:04 AM
    [citation needed]
  • a

    aloof-angle-91616

    05/24/2018, 5:05 AM
    bumping ulimit sounds good, making rust tests less flaky is gr9
  • w

    witty-crayon-22786

    05/24/2018, 5:10 AM
    đź‘Ť
  • r

    rough-minister-58256

    05/24/2018, 5:31 PM
    what are the current and/or future restrictions and/or guidelines on fs access in @rules?
  • w

    witty-crayon-22786

    05/24/2018, 5:55 PM
    @rough-minister-58256: "don't do it"
  • r

    rough-minister-58256

    05/24/2018, 5:55 PM
    heh ok
  • w

    witty-crayon-22786

    05/24/2018, 5:55 PM
    but, one glaring issue with that is that we don't have an API to get files that are located outside of the build_root
  • w

    witty-crayon-22786

    05/24/2018, 5:56 PM
    for anything under the buildroot, you can do basically 
    yield Get(FileContents, PathGlobs(['pants.ini'], []))
  • r

    rough-minister-58256

    05/24/2018, 5:58 PM
    ah, splendid
  • w

    witty-crayon-22786

    05/24/2018, 5:58 PM
    including files from outside the buildroot in the graph is challenging because of watchman and etc
  • w

    witty-crayon-22786

    05/24/2018, 5:58 PM
    basically, we'd have to have a "pollable" file type or something.
  • r

    rough-minister-58256

    05/24/2018, 5:58 PM
    yeah
  • w

    witty-crayon-22786

    05/24/2018, 5:59 PM
    until then, slurping in the files you want to inspect and making them part of the ParseOptionsRequest could work (depending on whether it's recursive)
  • w

    witty-crayon-22786

    05/24/2018, 6:00 PM
    (
    pants.rc
    files might be interesting there..)
  • w

    witty-crayon-22786

    05/24/2018, 6:00 PM
    ...but they're part of the bootstrap options, right?
  • r

    rough-minister-58256

    05/24/2018, 6:01 PM
    slurp in how?
  • w

    witty-crayon-22786

    05/24/2018, 6:01 PM
    during bootstrap, just read them in after locating them
  • r

    rough-minister-58256

    05/24/2018, 6:02 PM
    ah, k
  • w

    witty-crayon-22786

    05/24/2018, 6:02 PM
    so basically, create the 
    ParseOptionsRequest
    with the contents of all pants.ini/rc files
  • r

    rough-minister-58256

    05/24/2018, 6:02 PM
    ah I see what you mean
  • r

    rough-minister-58256

    05/24/2018, 6:02 PM
    yeah
  • r

    rough-minister-58256

    05/24/2018, 6:02 PM
    rgr
  • l

    limited-country-20626

    05/24/2018, 8:50 PM
    I deploy a plist file to bump the ulimit to OSX
  • l

    limited-country-20626

    05/24/2018, 8:51 PM
    the only way we could ever figure out that wouldn’t reset on boot
  • r

    rough-minister-58256

    05/24/2018, 10:08 PM
    are there any type constraints for 
    @rule
    return `Product`s? do those have to be 
    datatype
    ? or can it be any old object instance?
  • w

    witty-crayon-22786

    05/24/2018, 10:11 PM
    @rough-minister-58256: any old object instance. but should be cautious about mutability.
  • w

    witty-crayon-22786

    05/24/2018, 10:12 PM
    (cautious in that it's memoization all the way down, so using anything mutable in rules is scary)
  • r

    rough-minister-58256

    05/24/2018, 10:13 PM
    rgr, makes sense
  • w

    witty-crayon-22786

    05/24/2018, 10:13 PM
    (mutable / not referentially transparent, to be more accurate)
  • r

    rough-minister-58256

    05/24/2018, 10:16 PM
    do they need to be hashable?
1...502503504...906Latest