pantsbuild #development

ok, that makes sense -- are we not able to assume that the store would throw an error if the write is not successful (in the sense of "would be reachable if you tried to load from the store after it returns")?

aloof-angle-91616

05/22/2018, 12:54 AM

if this is an arbitrary store it seems like the round trip is potentially nontrivial latency

rough-minister-58256

05/22/2018, 12:54 AM

no, that’s a reasonable assumption I think

rough-minister-58256

05/22/2018, 12:55 AM

but we already fetch from the store in most cases afaict

aloof-angle-91616

05/22/2018, 12:56 AM

right, but what if stdout is huge? is there something i'm missing?

rough-minister-58256

05/22/2018, 12:57 AM

could be

aloof-angle-91616

05/22/2018, 12:57 AM

like it seems easier to me to clone the bytes like to write the code for so i'm not sure i see what we get from the round trip

rough-minister-58256

05/22/2018, 12:57 AM

(I wasn’t at the optimization phase yet ;))

aloof-angle-91616

05/22/2018, 12:57 AM

ok, sorry

aloof-angle-91616

05/22/2018, 12:58 AM

was asking cause i wanted to know if this was some intuition i was missing

aloof-angle-91616

05/22/2018, 12:58 AM

thanks

rough-minister-58256

05/22/2018, 1:00 AM

👍

rough-minister-58256

05/22/2018, 1:45 AM

for e.g. a

BoxFuture<Bytes, ExecutionError>

type def what’s the formal term for the

<SomeConcreteType, SomeOther>

bit? just “type parameters”? inferring that because I think e.g.

<T, A>

form are called “generic type parameters”?

aloof-angle-91616

05/22/2018, 1:51 AM

hm, i think "type parameters" sounds right

rough-minister-58256

05/22/2018, 1:55 AM

would think all of this would be formally defined somewhere

rough-minister-58256

05/22/2018, 1:56 AM

if not in rust in general maybe

witty-crayon-22786

05/22/2018, 2:07 AM

generic type parameters, yea

witty-crayon-22786

05/22/2018, 2:08 AM

or just type parameters.

witty-crayon-22786

05/22/2018, 2:08 AM

you'd say that

BoxFuture

is generic, and those are its parameters

witty-crayon-22786

05/22/2018, 2:08 AM

ok, logging off for real

aloof-angle-91616

05/22/2018, 3:15 AM

i don't need the

externs::store_dict()

method anymore but it seems useful

aloof-angle-91616

05/22/2018, 3:15 AM

guess i'll just keep it in mind if i need to do that in the future

average-vr-56795

05/22/2018, 10:14 AM

@rough-minister-58256 For weird reasons that I still don’t understand, there are actually two different things that look like `Type<Other>`: On a struct they’re called generic type parameters. Their existence is defined:

Copy code

struct S<Param> {
  field: Param,
}

and they’re used

fn foo() -> S<String>

. On a trait, they’re called associated types, and they have names. They’re defined:

Copy code

trait T {
  type Param;
}

and they’re used:

fn foo() -> T<Param=String>

👍 1

aloof-angle-91616

05/22/2018, 11:25 AM

is there something special i have to do to make

warn!()

show up when called from

<http://nodes.rs|nodes.rs>

? because

eprintln!()

is working just fine, but nothing shows up when i try to run

warn!()

error!()

(and i'm sure i'm editing the right file etc)

aloof-angle-91616

05/22/2018, 11:41 AM

looked in

.pants.d/logs

, and only found an error message from a few hours ago

average-vr-56795

05/22/2018, 12:45 PM

@aloof-angle-91616 Are you using the daemon?

average-vr-56795

05/22/2018, 2:25 PM

@witty-crayon-22786 I’m looking at killing `LazyFilesetWithSpec`… It looks like it’s only really used for things which have a

source

field instead of a

sources

field. Any objection to just shoving that pattern into v2 parsing?

average-vr-56795

05/22/2018, 3:17 PM

https://github.com/pantsbuild/pants/pull/5858/files << proof of concept

average-vr-56795

05/22/2018, 4:17 PM

Am I right in thinking that pants always uses the v2 scheduler now, and that we just have a bunch of tests which don’t set one up?