pantsbuild #development

Channels

welcome

github-notifications

development

witty-crayon-22786

04/13/2018, 3:31 AM

the TODO there is because the binary isn't "in" the Snapshot... it's outside. which we of course need to ban at some point, but anyway

witty-crayon-22786

04/13/2018, 3:32 AM

but

snapshot.files

snapshot.dirs

are the relative names of the files or dirs matched by the snapshot

witty-crayon-22786

04/13/2018, 3:32 AM

and when the snapshot is extracted in the working dir of the process, they will be at the same "relative" path

witty-crayon-22786

04/13/2018, 3:33 AM

src/scala/com/twitter/Example.scala

witty-crayon-22786

04/13/2018, 3:33 AM

<buildroot>/src/scala/com/twitter/Example.scala

src/scala/com/twitter/Example.scala

aloof-angle-91616

04/13/2018, 3:34 AM

yeah, it's not necessary right now so i'm going to drop it but i was recreating the directory structure of the source files in an output directory so the object files would be at the same relative paths which isn't something i need to do

witty-crayon-22786

04/13/2018, 3:35 AM

until we have the snapshot manipulation API... there isn't much you can do to reorganize things

aloof-angle-91616

04/13/2018, 3:36 AM

i have the ticket open in the next tab i was gonna make a snapshot manipulation API that worked for my needs then slim it down and make it mergeable

aloof-angle-91616

04/13/2018, 3:36 AM

not as a "i will be angry if it's not merged" but just because it seemed cool

aloof-angle-91616

04/13/2018, 3:39 AM

ok, actually eating food now

witty-crayon-22786

04/13/2018, 3:48 AM

also, you know that you can't currently capture process output files, right...?

witty-crayon-22786

04/13/2018, 5:49 AM

only lightly hacky dependency inference demo: https://github.com/pantsbuild/pants/compare/master...twitter:stuhood/dep-inference-demo

average-vr-56795

04/13/2018, 5:50 AM

And I was just about to go to sleep!

witty-crayon-22786

04/13/2018, 5:51 AM

won't take long to read, heh

witty-crayon-22786

04/13/2018, 5:52 AM

...and i'll be trying to talk about it tomorrow anyway... get some sleep!

average-vr-56795

04/13/2018, 5:54 AM

Looks very nice 🙂 Hacky, of course, but nice!

average-vr-56795

04/13/2018, 5:55 AM

I kind of want `Get`s to use named args, because I’m never going to remember what order things go in

witty-crayon-22786

04/13/2018, 5:57 AM

yea, reasonable(ish)

witty-crayon-22786

04/13/2018, 9:43 PM

cute

happy-kitchen-89482

04/13/2018, 11:19 PM

Neat

aloof-angle-91616

04/14/2018, 7:22 PM

slide deck of the century imo

aloof-angle-91616

04/14/2018, 7:24 PM

@average-vr-56795 could you clarify what you mean by "remote the explicit PathGlobs calls" -- what does "remote the call" mean in this context? (in this comment: https://github.com/pantsbuild/pants/issues/5502#issuecomment-376569010)

aloof-angle-91616

04/14/2018, 8:04 PM

is there a particular reason ExecuteProcessRequest has

input_files_digest

and

digest_length

fields instead of just a

snapshot

witty-crayon-22786

04/14/2018, 11:05 PM

history

aloof-angle-91616

04/15/2018, 5:48 AM

played around with `ExecuteProcessRequest`s and converted some stuff to `@rule`s which was previously in this

ExecuteProcess

helper which was way confusing to me and couldn't use `Get`s https://github.com/pantsbuild/pants/pull/5703

aloof-angle-91616

04/15/2018, 6:55 AM

was trying to go above and beyond and got stumped, left a comment on the above about rust code https://github.com/pantsbuild/pants/pull/5703#issuecomment-381384226

average-vr-56795

04/16/2018, 10:13 AM

@gorgeous-alligator-94763 I started pulling out testdata structs in https://github.com/pantsbuild/pants/pull/5705/files#diff-90f1a2457726e7aaaab45299a7d486ad (example usage in https://github.com/pantsbuild/pants/pull/5705/files#diff-db925a83e648a68f6ac9b0b8d530cc06R705 ) - is that more clear than the whole `bytes()`/`digest()`/… convention? 🙂

aloof-angle-91616

04/16/2018, 4:19 PM

i find the rust fuse API extremely superior to the one provided by libfuse, it had just been a while since i’d had to remember what an inode was. if we could build a higher level API on top of it it seems they might love to accept that upstream

average-vr-56795

04/16/2018, 4:22 PM

Yeah, the fuse-mt stuff is pretty nice, except for the whole async-hostile part 😞

average-vr-56795

04/16/2018, 4:23 PM

I could certainly see extracting a common “manage inodes for you” layer