https://pantsbuild.org/ logo
Powered by
#development
  • w

    witty-crayon-22786

    02/26/2018, 5:54 PM
    https://github.com/pantsbuild/pants/pull/5521 is now actually reviewable, sorry
  • r

    rough-minister-58256

    02/28/2018, 1:34 AM
    seems like there’s a pretty big existing gap for 
    time
    vs runtrack’d main cumulative timing even w/o the daemon
  • r

    rough-minister-58256

    02/28/2018, 1:34 AM
    Copy code
    real	0m2.672s
user	0m1.159s
sys	0m0.660s
vs
    "cumulative_timings": [
        {
            "is_tool": false,
            "label": "main",
            "timing": 0.8152689933776855
        },
  • r

    rough-minister-58256

    02/28/2018, 1:35 AM
    guess thats just outer bash
  • r

    rough-minister-58256

    02/28/2018, 1:36 AM
    it occurred to me to get true runtimes we’ll have to capture time on the client side and send that over in an env var
  • a

    average-vr-56795

    02/28/2018, 8:48 AM
    Wow, what’s it doing for two seconds??
  • r

    rough-minister-58256

    02/28/2018, 5:00 PM
    good question
  • g

    gifted-autumn-88099

    02/28/2018, 5:18 PM
    Is centos6 the "reference" distro for building pants on linux? I'm having some rust build issues with ubuntu 16.04 and want to get a a dockerized build going. Looking at the Dockerfile's in the repo, it looks like CI runs on a customized centos6 base, which made me think that's the reference platform.
  • a

    average-vr-56795

    02/28/2018, 5:20 PM
    Yeah, we have CI to ensure that centos6 works
  • a

    average-vr-56795

    02/28/2018, 5:20 PM
    Anything else is best effort 🙂
    🙇‍♂️ 1
  • g

    gifted-autumn-88099

    02/28/2018, 6:05 PM
  • g

    gifted-autumn-88099

    02/28/2018, 6:06 PM
    That's using 
    scl
    to enable a newer toolchain, but I'm seeing issues where 
    /usr/bin/c++
    is specifically being used, rather than just 
    c++
    which 
    scl
    puts on the path.
  • r

    rough-minister-58256

    02/28/2018, 6:08 PM
    yeah, that’s the image we use for all external pants release builds iirc
  • r

    rough-minister-58256

    02/28/2018, 6:09 PM
    don’t think we’ve ever seen any problematic env leaks from the 
    scl
    configuration that I can recall
    🤔 1
  • g

    gifted-autumn-88099

    02/28/2018, 6:24 PM
    Looks like this was cruft in 
    ~/.cache/pants
    from an earlier build. I reinitialized things and it's working now. In case folks are interested, here's a 
    Makefile
    that automates building/starting a container for pants development: https://github.com/traviscrawford/dockerfiles/blob/master/pantsbuild/Makefile
  • r

    rough-minister-58256

    02/28/2018, 7:38 PM
    I think the mode we use those docker images in is typically a single 
    docker run ... <cmd>
    , so generally caches like that wouldn’t survive run over run
  • r

    rough-minister-58256

    02/28/2018, 7:40 PM
    but if you can reliably repro, might be good to file a ticket for the general case
  • g

    gifted-autumn-88099

    02/28/2018, 8:13 PM
    My use-case is doing development on a non-Centos6 distro, and I was getting rust build errors. So I’m using the centos6 docker image to run pants, and I bind mount the sources into the container. I also mount a volume to 
    ~/.cache/pants
    so it doesn’t need to rebuild the world every time the container starts. After wiping the cache volume I haven’t seen the issue reoccur.
  • r

    rough-minister-58256

    02/28/2018, 9:30 PM
    ah, makes sense
  • r

    rough-minister-58256

    02/28/2018, 10:53 PM
  • r

    rough-minister-58256

    02/28/2018, 10:53 PM
    looks like the “Please” build system guys rewrote skylark in Go?
  • r

    rough-minister-58256

    02/28/2018, 10:54 PM
    not sure if this was the same one mentioned around bazelcon timeframe
  • r

    rough-minister-58256

    02/28/2018, 11:11 PM
    @witty-crayon-22786 any last words on https://github.com/pantsbuild/pants/pull/5526 ?
  • w

    witty-crayon-22786

    02/28/2018, 11:26 PM
    sorry, looking
  • w

    witty-crayon-22786

    02/28/2018, 11:27 PM
    @rough-minister-58256: looks good, thanks
  • r

    rough-minister-58256

    02/28/2018, 11:27 PM
    word
  • a

    average-vr-56795

    03/01/2018, 11:27 AM
    @rough-minister-58256 That’s a fork of the Google one
  • r

    rough-minister-58256

    03/01/2018, 5:42 PM
    ah, oops - didn’t realize google/skylark was in Go
  • w

    witty-crayon-22786

    03/03/2018, 9:43 PM
    @rough-minister-58256: there are two google impls; one is java and is used in bazel, and the other is in go
    r
    • 2
    • 1
  • w

    witty-crayon-22786

    03/03/2018, 9:43 PM
    @average-vr-56795: so https://github.com/pantsbuild/pants/issues/4769#issuecomment-370181952 looks very feasible, and i think can definitely be accomplished in time to unblock the release.
1...452453454...906Latest