https://pantsbuild.org/ logo
Powered by
#development
  • w

    witty-crayon-22786

    03/07/2016, 11:14 PM
    ...sounds like this review is getting pretty large 😃
  • w

    witty-crayon-22786

    03/07/2016, 11:15 PM
    @full-kilobyte-93429: what did you add that is causing PythonRequirement to be hashed?
  • f

    full-kilobyte-93429

    03/07/2016, 11:15 PM
    not really
  • f

    full-kilobyte-93429

    03/07/2016, 11:15 PM
    ./pants  run src/python/pants/engine/exp/legacy:dependencies -- 3rdparty/python:
    will break by adding caching
  • f

    full-kilobyte-93429

    03/07/2016, 11:16 PM
    or without cache change from local serial engine to multiprocess engine
  • w

    witty-crayon-22786

    03/07/2016, 11:16 PM
    ah
  • f

    full-kilobyte-93429

    03/07/2016, 11:16 PM
    will also break
  • w

    witty-crayon-22786

    03/07/2016, 11:16 PM
    yep, gotcha
  • w

    witty-crayon-22786

    03/07/2016, 11:16 PM
    yea, that's worth fixing.
  • b

    bored-art-40741

    03/07/2016, 11:22 PM
    @full-kilobyte-93429: I meant interpreters, not platforms, yeah
  • b

    bored-art-40741

    03/07/2016, 11:22 PM
    There's already a spec for expressing version constraints as lists of strings
  • b

    bored-art-40741

    03/07/2016, 11:22 PM
    No need to reinvent the... wheel
  • f

    full-kilobyte-93429

    03/07/2016, 11:22 PM
    oh, what spec is this?
  • f

    full-kilobyte-93429

    03/07/2016, 11:24 PM
    @bored-art-40741: ^^
  • r

    rough-minister-58256

    03/07/2016, 11:24 PM
    interpreter_requirement
    ?
  • r

    rough-minister-58256

    03/07/2016, 11:25 PM
    Copy code
    [python-setup]
interpreter_requirement: CPython>=2.7,<3
  • f

    full-kilobyte-93429

    03/07/2016, 11:25 PM
    as part of python_requirement?
  • b

    bored-art-40741

    03/07/2016, 11:25 PM
  • b

    bored-art-40741

    03/07/2016, 11:26 PM
    That might be overkill
  • b

    bored-art-40741

    03/07/2016, 11:26 PM
    Probably https://www.python.org/dev/peps/pep-0427/ is closer to what you want
  • b

    bored-art-40741

    03/07/2016, 11:26 PM
    I believe the wheel package has a parser for it
  • b

    bored-art-40741

    03/07/2016, 11:27 PM
    Pex too likely
  • f

    full-kilobyte-93429

    03/07/2016, 11:31 PM
    i see,
    Copy code
    language implementation and version tag
E.g. 'py27', 'py2', 'py3'.
  • f

    full-kilobyte-93429

    03/07/2016, 11:31 PM
    let me look at its api doc
  • b

    bored-art-40741

    03/07/2016, 11:33 PM
    interpreter_requirement
    is definitely what I was referring to in terms of what we already have in pants
  • b

    bored-art-40741

    03/07/2016, 11:33 PM
    Might not need to go down the rabbit hole of the peps and such
  • w

    witty-crayon-22786

    03/07/2016, 11:35 PM
    @full-kilobyte-93429: he's just saying that you can encode/parse the version in a particular way
  • w

    witty-crayon-22786

    03/07/2016, 11:35 PM
    ...to be clear
  • w

    witty-crayon-22786

    03/07/2016, 11:36 PM
    argh, of course. wickman wrote that.
  • w

    witty-crayon-22786

    03/07/2016, 11:37 PM
    the file where we apply those version filters is here: src/python/pants/backend/python/interpreter_cache.py
1...444546...906Latest