https://pantsbuild.org/ logo
Powered by
#development
  • r

    rough-minister-58256

    12/12/2017, 7:25 PM
    entire run of what
  • w

    witty-crayon-22786

    12/12/2017, 7:25 PM
    a pailgun run
  • r

    rough-minister-58256

    12/12/2017, 7:25 PM
    only for the fork
  • w

    witty-crayon-22786

    12/12/2017, 7:26 PM
    but that doesn't protect against the services being shutdown in the middle
  • r

    rough-minister-58256

    12/12/2017, 7:26 PM
    ah right
  • w

    witty-crayon-22786

    12/12/2017, 7:26 PM
    so, yea... i think these are separate locks, with very specific purposes
  • w

    witty-crayon-22786

    12/12/2017, 7:26 PM
    which we should document
  • w

    witty-crayon-22786

    12/12/2017, 7:27 PM
    and i'm fine with adding back the service lifecycle lock...i'm also fine with not adding it, and saying that if a service crashes in the middle of a run, we have undefined behaviour.
  • w

    witty-crayon-22786

    12/12/2017, 7:27 PM
    either way.
  • w

    witty-crayon-22786

    12/12/2017, 7:27 PM
    i don't know how bad/frequent that failure mode is.
  • r

    rough-minister-58256

    12/12/2017, 7:28 PM
    I see. makes more sense if you plan to extend that locking to the entire sync pailgun run
  • w

    witty-crayon-22786

    12/12/2017, 7:28 PM
    well, that's why you said it exists, right?
  • w

    witty-crayon-22786

    12/12/2017, 7:28 PM
    (or, one of the reasons)
  • w

    witty-crayon-22786

    12/12/2017, 7:28 PM
    ...so basically, it used to be around the entire run, for two reasons
  • w

    witty-crayon-22786

    12/12/2017, 7:29 PM
    1) the fork, 2) the service lifecycle thing
  • r

    rough-minister-58256

    12/12/2017, 7:29 PM
    yeah
  • w

    witty-crayon-22786

    12/12/2017, 7:29 PM
    and 3) it was acquired for the scheduler
  • w

    witty-crayon-22786

    12/12/2017, 7:29 PM
    i removed 3
  • r

    rough-minister-58256

    12/12/2017, 7:30 PM
    afaik, we need 3
  • w

    witty-crayon-22786

    12/12/2017, 7:30 PM
    if we can remove 2 without ill effects on error messages, that would be nice too
  • w

    witty-crayon-22786

    12/12/2017, 7:30 PM
    @rough-minister-58256: that's what i already removed
  • r

    rough-minister-58256

    12/12/2017, 7:30 PM
    er, unless you mean in the split
  • w

    witty-crayon-22786

    12/12/2017, 7:30 PM
    in the previous scheduler lock removal thing
  • w

    witty-crayon-22786

    12/12/2017, 7:30 PM
    (iirc, these were all the same lock passed around before)
  • r

    rough-minister-58256

    12/12/2017, 7:30 PM
    ah, I readded that in my PR
  • w

    witty-crayon-22786

    12/12/2017, 7:31 PM
    ...oh.
  • w

    witty-crayon-22786

    12/12/2017, 7:31 PM
    shame on me for not reading more carefully.
  • r

    rough-minister-58256

    12/12/2017, 7:31 PM
    but yeah with a split lock strategy all makes sense
  • w

    witty-crayon-22786

    12/12/2017, 7:31 PM
    but yea, i believe it can be removed.
  • r

    rough-minister-58256

    12/12/2017, 7:31 PM
    hm?
1...405406407...906Latest