https://pantsbuild.org/ logo
Powered by
#development
  • a

    average-vr-56795

    12/08/2017, 9:33 PM
    Why isn't a collection of PathStats the unit of processes?
  • w

    witty-crayon-22786

    12/08/2017, 9:33 PM
    that sounds like more of a "why are Directories a thing" question
  • w

    witty-crayon-22786

    12/08/2017, 9:34 PM
    because if PathStats were the unit, I'd still wrap them up in a datatype probably (edit: and call it a Snapshot)
  • w

    witty-crayon-22786

    12/08/2017, 9:34 PM
    (pathstats + digests)
  • a

    average-vr-56795

    12/08/2017, 9:35 PM
    And that data type wouldn't be a set?
  • a

    average-vr-56795

    12/08/2017, 9:35 PM
    A PathStat contains a digest
  • w

    witty-crayon-22786

    12/08/2017, 9:35 PM
    eh?
  • w

    witty-crayon-22786

    12/08/2017, 9:35 PM
    hm... if it did, i guess.
  • w

    witty-crayon-22786

    12/08/2017, 9:36 PM
    although that would have odd behaviour because it would be a set by path name, with the digest floating elsewhere. otherwise you might have multiple colliding pathstats in one snapshot
  • w

    witty-crayon-22786

    12/08/2017, 9:36 PM
    anyway... Directory exists.
  • a

    average-vr-56795

    12/08/2017, 9:36 PM
    Oh, right, yeah, I didn't do that
  • w

    witty-crayon-22786

    12/08/2017, 9:36 PM
    brb... meeting.
  • w

    witty-crayon-22786

    12/08/2017, 9:36 PM
    ~20 mins
  • a

    average-vr-56795

    12/08/2017, 9:36 PM
    Ok :)
  • a

    average-vr-56795

    12/08/2017, 9:59 PM
    I guess my uncertainty comes from not having a good feel for the use cases. I can imagine wanting to pass a snapshot to a process execution. I can imagine wanting to read a file by digest. I can't really imagine wanting a list of file contents.
  • a

    average-vr-56795

    12/08/2017, 10:00 PM
    Maybe I just lack imagination, though
  • w

    witty-crayon-22786

    12/08/2017, 10:04 PM
    back
  • w

    witty-crayon-22786

    12/08/2017, 10:04 PM
    @average-vr-56795: the file contents are used for BUILD file parsing
  • w

    witty-crayon-22786

    12/08/2017, 10:04 PM
    and basically nowhere else
    • 1
    • 1
  • w

    witty-crayon-22786

    12/08/2017, 10:06 PM
    and yea, that's a situation where given a large Snapshot, we want to group by directory and then parse the batch of files contained in each directory.
  • w

    witty-crayon-22786

    12/08/2017, 10:07 PM
    i'd be totally fine with moving to a 
    PathStat,Digest->FileContent
    model, since it is now cheap. why not.
  • w

    witty-crayon-22786

    12/08/2017, 10:07 PM
    (the "why not" might be that you need both a PathStat and a Digest to get a FileContent with a name, afaik)
  • w

    witty-crayon-22786

    12/08/2017, 10:08 PM
    ...well, no. you could zip it together in the requester.
  • w

    witty-crayon-22786

    12/08/2017, 10:09 PM
    so yea. 
    Digest->FileContent
    makes sense, regardless of what we do Snapshot-composition wise.
  • s

    salmon-summer-38098

    12/08/2017, 10:09 PM
    @average-vr-56795 sorry, just saw my mention (was at lunch). in an interview right now. will respond as soon as i am back to desk
  • a

    average-vr-56795

    12/08/2017, 10:10 PM
    Cool 🙂
  • w

    witty-crayon-22786

    12/08/2017, 10:13 PM
    could someone who isn't using their pants workspace try checking out 185567f and building it?
  • w

    witty-crayon-22786

    12/08/2017, 10:13 PM
    i'm seeing something disturbing reproducibility wise... like Cargo.lock isn't being applied. sigh.
  • r

    rough-minister-58256

    12/08/2017, 10:16 PM
    trying
  • a

    average-vr-56795

    12/08/2017, 10:33 PM
    @witty-crayon-22786 is your problem about references to proto messages?
1...395396397...906Latest