https://pantsbuild.org/ logo
Powered by
#development
  • w

    witty-crayon-22786

    11/08/2017, 11:44 PM
  • a

    average-vr-56795

    11/08/2017, 11:46 PM
    Ooh fancy, thanks!
  • a

    average-vr-56795

    11/08/2017, 11:47 PM
    So why is it an impl for Arc<PosixFS> not just PosixFS?
  • w

    witty-crayon-22786

    11/08/2017, 11:52 PM
    @average-vr-56795: um. because i think that's what you'll want as a consumer
  • w

    witty-crayon-22786

    11/08/2017, 11:53 PM
    iirc we ran into a case where i suggested actually adding a method on an impl rather than making it static
  • w

    witty-crayon-22786

    11/08/2017, 11:53 PM
    but you couldn't because you needed an Arc of self instead... and that's what this does
  • w

    witty-crayon-22786

    11/08/2017, 11:53 PM
    (but maybe not... hm.)
  • w

    witty-crayon-22786

    11/08/2017, 11:54 PM
    the problem with adding unused code.
  • w

    witty-crayon-22786

    11/08/2017, 11:54 PM
    @average-vr-56795: no need to actually land this. can just copy it into whatever you're working on
  • a

    average-vr-56795

    11/08/2017, 11:56 PM
    Cool, will do 🙂
  • a

    average-vr-56795

    11/08/2017, 11:57 PM
    @witty-crayon-22786 Any thoughts on https://github.com/pantsbuild/pants/pull/5066 ?
  • a

    average-vr-56795

    11/08/2017, 11:58 PM
    I'm uncertain as to whether the first or second commit is more clear
  • a

    average-vr-56795

    11/08/2017, 11:58 PM
  • a

    average-vr-56795

    11/09/2017, 1:34 AM
    @witty-crayon-22786 ^^
  • w

    witty-crayon-22786

    11/09/2017, 1:35 AM
    whoops, sorry.
  • w

    witty-crayon-22786

    11/09/2017, 1:35 AM
    @average-vr-56795: also, re: your earlier question: https://github.com/pantsbuild/pants/pull/5079#discussion_r149847022
  • a

    average-vr-56795

    11/09/2017, 1:36 AM
    Handy 🙂 Thanks!
  • w

    witty-crayon-22786

    11/09/2017, 1:36 AM
    @average-vr-56795: methods that take two closures... awkward?
  • w

    witty-crayon-22786

    11/09/2017, 1:37 AM
    ...but.
  • w

    witty-crayon-22786

    11/09/2017, 1:37 AM
    looking at it again, 
    Ok(Some(v))
    is suspect
  • w

    witty-crayon-22786

    11/09/2017, 1:37 AM
    is this 
    ok_or_else
    again?
  • w

    witty-crayon-22786

    11/09/2017, 1:38 AM
    between the two, i prefer the first. but i think there might be a better (combination of) closure(s) to use
  • a

    average-vr-56795

    11/09/2017, 1:39 AM
    Sadly not an 
    ok_or_else
    ...
  • a

    average-vr-56795

    11/09/2017, 1:40 AM
    Because it's trying to map the None into a Result which may be an Ok
  • a

    average-vr-56795

    11/09/2017, 1:41 AM
    And it doesn't want to unwrap the Option into a Result
  • a

    average-vr-56795

    11/09/2017, 1:41 AM
    It wants to keep the Option in the Result
  • w

    witty-crayon-22786

    11/09/2017, 1:58 AM
    Copy code
    let v_o: Option<Vec<u8>> = ???
let v: Option<Result<Vec<u8>>> = v_o.map(|v| Ok(v))
v.unwrap_or_else(|| ???)
  • w

    witty-crayon-22786

    11/09/2017, 2:01 AM
    Copy code
    store.load_file_bytes(&fingerprint)
  .and_then(|v_o| {
    v_o.map(|v| Ok(v)).unwrap_or_else(|| store.load_directory_proto_bytes(&fingerprint))
  })
  • w

    witty-crayon-22786

    11/09/2017, 2:13 AM
  • f

    fancy-queen-20734

    11/15/2017, 6:52 PM
    nice
1...375376377...906Latest