https://pantsbuild.org/ logo
Powered by
#development
  • h

    happy-kitchen-89482

    10/17/2017, 3:06 AM
    since we distribute the engine in a wheel now IIRC?
  • w

    witty-crayon-22786

    10/17/2017, 3:07 AM
    correct!
  • a

    average-vr-56795

    10/17/2017, 3:27 PM
    Ok, I need to actually work out an idiomatic way for us to do Results, because I'm getting sick of writing the code:
    Copy code
    match foo() {
  Ok(_) -> {},
  Err(err) -> return Err(err.description().to_string()),
}
  • a

    average-vr-56795

    10/17/2017, 3:28 PM
    Right now I'm mostly returning Result<_, String>, but you're not allowed to implement the From trait to convert things to String, because String isn't in your crate.
  • a

    average-vr-56795

    10/17/2017, 3:29 PM
    Which is leading me to believe that Rust wants me to just create a MyError type for each crate, and implement From each-error-I-want-to-unpack to MyError, which is a glorified wrapper around a String.
  • a

    average-vr-56795

    10/17/2017, 3:29 PM
    Which seems kind of ugly.
  • a

    average-vr-56795

    10/17/2017, 3:30 PM
    Anyone who actually knows Rust got any better ideas?
  • w

    witty-crayon-22786

    10/17/2017, 5:23 PM
    @average-vr-56795: is that this pattern?
  • w

    witty-crayon-22786

    10/17/2017, 5:23 PM
    Copy code
    foo().map_err(|err| err.description().to_string())?;
  • w

    witty-crayon-22786

    10/17/2017, 5:23 PM
    (no left hand side)
  • a

    average-vr-56795

    10/17/2017, 5:27 PM
    Yeah, that's still disappointingly verbose for how often I'm having to do it 😞
  • w

    witty-crayon-22786

    10/17/2017, 5:36 PM
    i see what you mean.... with 
    From
    and a relevant conversion, it would just be:
  • w

    witty-crayon-22786

    10/17/2017, 5:36 PM
    Copy code
    foo().into()?;
  • w

    witty-crayon-22786

    10/17/2017, 5:36 PM
    ?
  • a

    average-vr-56795

    10/17/2017, 5:37 PM
    No, it would just be 
    from()?
  • a

    average-vr-56795

    10/17/2017, 5:37 PM
    foo()?
    even
  • w

    witty-crayon-22786

    10/17/2017, 5:37 PM
    oh, From conversions trigger automatically there? interesting
  • a

    average-vr-56795

    10/17/2017, 5:37 PM
    Yeah, it's a little magic, but pretty handy
  • w

    witty-crayon-22786

    10/17/2017, 5:39 PM
    on the other hand, the 
    map_err
    boilerplate does give you the opportunity to enrich the error message, which i generally thing is going to be a good idea
  • w

    witty-crayon-22786

    10/17/2017, 5:39 PM
    "Failed to do specific thing X: {}"
  • a

    average-vr-56795

    10/17/2017, 5:43 PM
    Yeah 🙂 I guess I just thought I was getting away from the Go world with all your fancy complex types and stuff 😛
  • w

    witty-crayon-22786

    10/17/2017, 5:48 PM
    heh.
  • w

    witty-crayon-22786

    10/17/2017, 5:56 PM
    i mean, if we wanted to "newtype" up an error type wrapping a string for the crate, i suppose we could do that. but i do actually think the enrichment will generally be a good idea.
  • w

    witty-crayon-22786

    10/17/2017, 5:56 PM
    given that we won't have stacktraces.
  • w

    witty-crayon-22786

    10/17/2017, 5:56 PM
    the "error chain" library seems like overkill to me.
  • a

    average-vr-56795

    10/17/2017, 6:00 PM
    At a glance, that actually looks kind of nice...
  • a

    average-vr-56795

    10/17/2017, 6:00 PM
    Maybe I'll give it a proper read at some point 🙂
  • w

    witty-crayon-22786

    10/17/2017, 6:32 PM
    yea, i guess i don't have a real opinion on it quite yet.
  • r

    rough-minister-58256

    10/17/2017, 9:56 PM
    @happy-kitchen-89482 any tips on the best way to proceed with https://github.com/pantsbuild/pants/issues/4917 ?
  • r

    rough-minister-58256

    10/17/2017, 11:33 PM
    just trying to get a sense for how best to wire that up w/o too much fumbling in the dark
1...356357358...906Latest