https://pantsbuild.org/ logo
Powered by
#development
  • w

    witty-crayon-22786

    09/29/2017, 5:12 PM
    @average-vr-56795: well, i can take a look at that... iirc that protoc should have been built on a very old linux
  • a

    average-vr-56795

    09/29/2017, 5:13 PM
    I might as well learn 🙂
  • w

    witty-crayon-22786

    09/29/2017, 5:13 PM
  • w

    witty-crayon-22786

    09/29/2017, 5:13 PM
    it's possible though that @happy-kitchen-89482 used prebuilt binaries in https://github.com/pantsbuild/binaries/commit/279be7f0b33d9735d402b42cfccb3841b7934bbf ...?
  • w

    witty-crayon-22786

    09/29/2017, 5:14 PM
    ...hm, nope.
  • w

    witty-crayon-22786

    09/29/2017, 5:14 PM
    @happy-kitchen-89482: did you use the vagrant image for that one?
  • h

    happy-kitchen-89482

    09/29/2017, 5:15 PM
    I have absolutely no recollection…
  • w

    witty-crayon-22786

    09/29/2017, 5:15 PM
    @average-vr-56795: so, middle ground: let's merge both of those, and we can loop back around to revert + rebuild protoc
  • w

    witty-crayon-22786

    09/29/2017, 5:16 PM
    @happy-kitchen-89482: ie, the instructions on https://github.com/pantsbuild/binaries/blob/gh-pages/README.md
  • h

    happy-kitchen-89482

    09/29/2017, 5:17 PM
    I don’t recall which image I used
  • w

    witty-crayon-22786

    09/29/2017, 5:22 PM
    @average-vr-56795: merged both
  • w

    witty-crayon-22786

    09/29/2017, 5:22 PM
  • a

    average-vr-56795

    09/29/2017, 5:22 PM
    Thanks 🙂
  • w

    witty-crayon-22786

    09/29/2017, 5:23 PM
    woot.
  • w

    witty-crayon-22786

    09/29/2017, 5:24 PM
    @average-vr-56795: so yea, the answer in this case at least is that the squash merge worked from the github UI
  • a

    average-vr-56795

    09/29/2017, 5:24 PM
    Sweet
  • a

    average-vr-56795

    09/29/2017, 5:25 PM
    I'm trying just building a protoc on the weezy image to see what happens. Seems reasonable that if that's what we're testing with, that's what we promise to support 🙂
  • w

    witty-crayon-22786

    09/29/2017, 5:29 PM
    sure
  • a

    average-vr-56795

    09/29/2017, 5:38 PM
    @witty-crayon-22786 How attached are you to two-space indents for rust, by the way?
  • a

    average-vr-56795

    09/29/2017, 5:38 PM
    The standard is pretty broadly 4, but also, they decided to make the formatter infinitely configurable, so... Yay? We can choose...
  • w

    witty-crayon-22786

    09/29/2017, 5:39 PM
    blugh. reasonably, as it's what we use for everything internally, and in the rest of the pants codebase.
  • a

    average-vr-56795

    09/29/2017, 5:39 PM
    ok 🙂 Yay non-standard configuration!
  • w

    witty-crayon-22786

    09/29/2017, 5:39 PM
    if it's configurable, i'd say that's one i'd like to stick with.
  • w

    witty-crayon-22786

    09/29/2017, 5:39 PM
    lemme see gist.
  • w

    witty-crayon-22786

    09/29/2017, 5:40 PM
    ...the gist looks great.
  • w

    witty-crayon-22786

    09/29/2017, 5:40 PM
    #shipit
  • w

    witty-crayon-22786

    09/29/2017, 5:41 PM
    ...eh, some oddity with regard to method chaining. but oh well.
  • a

    average-vr-56795

    09/29/2017, 5:42 PM
    Probably configurable with one of the infinite config options: https://github.com/rust-lang-nursery/rustfmt/blob/master/Configurations.md
  • w

    witty-crayon-22786

    09/29/2017, 6:06 PM
  • w

    witty-crayon-22786

    09/29/2017, 6:06 PM
    but now that i see what it is doing, i think i agree with the default.
1...345346347...906Latest