Inverting how?

in essence: switching from a python entrypoint that loads rust as a module

to a rust entrypoint that embeds python

not sure how much of python you can statically link, but @rough-minister-58256 does.

(...large amounts)

[aside: is test_isolated_process currently intended to pass?]

...yes, afaik.

yea, nothing in there is skipped.

yes, confirmed... passes on master.

@average-vr-56795: src/rust/engine/src/rule_graph.rs has

selector_str

and

type_constraint_str

, etc

Do we have a preference in rust as to how we handle dependencies' custom Result types? Should an internal API just pass up the CustomResult, or unwrap it into a less-custom Result type? Or something else?

Language aside I prefer not exposing 3rdparty types unless they meet some high bar of commonness / universality (guava's ImmutableList for java is an example). So I'm in favor of unwrap and, depending, rewrap in our own custom result type. From could be implemented for the conversions even if they become noisy.

Cool. The only prior art I can see is using Result<T, String>, and passing up io::Results - any objections to Result<T, String>?

Nope

@enough-analyst-54434 https://github.com/pantsbuild/pants/pull/4901 is green, by the way 🙂

Thanks for the heads-up, merged

seeing this on master when bootstrapping

Compiling thread_local v0.3.3
   Compiling num_cpus v1.3.0
   Compiling log v0.3.7
   Compiling process_executor v0.0.1 (file:///Users/yic/workspace/intellij-pants-plugin/.cache/pants/src/rust/engine/process_executor)
error: no method named `envs` found for type `&mut std::process::Command` in the current scope
  --> src/rust/engine/process_executor/src/lib.rs:48:6
   |
48 |     .envs(req.env)
   |      ^^^^

error: aborting due to previous error

error: Could not compile `process_executor`.

To learn more, run the command again with --verbose.

should i file a ticket?

I'm seeing it to, sure!

https://github.com/pantsbuild/pants/issues/4909 thanks

Since I repro and am active in this space, I'll see if I can fix in ~10 minutes and if not I'll buy time with a revert if @average-vr-56795 agrees

Sounds good, I'll also take a look

I can't reproduce - what rust version do you have?

$ ~/.cache/pants/rust-toolchain/bin/rustc --version rustc 1.20.0 (f3d6973f4 2017-08-27)

ditto

pants (master)]$ rm -rf ~/.cache/pants/bin/native-engine ; find src/rust -name target -exec rm -rf {} \; ; ./pants cloc src/java/org/pantsbuild/junit/annotations: runs fine for me at 4745c54023b85d253c597d1dc5ffc219eb1d8200

ack, as does CI

@wide-energy-11069 please try after

rm -rf ~/.cache/pants/rust-toolchain/

It looks like old bootstraps net you old cargos ... with bugs