pantsbuild #development

Channels

welcome

github-notifications

development

rough-minister-58256

04/25/2017, 11:39 PM

on the

PythonBinary(Target)

yeah?

witty-crayon-22786

04/25/2017, 11:40 PM

that's already sortof generically implemented here: https://github.com/pantsbuild/pants/blob/master/src/python/pants/engine/legacy/structs.py#L33-L60

witty-crayon-22786

04/25/2017, 11:40 PM

no: because parsing sources is always the same. it's not python specific. the only bit that is custom is the default globs

rough-minister-58256

04/25/2017, 11:40 PM

..or the explicit sources?

witty-crayon-22786

04/25/2017, 11:40 PM

witty-crayon-22786

04/25/2017, 11:40 PM

those are globs.

witty-crayon-22786

04/25/2017, 11:42 PM

i'll try to make some progress on a doc here today

rough-minister-58256

04/25/2017, 11:43 PM

there’s a clear call here to:

sources = getattr(self, 'sources', None)

rough-minister-58256

04/25/2017, 11:43 PM

so what provides the

self.sources

in a classmethod?

witty-crayon-22786

04/25/2017, 11:43 PM

the target does not construct instances of the fields

rough-minister-58256

04/25/2017, 11:43 PM

(extrapolated for e.g.

DependenciesField

since that’s more complex)

witty-crayon-22786

04/25/2017, 11:43 PM

the engine does

witty-crayon-22786

04/25/2017, 11:44 PM

you tell me which ones are legal, and then "something" generic in the engine feeds args to field implementations

rough-minister-58256

04/25/2017, 11:44 PM

how does that solve for traversable_dep_specs tho

witty-crayon-22786

04/25/2017, 11:44 PM

the

self.sources

is there because we're consuming them from a Struct

rough-minister-58256

04/25/2017, 11:45 PM

yeah, so in the case we can’t directly consume the field from a struct?

rough-minister-58256

04/25/2017, 11:45 PM

ah nm

rough-minister-58256

04/25/2017, 11:45 PM

thats why we need the otehr typed fields for all t_d_s deps etc

witty-crayon-22786

04/25/2017, 11:45 PM

@rough-minister-58256 : once the fields have been parsed, you can pass them to a classmethod that will look at them (or the kwargs, directly) to turn them into a full list of deps

witty-crayon-22786

04/25/2017, 11:45 PM

yea

witty-crayon-22786

04/25/2017, 11:46 PM

BinaryField + DependenciesField is enough to compute a "complete" set of dependencies for jvm_binary

rough-minister-58256

04/25/2017, 11:50 PM

yeah, starting to click

witty-crayon-22786

04/26/2017, 12:15 AM

this is empty for now, but i'll be working here for the next day or two to try to sketch out what "externalizing target fields" ie, "sources as a product" should look like: https://docs.google.com/document/d/102EFbwk6cpM9-_4ZSYhMQYA0zL1UKbXzW-DCd8KsFeg/edit?usp=sharing

rough-minister-58256

04/26/2017, 12:16 AM

👍

fancy-queen-20734

04/26/2017, 6:19 PM

Found an extra cffi call: https://github.com/pantsbuild/pants/pull/4517/files#diff-475e379696b5853a1cd5ec0a294dd099

witty-crayon-22786

04/26/2017, 6:24 PM

ah, neat.

salmon-summer-38098

04/26/2017, 7:22 PM

looking at https://github.com/pantsbuild/pants/milestone/8

salmon-summer-38098

04/26/2017, 7:22 PM

https://github.com/pantsbuild/pants/issues/4394 seems ok to pick?

witty-crayon-22786

04/26/2017, 7:23 PM

that's probably fine. it's nice-to-have for 1.3.0, but will be important for 1.4.0

salmon-summer-38098

04/26/2017, 7:24 PM

any other higher priority for 1.3.0?