https://pantsbuild.org/ logo
Powered by
#development
  • w

    witty-crayon-22786

    04/03/2017, 8:10 PM
    ... the proper api for that would probably be something context-managery, but let's do that later.
  • r

    rough-minister-58256

    04/03/2017, 8:10 PM
    rgr, thx
  • w

    witty-crayon-22786

    04/03/2017, 8:10 PM
    exposing the RwLockGuard from the method was awkward in the first place... i shouldn't have done that.
  • r

    rough-minister-58256

    04/03/2017, 8:12 PM
    could probably also move the .pool_create() and .pool() methods into default impls on a trait too and reuse across Core and PosixFS
  • w

    witty-crayon-22786

    04/03/2017, 8:13 PM
    if the pool workaround is going to live for a while, not having two pools would be good too.
  • r

    rough-minister-58256

    04/03/2017, 8:13 PM
    that too
  • r

    rough-minister-58256

    04/03/2017, 8:13 PM
    the current 2x pool is just a workaround for the shared future thing, yeah?
  • w

    witty-crayon-22786

    04/03/2017, 8:13 PM
    yea
  • r

    rough-minister-58256

    04/03/2017, 8:13 PM
    cool
  • r

    rough-minister-58256

    04/03/2017, 8:14 PM
    https://travis-ci.org/pantsbuild/pants/jobs/218213644#L3709 <— native_engine_version version checking works! 🙂
  • w

    witty-crayon-22786

    04/03/2017, 8:15 PM
    hah, nice!
  • s

    salmon-summer-38098

    04/03/2017, 8:16 PM
    that is nice!
  • r

    rough-minister-58256

    04/03/2017, 8:59 PM
    PR is green - landing
  • r

    rough-minister-58256

    04/03/2017, 8:59 PM
    w00t
  • f

    fancy-queen-20734

    04/03/2017, 9:01 PM
    @witty-crayon-22786 commented that I wasn’t ready for another review yet, but I should have pinged you to let you know specifically.
  • r

    rough-minister-58256

    04/03/2017, 9:02 PM
    we need a better way to signal ‘ready for review’, methinks
  • w

    witty-crayon-22786

    04/03/2017, 9:33 PM
    @fancy-queen-20734 : oh, i saw. but that wasn't really a review so much as a thing i noticed
  • f

    fancy-queen-20734

    04/03/2017, 10:24 PM
    kk
  • r

    rough-minister-58256

    04/04/2017, 9:06 AM
    hmm, what was our plan around engine-ifying 
    traversable_dependency_specs
    again?
  • r

    rough-minister-58256

    04/04/2017, 9:07 AM
  • f

    full-kilobyte-93429

    04/04/2017, 6:00 PM
    travis seems to fail often with the following, appears to be from yesterday
    Copy code
    [Bintray Upload] Reading descriptor file: ./native-engine.bintray.json
/home/travis/.rvm/rubies/ruby-2.2.5/lib/ruby/2.2.0/json/common.rb:155:in `parse': 419: unexpected token at '{ (JSON::ParserError)
      "includePattern": "Build failed, waiting for other jobs to finish...
FAILED to build for target i686-unknown-linux-gnu
  • f

    fancy-queen-20734

    04/04/2017, 6:15 PM
    interesting
  • f

    full-kilobyte-93429

    04/04/2017, 6:16 PM
    flaky afaict
  • r

    rough-minister-58256

    04/04/2017, 6:16 PM
    Copy code
    "includePattern": "Build failed, waiting for other jobs to finish…
  • r

    rough-minister-58256

    04/04/2017, 6:16 PM
    seems odd
  • f

    fancy-queen-20734

    04/04/2017, 6:17 PM
    the full message includes the full json
  • f

    fancy-queen-20734

    04/04/2017, 6:20 PM
    I’m guessing it’s the newlines in the build failed message
  • f

    fancy-queen-20734

    04/04/2017, 6:21 PM
    the message I get from ruby if I try to parse multiline json is ~ about the same
  • w

    witty-crayon-22786

    04/04/2017, 7:04 PM
    i think that means we don't have engine binaries for dev15
  • w

    witty-crayon-22786

    04/04/2017, 7:05 PM
    ...hm. no. we do.
1...307308309...906Latest