https://pantsbuild.org/ logo
Powered by
#development
  • w

    witty-crayon-22786

    03/17/2017, 6:32 PM
    k, thanks
  • w

    witty-crayon-22786

    03/17/2017, 7:33 PM
    also sortof want to break each 
    Node
    out into a separate module, but will definitely wait on that one.
  • w

    witty-crayon-22786

    03/17/2017, 7:50 PM
    ...blargh. breaking each 
    Node
    into its own module is the thing that would actually beneficial... can't do that now.
  • w

    witty-crayon-22786

    03/17/2017, 7:50 PM
    the result of this will essentially be that Context will be empty. that's probably for the best though... it's currently a catchall.
  • w

    witty-crayon-22786

    03/17/2017, 9:32 PM
    @full-kilobyte-93429 : how's it going?
  • f

    full-kilobyte-93429

    03/17/2017, 9:38 PM
    getting close, now i have the new code in place, my last piece is to call 
    store_list
    , i am just adding println! on master just to get a better sense
  • w

    witty-crayon-22786

    03/17/2017, 9:38 PM
    👍
  • w

    witty-crayon-22786

    03/17/2017, 9:38 PM
    let me know if i can help
  • f

    full-kilobyte-93429

    03/17/2017, 9:38 PM
    yea, definitely will
  • r

    rough-minister-58256

    03/17/2017, 11:01 PM
    Copy code
    [omerta pants (kwlzn/default_v2_engine)]$ ./pants --enable-v2-engine test contrib/findbugs/tests/java/org/pantsbuild/contrib/findbugs:no_sources
...
15:59:36 00:02     [findbugs]
                   Invalidated 1 target.
                   [1/1] contrib/findbugs/tests/java/org/pantsbuild/contrib/findbugs:no_sources
15:59:36 00:02       [findbugs]
                     Warnings generated: 2
                     
                   Bug[high]: EC_UNRELATED_TYPES Call to String.equals(Integer) in org.pantsbuild.contrib.findbugs.AllWarnings.main(String[]) At AllWarnings.java:[lines 6-17]
                   Bug[high]: EC_UNRELATED_TYPES Call to String.equals(Integer) in org.pantsbuild.contrib.findbugs.HighWarning.main(String[]) At HighWarning.java:[lines 6-11]
                   
                   Bugs: 2 (High: 2, Normal: 0, Low: 0)
FAILURE: failed with 2 bugs and 0 errors


15:59:36 00:02   [complete]
               FAILURE
  • r

    rough-minister-58256

    03/17/2017, 11:01 PM
    vs v1:
    Copy code
    16:01:00 00:04     [findbugs]
                   Invalidated 1 target.
                   [1/1] contrib/findbugs/tests/java/org/pantsbuild/contrib/findbugs:no_sources
                     No jars to be analyzed
…
               SUCCESS
  • w

    witty-crayon-22786

    03/17/2017, 11:02 PM
    ..."no_sources" indeed has no sources, heh.
  • r

    rough-minister-58256

    03/17/2017, 11:02 PM
    any pointers on this one? looks like it might be pulling in the findbugs code itself in the v2 path?
  • w

    witty-crayon-22786

    03/17/2017, 11:03 PM
    ...oh: looks related to implicit sources
  • w

    witty-crayon-22786

    03/17/2017, 11:03 PM
    empty list vs 
    None
  • w

    witty-crayon-22786

    03/17/2017, 11:03 PM
    sec
  • r

    rough-minister-58256

    03/17/2017, 11:03 PM
    aha
  • w

    witty-crayon-22786

    03/17/2017, 11:05 PM
    @rough-minister-58256 :
    Copy code
    $ git diff
diff --git a/src/python/pants/engine/legacy/structs.py b/src/python/pants/engine/legacy/structs.py
index 0ee7f14..24e5e98 100644
--- a/src/python/pants/engine/legacy/structs.py
+++ b/src/python/pants/engine/legacy/structs.py
@@ -39,7 +39,7 @@ class TargetAdaptor(StructWithDeps):
       see: <https://github.com/pantsbuild/pants/issues/2997>
     """
     sources = getattr(self, 'sources', None)
-    if not sources:
+    if sources is None:
       if self.default_sources_globs:
         return Globs(*self.default_sources_globs,
                      spec_path=self.address.spec_path,
  • w

    witty-crayon-22786

    03/17/2017, 11:06 PM
    the output of 
    ./pants filedeps contrib/findbugs/tests/java/org/pantsbuild/contrib/findbugs:no_sources
    matches afterward (...although it doesn't make sense with/without v2 anyway)
  • w

    witty-crayon-22786

    03/17/2017, 11:06 PM
    ...oh, it's transitive. yea, makes sense then.
  • r

    rough-minister-58256

    03/17/2017, 11:06 PM
    worked! thx!
  • w

    witty-crayon-22786

    03/17/2017, 11:07 PM
    probably worth adding more of a comment there though
  • r

    rough-minister-58256

    03/17/2017, 11:07 PM
    comment where?
  • w

    witty-crayon-22786

    03/17/2017, 11:08 PM
    for the 
    None
    vs 
    []
    distinction
  • r

    rough-minister-58256

    03/17/2017, 11:10 PM
    ah k
  • r

    rough-minister-58256

    03/18/2017, 12:44 AM
    hm.. looks like we’re gonna have to implement the new subproject support in the engine.
  • r

    rough-minister-58256

    03/18/2017, 1:05 AM
    @witty-crayon-22786 repro: flip —enable-v2-engine 
    default=True
    & 
    ./pants test tests/python/pants_test/build_graph:: -- -k test_subproject_integration.py -vvs
  • w

    witty-crayon-22786

    03/18/2017, 1:05 AM
    thanks. will try to tackle tomorrow morning probably.
  • r

    rough-minister-58256

    03/18/2017, 1:05 AM
  • w

    witty-crayon-22786

    03/18/2017, 6:52 PM
    @rough-minister-58256 : the two callsites of 
    setup_legacy_graph
    pass different amounts of settings... intentional? one in 
    src/python/pants//bin/goal_runner.py
    and one in 
    src/python/pants//pantsd/subsystem/pants_daemon_launcher.py
1...281282283...906Latest