Ergonomic, hermetic, user-friendly software build system for Python, Go, Java, Kotlin, Protobuf, Scala, Shell. Pants lets you fearlessly scale up your codebase!

Pants

but <https://doc.rust-lang.org/book/custom-allocators.html> indicates that dynamic/shared libraries use the system allocator by default

wonder how that works if it’s technically an “unstable” feature

it certainly looks like you managed to use nightly there

did you have that line marked `#![feature(alloc_system)]` ?

but probably a non-issue given the shared library default

going to work through the last few errors tomorrow (hopefully before the end of the day, but if not, over the weekend) and then try to land the rust io patch.

is `globs` the most part of target processing? if so moving into `sources` as product is less for perf but for other benefits like <https://github.com/pantsbuild/pants/issues/2996> and <https://github.com/pantsbuild/pants/issues/3561>

<@U098ZNTCN> : yes, it's mostly for other benefits.

it _does_ remove a level of nesting: UnhydratedStruct (which is all in <https://github.com/pantsbuild/pants/blob/master/src/python/pants/engine/build_files.py>) vs UnhydratedTarget (<https://github.com/pantsbuild/pants/blob/master/src/python/pants/engine/legacy/graph.py>)

but that's mostly a cleanup... the memory usage wouldn't be huge.

<@U098ZNTCN> : it's really just the implicit sources thing that is a blocker.

we could probably have you work on this one: <https://github.com/pantsbuild/pants/issues/4283>

...the implicit_sources thing is still a blocker, don't get me wrong. but given our time constraints, focusing on memory usage/performance improvements like that one would probably make more sense.

yea, i get that, i probably will just do the cheap solution and revisit later.

one other question along the same line: what are the reasons we also make or not make `dependencies` a product? aside from `dependencies` and `sources` the rest are probably all immutable properties

<@U098ZNTCN> : i think the gist of the new engine is that everything is a product

the way you get sources is literally by requesting a `SourcesField` for an `Address`

might be good to get another set of eyes on the rustio pr if folks have cycles. I’m chewing through it now

have to head out a bit early, but will be on tomorrow/sunday