https://pantsbuild.org/ logo
Powered by
#development
  • r

    rough-minister-58256

    02/22/2017, 12:35 AM
    😱
  • f

    fancy-queen-20734

    02/22/2017, 12:43 AM
    @witty-crayon-22786 I’m thinking I’ll fix the Exactly display thing before / part of the digraph stuff. I’m getting really annoyed with the noise it introduces.
  • w

    witty-crayon-22786

    02/22/2017, 12:43 AM
    hooray!
  • w

    witty-crayon-22786

    02/22/2017, 12:44 AM
    er... "display" thing? or use of Exactly?
  • f

    fancy-queen-20734

    02/22/2017, 12:44 AM
    hm.
  • w

    witty-crayon-22786

    02/22/2017, 12:44 AM
    one thing is, my Key change gets all up in there
  • f

    fancy-queen-20734

    02/22/2017, 12:44 AM
    ah
  • f

    fancy-queen-20734

    02/22/2017, 12:44 AM
    I was leaning towards display
  • w

    witty-crayon-22786

    02/22/2017, 12:44 AM
    TypeConstraint(Id) becomes TypeConstraint(Key)
  • f

    fancy-queen-20734

    02/22/2017, 12:45 AM
    naively, I could just use str instead of repr. The debug output would be further from the declaration text, but way more readable
  • f

    fancy-queen-20734

    02/22/2017, 12:46 AM
    @User uploaded a file:

    ex.pngâ–¾

  • w

    witty-crayon-22786

    02/22/2017, 12:46 AM
    woot!
  • w

    witty-crayon-22786

    02/22/2017, 12:46 AM
    woooot
  • f

    fancy-queen-20734

    02/22/2017, 12:46 AM
    the effect would be that the constraints would be =D instead of just D, like in the above
  • w

    witty-crayon-22786

    02/22/2017, 12:46 AM
    would have killed for that 30 minutes ago when i was trying to figure out why 
    TypeConstraint(=BuildDirs)
    wasn't finding anything
  • w

    witty-crayon-22786

    02/22/2017, 12:47 AM
    (...would have seen two distinct entries)
  • f

    fancy-queen-20734

    02/22/2017, 12:47 AM
    but still way better than Exactly(D)
  • f

    fancy-queen-20734

    02/22/2017, 12:47 AM
    having a file / line no would be 1000x better than having equivalent reprs anyway
  • w

    witty-crayon-22786

    02/22/2017, 12:47 AM
    @fancy-queen-20734 : if it's separable from landing visualization, i'd seperate it
  • w

    witty-crayon-22786

    02/22/2017, 12:48 AM
    because i'd really rather see TypeConstraint gone
  • f

    fancy-queen-20734

    02/22/2017, 12:48 AM
    yeah, should be tiny
  • f

    fancy-queen-20734

    02/22/2017, 12:48 AM
    hm
  • w

    witty-crayon-22786

    02/22/2017, 12:48 AM
    er. TypeConstraint replaced with a set of TypeId
  • f

    fancy-queen-20734

    02/22/2017, 12:48 AM
    as in instead of TypeConstraint(..), we’d use Vec<TypeId>?
  • w

    witty-crayon-22786

    02/22/2017, 12:48 AM
    maybe it doesn't go away
  • w

    witty-crayon-22786

    02/22/2017, 12:48 AM
    yea
  • w

    witty-crayon-22786

    02/22/2017, 12:48 AM
    TypeConstraint(Vec<TypeId>)
  • w

    witty-crayon-22786

    02/22/2017, 12:49 AM
    ...or something.
  • f

    fancy-queen-20734

    02/22/2017, 12:49 AM
    there’s still the one special case, but I think it only is needed as an internal detail and not as part of the exec model
  • f

    fancy-queen-20734

    02/22/2017, 12:49 AM
    for has products
1...244245246...906Latest