pantsbuild #development

Channels

welcome

github-notifications

development

witty-crayon-22786

02/14/2017, 9:51 PM

(given how infrequently that field is used)

fancy-queen-20734

02/14/2017, 10:29 PM

the OSX shard is not very available

witty-crayon-22786

02/14/2017, 10:29 PM

it's very, very slow during the middle of the day, yea.

witty-crayon-22786

02/14/2017, 10:30 PM

@fancy-queen-20734 : don't rush at this point... i can post this for review before you do.

fancy-queen-20734

02/14/2017, 10:31 PM

not rushing exactly, I just wanted to get a ci run of the validation s/python/rust/ going even if it starts a bit messy

fancy-queen-20734

02/14/2017, 10:31 PM

https://github.com/pantsbuild/pants/pull/4259

witty-crayon-22786

02/15/2017, 12:22 AM

@fancy-queen-20734 : thanks nick! will review that in about 30 minutes

fancy-queen-20734

02/15/2017, 12:24 AM

rgr

witty-crayon-22786

02/15/2017, 1:19 AM

ok, mine's out: https://github.com/pantsbuild/pants/pull/4261

witty-crayon-22786

02/15/2017, 1:19 AM

reviewing #4259

witty-crayon-22786

02/15/2017, 8:07 PM

@fancy-queen-20734 : mind pinging me when you've had a chance to review 4261? eager to context switch away from the scrooge stuff asap 😉

witty-crayon-22786

02/15/2017, 8:07 PM

but you should land yours first... i'm fine with doing the necessary

externs::

merge

fancy-queen-20734

02/15/2017, 10:50 PM

sure

witty-crayon-22786

02/16/2017, 12:08 AM

@fancy-queen-20734 : should i merge first? or should you

fancy-queen-20734

02/16/2017, 12:09 AM

@witty-crayon-22786 sorry about the response time. I’m debugging a pointer issue with the patch

fancy-queen-20734

02/16/2017, 12:09 AM

so, I’ll merge second

witty-crayon-22786

02/16/2017, 12:09 AM

ok. let me know if i can help

witty-crayon-22786

02/16/2017, 12:09 AM

the

externs::

merge is pretty easy

witty-crayon-22786

02/16/2017, 12:09 AM

mostly just deleting a bunch of parameters 😃

fancy-queen-20734

02/16/2017, 12:10 AM

I’m really excited about that portion

fancy-queen-20734

02/16/2017, 12:15 AM

turns out bending around abstractions can do funny things

fancy-queen-20734

02/16/2017, 12:16 AM

tl;dr passing handles to empty tuples considered dangerous

fancy-queen-20734

02/16/2017, 12:23 AM

with some thinking, I bet I could fix it more properly

witty-crayon-22786

02/16/2017, 12:40 AM

@fancy-queen-20734 : merged, sorry for the wait

witty-crayon-22786

02/16/2017, 12:55 AM

@fancy-queen-20734 : hm... handles to empty tuples?

witty-crayon-22786

02/16/2017, 12:56 AM

fwiw, handles are not comparable, so two different handles to the same empty tuple should be 100% independent

witty-crayon-22786

02/16/2017, 12:56 AM

(unlike `Key`/`Id`)

witty-crayon-22786

02/16/2017, 12:56 AM

every

Value

should have its own

Handle

, which will have its own entry in the

ExternContext._handles

witty-crayon-22786

02/16/2017, 12:57 AM

and dropping a

Value

should delete exactly that

Handle

and no other

fancy-queen-20734

02/16/2017, 12:59 AM

ah. hm.