https://pantsbuild.org/ logo
Powered by
#development
  • w

    witty-crayon-22786

    01/20/2016, 10:50 PM
    confident that we can do it for java and python given some frozen/known set of source roots
  • b

    bored-art-40741

    01/20/2016, 10:59 PM
    Yeah python and java are somewhat reasonable
  • b

    bored-art-40741

    01/20/2016, 10:59 PM
    Note that we also have some assumptions/guarantees in our codebase
  • b

    bored-art-40741

    01/20/2016, 10:59 PM
    Things like, packages are forbidden from being split across targets
  • b

    bored-art-40741

    01/20/2016, 11:00 PM
    The majority of wildcard imports are forbidden, non-global-scope-at-the-top-of-the-file imports are forbidden
  • w

    witty-crayon-22786

    01/20/2016, 11:02 PM
    yea... those restrictions are all desirable for other reasons, so i think we can make them fly internally
  • w

    witty-crayon-22786

    01/20/2016, 11:03 PM
    (i wonder about the wildcard thing though... should be able to figure out the package there prolly...?)
  • b

    bored-art-40741

    01/20/2016, 11:04 PM
    Wildcard thing?
  • w

    witty-crayon-22786

    01/20/2016, 11:05 PM
    wildcard imports forbidden
  • w

    witty-crayon-22786

    01/20/2016, 11:05 PM
    also possible that scala.meta provides an easier way to determine symbols
  • b

    bored-art-40741

    01/20/2016, 11:10 PM
    There might be a better way to do this
  • b

    bored-art-40741

    01/20/2016, 11:10 PM
    It's worth noting that this is screaming fast though, and it operates one source at a time
  • w

    witty-crayon-22786

    01/20/2016, 11:10 PM
    yea
  • b

    bored-art-40741

    01/20/2016, 11:10 PM
    It doesn't care about dependencies, etc
  • b

    bored-art-40741

    01/20/2016, 11:10 PM
    But it also doesn't get type information
  • w

    witty-crayon-22786

    01/20/2016, 11:10 PM
    yea
  • b

    bored-art-40741

    01/20/2016, 11:11 PM
    Or implicit expansion, etc
  • w

    witty-crayon-22786

    01/20/2016, 11:13 PM
    ...hm, not meta. it's a post-compile tool apparently.
  • w

    witty-crayon-22786

    01/21/2016, 6:15 PM
    @bored-art-40741: hey, so i spent some more time looking at dependency inference yesterday, and it all looks feasible
  • b

    bored-art-40741

    01/21/2016, 6:15 PM
    What kind of dependency inference?
  • b

    bored-art-40741

    01/21/2016, 6:15 PM
    buildgen of course does the basic "I explicitly use/expose this symbol"
  • w

    witty-crayon-22786

    01/21/2016, 6:16 PM
    parsing code rather than BUILD files to determine dependencies
  • w

    witty-crayon-22786

    01/21/2016, 6:16 PM
    yea
  • w

    witty-crayon-22786

    01/21/2016, 6:16 PM
    the main thing that is not currently possible in https://rbcommons.com/s/twitter/r/3339/ is that the "scalac symbol extraction" code would need to invoke BUILD file lookups
  • w

    witty-crayon-22786

    01/21/2016, 6:16 PM
    which means that BUILD file parsing needs to happen in the engine, in order for that not to introduce hidden dependencies
  • w

    witty-crayon-22786

    01/21/2016, 6:17 PM
    before i expand that review to implement BUILD file parsing in the engine, i'd like to polish it and land it.
  • w

    witty-crayon-22786

    01/21/2016, 6:18 PM
    i did a brownbag internally, and all open questions have been resolved... in particular, it's still possible to have the equivalent of a "complete graph" by executing until all Nodes have promised not to introduce new dependencies
  • b

    bored-art-40741

    01/21/2016, 6:19 PM
    What's a brown bag?
  • w

    witty-crayon-22786

    01/21/2016, 6:20 PM
    a talk overviewing the changes
  • w

    witty-crayon-22786

    01/21/2016, 6:20 PM
    should have recorded it... sorry =(
1...212223...906Latest