https://pantsbuild.org/ logo
Powered by
#development
  • r

    rough-minister-58256

    01/18/2017, 8:02 PM
    that could make sense
  • r

    rough-minister-58256

    01/18/2017, 8:04 PM
    @full-kilobyte-93429 @salmon-summer-38098 fyi we’re definitely missing some coverage here:
  • r

    rough-minister-58256

    01/18/2017, 8:05 PM
    Copy code
    [illuminati pants (master)]$ git rev-parse HEAD
8336e5a3ebf002c28c3d8f7fdc9571383b674f94
[illuminati pants (master)]$ ./pants --enable-v2-engine filedeps examples::

FAILURE
Exception caught: (<type 'exceptions.AttributeError'>)
  File "/Users/kwilson/dev/pants/src/python/pants/bin/pants_exe.py", line 50, in <module>
    main()
  File "/Users/kwilson/dev/pants/src/python/pants/bin/pants_exe.py", line 44, in main
    PantsRunner(exiter).run()
  File "/Users/kwilson/dev/pants/src/python/pants/bin/pants_runner.py", line 57, in run
    options_bootstrapper=options_bootstrapper)
  File "/Users/kwilson/dev/pants/src/python/pants/bin/pants_runner.py", line 46, in _run
    return LocalPantsRunner(exiter, args, env, options_bootstrapper=options_bootstrapper).run()
  File "/Users/kwilson/dev/pants/src/python/pants/bin/local_pants_runner.py", line 37, in run
    self._run()
  File "/Users/kwilson/dev/pants/src/python/pants/bin/local_pants_runner.py", line 79, in _run
    goal_runner_result = goal_runner.run()
  File "/Users/kwilson/dev/pants/src/python/pants/bin/goal_runner.py", line 248, in run
    result = self._execute_engine()
  File "/Users/kwilson/dev/pants/src/python/pants/bin/goal_runner.py", line 237, in _execute_engine
    result = engine.execute(self._context, self._goals)
  File "/Users/kwilson/dev/pants/src/python/pants/engine/legacy_engine.py", line 26, in execute
    self.attempt(context, goals)
  File "/Users/kwilson/dev/pants/src/python/pants/engine/round_engine.py", line 224, in attempt
    goal_executor.attempt(explain)
  File "/Users/kwilson/dev/pants/src/python/pants/engine/round_engine.py", line 47, in attempt
    task.execute()
  File "/Users/kwilson/dev/pants/src/python/pants/task/console_task.py", line 57, in execute
    for value in self.console_output(targets):
  File "/Users/kwilson/dev/pants/src/python/pants/backend/project_info/tasks/filedeps.py", line 50, in console_output
    files.add(target.address.build_file.full_path)

Exception message: 'Address' object has no attribute ‘build_file’
  • s

    salmon-summer-38098

    01/18/2017, 8:06 PM
    yeah looks like it
  • r

    rough-minister-58256

    01/18/2017, 8:06 PM
    we should probably hold off on enable_v2_engine default=True until we can land the fix, else we’ll break filedeps for everyone
  • s

    salmon-summer-38098

    01/18/2017, 8:06 PM
    yeah definitely
  • s

    salmon-summer-38098

    01/18/2017, 8:07 PM
    wonder what else is getting missed in the testing
  • w

    witty-crayon-22786

    01/18/2017, 8:07 PM
  • r

    rough-minister-58256

    01/18/2017, 8:07 PM
    ah
  • w

    witty-crayon-22786

    01/18/2017, 8:07 PM
    which begs the question: why don't those share this codepath?
  • r

    rough-minister-58256

    01/18/2017, 8:07 PM
    heh
  • w

    witty-crayon-22786

    01/18/2017, 8:08 PM
    maybe filemap doesn't deal with BUILD files?
  • w

    witty-crayon-22786

    01/18/2017, 8:08 PM
    ...oh, it can't, huh. without blaming multiple targets, i suppose
  • s

    salmon-summer-38098

    01/18/2017, 8:08 PM
    yeah afaik
  • s

    salmon-summer-38098

    01/18/2017, 8:10 PM
    i did add an integration test with my change so we will have future coverage there
  • f

    full-kilobyte-93429

    01/18/2017, 8:11 PM
    @rough-minister-58256 ack, will hold off shipping
  • f

    full-kilobyte-93429

    01/18/2017, 8:14 PM
    @billowy-beach-68498 sry how target ordering is related to the import error?
  • b

    billowy-beach-68498

    01/18/2017, 8:16 PM
    it's just my guess. different ordering will put a specific target on a different shard when running v1 and v2 engine. So on v2 engine, it may not be able to find a certain test target because that target was on a different shard on v1 engine.
  • f

    full-kilobyte-93429

    01/18/2017, 8:17 PM
    but retry works meaning the dependencies are there
  • f

    full-kilobyte-93429

    01/18/2017, 8:18 PM
    but interesting retrying shard work but not restarting the job
  • b

    billowy-beach-68498

    01/18/2017, 8:19 PM
    yeah, that is what I saw
  • b

    billowy-beach-68498

    01/18/2017, 8:19 PM
    and the error is about "cannot find test_XXX.py"
  • b

    billowy-beach-68498

    01/18/2017, 8:19 PM
    somehow test files are missing
  • b

    billowy-beach-68498

    01/18/2017, 8:20 PM
    that's why I suspect ordering issue.
  • f

    full-kilobyte-93429

    01/18/2017, 8:21 PM
    let me change the title of my PR and remove the flag flipping the rest is still good to review
  • f

    full-kilobyte-93429

    01/18/2017, 11:24 PM
    got a repro locally by running the same command of travis, out of many runs
    Copy code
    ./pants test.pytest --test-pytest-test-shard=4/7 `./pants list tests/python:: |xargs ./pants --tag='+integration' filter --filter-type=python_tests` -- -v
  • w

    witty-crayon-22786

    01/18/2017, 11:26 PM
    nice
  • r

    rough-minister-58256

    01/19/2017, 2:06 AM
    @witty-crayon-22786 fyi:
  • r

    rough-minister-58256

    01/19/2017, 2:06 AM
    @User uploaded a file:

    Pasted image at 2017-01-18, 6:06 PM▾

  • r

    rough-minister-58256

    01/19/2017, 2:06 AM
    not sure if you waitlisted or not, looks like queue cleared
1...208209210...906Latest