https://pantsbuild.org/ logo
Powered by
#development
  • w

    witty-crayon-22786

    01/14/2017, 12:57 AM
    ... it's the error message that doesn't match though, right?
  • f

    full-kilobyte-93429

    01/14/2017, 12:58 AM
    ok, will take a look, could be. 4 errors total, 2 left
  • f

    full-kilobyte-93429

    01/14/2017, 1:20 AM
    fixed, new error is 
    cycle for EntryId...
    , one left now
  • w

    witty-crayon-22786

    01/14/2017, 1:21 AM
    @full-kilobyte-93429 : if possible, re-enabling the 
    @ensure_engine
    would be great
  • f

    full-kilobyte-93429

    01/14/2017, 1:23 AM
    that's no different from flipping the 
    enable-v2-engine
    default to 
    True
    ?
  • f

    full-kilobyte-93429

    01/14/2017, 1:23 AM
    in other words, we can remove all the 
    ensure_engine
    now?
  • w

    witty-crayon-22786

    01/14/2017, 1:24 AM
    @full-kilobyte-93429 : no, i think we should invert ensure_engine
  • w

    witty-crayon-22786

    01/14/2017, 1:24 AM
    so that it tests v1.
  • w

    witty-crayon-22786

    01/14/2017, 1:24 AM
    (temporarily)
  • f

    full-kilobyte-93429

    01/14/2017, 1:24 AM
    invert all the places with 
    ensure_engine
    ?
  • f

    full-kilobyte-93429

    01/18/2017, 7:42 PM
    @salmon-summer-38098 this is the only failure i saw https://travis-ci.org/pantsbuild/pants/jobs/193151580
  • f

    full-kilobyte-93429

    01/18/2017, 7:42 PM
    Copy code
    ===================== ERRORS =====================
                      ERROR collecting tests/python/pants_test/jvm/test_safeargs.py 
                     .pants.d/python-setup/chroots/3d52985dee8888ecc155f0b70f82d84106faf045/.deps/py-1.4.31-py2.py3-none-any.whl/py/_path/local.py:650: in pyimport
                         __import__(modname)
                     E   ImportError: No module named test_safeargs
                      ERROR collecting tests/python/pants_test/backend/graph_info/tasks/test_filemap.py 
                     .pants.d/python-setup/chroots/3d52985dee8888ecc155f0b70f82d84106faf045/.deps/py-1.4.31-py2.py3-none-any.whl/py/_path/local.py:650: in pyimport
                         __import__(modname)
                     E   ImportError: No module named graph_info.tasks.test_filemap
                      ERROR collecting tests/python/pants_test/engine/legacy/test_graph.py 
                     .pants.d/python-setup/chroots/3d52985dee8888ecc155f0b70f82d84106faf045/.deps/py-1.4.31-py2.py3-none-any.whl/py/_path/local.py:650: in pyimport
                         __import__(modname)
                     E   ImportError: No module named legacy.test_graph
                      ERROR collecting tests/python/pants_test/engine/util.py 
                     .pants.d/python-setup/chroots/3d52985dee8888ecc155f0b70f82d84106faf045/.deps/py-1.4.31-py2.py3-none-any.whl/py/_path/local.py:650: in pyimport
                         __import__(modname)
                     E   ImportError: No module named util
  • f

    full-kilobyte-93429

    01/18/2017, 7:43 PM
    restarting the shard to see if flaky
  • b

    billowy-beach-68498

    01/18/2017, 7:49 PM
    I have seen this many times before. but still have no clue why it happened.
  • f

    full-kilobyte-93429

    01/18/2017, 7:52 PM
    oh, when you enable v2 or not?
  • f

    full-kilobyte-93429

    01/18/2017, 7:53 PM
    fwiw this is first time i saw this error
  • b

    billowy-beach-68498

    01/18/2017, 7:54 PM
    when I enable v2 globally yeah, not just for integration tests
  • b

    billowy-beach-68498

    01/18/2017, 7:54 PM
    it happens randomly on different shards
  • b

    billowy-beach-68498

    01/18/2017, 7:55 PM
    probably related to caching, but nuke cache was not helping
  • f

    full-kilobyte-93429

    01/18/2017, 7:55 PM
    might be a blocker to enable default if that happens frequently
  • b

    billowy-beach-68498

    01/18/2017, 7:55 PM
    yeah
  • r

    rough-minister-58256

    01/18/2017, 7:56 PM
    but it never repros locally?
  • f

    full-kilobyte-93429

    01/18/2017, 7:56 PM
    my retry now passed that point so it's flaky
  • f

    full-kilobyte-93429

    01/18/2017, 7:57 PM
    @rough-minister-58256 not sure
  • b

    billowy-beach-68498

    01/18/2017, 7:59 PM
    I had a hypothesis about "./pants filter" output order is different between v1 and v2 engine, causing different targets been distributed to a certain shard when running v2 engine as opposed to v1 engine.
  • b

    billowy-beach-68498

    01/18/2017, 7:59 PM
    but I haven't dug deep
  • b

    billowy-beach-68498

    01/18/2017, 8:00 PM
    restart a certain job may pass, but I remember restart the entire build will give you that error every time.
  • b

    billowy-beach-68498

    01/18/2017, 8:00 PM
    that may mean, for every ci we have to manually restart failed job in the future?
  • b

    billowy-beach-68498

    01/18/2017, 8:01 PM
    but I haven't tried it for quite a while thus I am not sure if it's still the case
  • b

    billowy-beach-68498

    01/18/2017, 8:02 PM
    @rough-minister-58256 I haven't reproed it locally
1...207208209...906Latest